Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
Hello, On 29 Jun 2002, Kris Karas wrote: On Thu, 2002-06-27 at 02:26, [EMAIL PROTECTED] wrote: Here is the patch: http://cvs.php.net/diff.php/php4/ext/ldap/ldap.c?r1=1.121r2=1.123ty=u (And I just fixed that \n thing :) Super. Tested over the past 36 hours or so, no problems encountered. If you want to, feel free to change those entries that read %s(): The ldap_foo call failed: %s to %s(): %s as the automatic funtion-name inclusion makes most of the error text pretty redundant. I had added the text in my patch so as to give the user a clue as to which of his/her functions triggered the error; but that was without realizing that PHP4 provides a more automatic and elegant mechanism for doing this automatically. Ok, I fixed this now. Derick --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
On 26 Jun 2002, Kristofer T. Karas wrote: On Wed, 2002-06-26 at 15:47, [EMAIL PROTECTED] wrote: I think I caught that one... can you make sure? BTW.. I did a few other extensions too :) My pleasure! :-) But I'm not using CVS, so if you wouldn't mind, send it hither in email and I'll test locally. Here is the patch: http://cvs.php.net/diff.php/php4/ext/ldap/ldap.c?r1=1.121r2=1.123ty=u (And I just fixed that \n thing :) Derick --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
On Tue, Jun 25, 2002 at 08:13:29PM -0400, Kristofer T. Karas wrote: I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that $x = ldap_add(...); dumps verbiage to stderr if the add fails, despite the . Figured it'd be faster to fix it than to whine and complain. In fixing, I found some inconsistency in the way errors are reported - some with explanations (e.g. a call to ldap_err2string) and some without. I removed the offending ldap_perror calls (which don't honor , obviously) and augmented the php_error calls. Patch attached. Oh, I couldn't find a FAQ question handy regarding patch submission, so I hope I'm not violating etiquette. At least the patch isn't enormous. :-) Thanks, I'll review your patch more carefully before I apply it, but it looks good. We should indeed be consistent. Mailing patches to this list is fine. Stig -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
On Wed, 26 Jun 2002, Stig Venaas wrote: On Tue, Jun 25, 2002 at 08:13:29PM -0400, Kristofer T. Karas wrote: I'm using OpenLDAP 1.x in PHP 4.2.1, and was dismayed that $x = @ldap_add(...); dumps verbiage to stderr if the add fails, despite the @. Figured it'd be faster to fix it than to whine and complain. In fixing, I found some inconsistency in the way errors are reported - some with explanations (e.g. a call to ldap_err2string) and some without. I removed the offending ldap_perror calls (which don't honor @, obviously) and augmented the php_error calls. Patch attached. Oh, I couldn't find a FAQ question handy regarding patch submission, so I hope I'm not violating etiquette. At least the patch isn't enormous. :-) Thanks, I'll review your patch more carefully before I apply it, but it looks good. We should indeed be consistent. Mailing patches to this list is fine. Stig, I just patched it... and made it even more conformant to the rest of the PHP extensions. I am currently testing. Derick --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
On Wed, 2002-06-26 at 02:40, [EMAIL PROTECTED] wrote: On Wed, 26 Jun 2002, Stig Venaas wrote: Thanks, I'll review your patch more carefully before I apply it Stig, I just patched it... and made it even more conformant to the rest of the PHP extensions. I am currently testing. Super. But, mia culpa, I realized just after pressing Submit that I missed one instance where \n was included at the end of a php_error(...) call. There were a bunch of them in the original source that I removed in the patch. Thanks Derick for making the patch more conformant... Kris -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] [Patch] LDAP Error reporting for 4.2.1
On 26 Jun 2002, Kristofer T. Karas wrote: On Wed, 2002-06-26 at 02:40, [EMAIL PROTECTED] wrote: On Wed, 26 Jun 2002, Stig Venaas wrote: Thanks, I'll review your patch more carefully before I apply it Stig, I just patched it... and made it even more conformant to the rest of the PHP extensions. I am currently testing. Super. But, mia culpa, I realized just after pressing Submit that I missed one instance where \n was included at the end of a php_error(...) call. There were a bunch of them in the original source that I removed in the patch. Thanks Derick for making the patch more conformant... I think I caught that one... can you make sure? BTW.. I did a few other extensions too :) Derick --- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --- PHP: Scripting the Web - [EMAIL PROTECTED] All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net --- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php