Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

[Anil Madhavapeddy]

Andi Gutmans wrote:
> I suggest you merge this into 4.0.5 because it seems to me
> that otherwise output buffering will be quite a mess without
> it. It would be a shame to release 4.0.5 without it.

Ok, done.

> Your fix looks OK but I'd like to hear the opinion of someone
> else who is more familiar with RFC2616.

Hope I didn't jump the gun with the merge (read this mail right after the
commit).

Here is the relevant excerpt from the RFC:

13.6 Caching Negotiated Responses

   Use of server-driven content negotiation (section 12.1), as indicated
   by the presence of a Vary header field in a response, alters the
   conditions and procedure by which a cache can use the response for
   subsequent requests. See section 14.44 for use of the Vary header
   field by servers.

   A server SHOULD use the Vary header field to inform a cache of what
   request-header fields were used to select among multiple
   representations of a cacheable response subject to server-driven
   negotiation. The set of header fields named by the Vary field value
   is known as the "selecting" request-headers.

   When the cache receives a subsequent request whose Request-URI
   specifies one or more cache entries including a Vary header field,
   the cache MUST NOT use such a cache entry to construct a response to
   the new request unless all of the selecting request-headers present
   in the new request match the corresponding stored request-headers in
   the original request.

Note that the current PEAR implementation of HTTP::Compress sends exactly
this Vary header also, and works great.

Anil


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

[Andi Gutmans]

At 05:37 PM 4/2/2001 +0100, Anil Madhavapeddy wrote:
>Andi Gutmans wrote:
>
> > Does anyone else have any critical bug fixes
> > which need to be in 4.0.5? (I mean critical ones and not
> > huge patches).
>
>Zeev's output buffering fix hasn't been committed yet; it's a one-line
>change, and it makes the transparent output compression stuff work.

I suggest you merge this into 4.0.5 because it seems to me that otherwise 
output buffering will be quite a mess without it. It would be a shame to 
release 4.0.5 without it.


>Does anyone have any objection to an MFH on the small Vary header patch
>also?  It improves PHP's RFC2616 compliance, but it also unbreaks almost
>every web-cache, which rely on having it present for content-negotiated
>pages.

Your fix looks OK but I'd like to hear the opinion of someone else who is 
more familiar with RFC2616.

Andi


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] RE: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

[James Moore]

> Zeev's output buffering fix hasn't been committed yet; it's a one-line
> change, and it makes the transparent output compression stuff work.

MFH it then and we can get 4.0.5 out the door ;)

James

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

[Anil Madhavapeddy]

Andi Gutmans wrote:

> Does anyone else have any critical bug fixes
> which need to be in 4.0.5? (I mean critical ones and not
> huge patches).

Zeev's output buffering fix hasn't been committed yet; it's a one-line
change, and it makes the transparent output compression stuff work.

Does anyone have any objection to an MFH on the small Vary header patch
also?  It improves PHP's RFC2616 compliance, but it also unbreaks almost
every web-cache, which rely on having it present for content-negotiated
pages.

Anil


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]