Re: [PHP-DEV] Re: cvs: php4 / Makefile.global run-tests.php

2002-11-08 Thread Yasuo Ohgaki 
Yasuo Ohgaki wrote:

Derick,

I've pointed out problems _WEEKS_ ago.
I let you know problems _MANY_ times.

Derick, be responsible with your change and opinion at least.
Don't forget you're the one broke it w/o discussion first.
When I add "-c php.ini-dist", there is discussion. As a result,
there is -c option.

Please revert your patch. (And don't forget to remove double
-d 'safe_mode=0')


I don't see commit that fixes problems yet.
When you'll do that?

--
Yasuo Ohgaki




BTW, everyone agree with Derick's statement for such
a simple & obvious bug fixes with CVS managed sources?

--
Yasuo Ohgaki

Derick Rethans wrote:


On Thu, 31 Oct 2002, Yasuo Ohgaki wrote:



Derick Rethans wrote:


derickThu Oct 31 09:02:00 2002 EDT

 Modified files: /php4Makefile.global 
run-tests.php  Log:
 Discuss first!


Huh? What do you mean discuss first?
There is discussion and the patch is valid.

In addition, you're the one insisted certain ini should
not be used.

Let me know how you would like to solve puzzle. For instance,
if users is disabling some functions that are needed by
run-tests.php?

You should have clever idea that I cannot think of ;)




Authors: Ilia Alshanetsky <[EMAIL PROTECTED]> 
 Preston L. Bannister <[EMAIL PROTECTED]>   
 Marcus Boerger <[EMAIL PROTECTED]>  
 Derick Rethans <[EMAIL PROTECTED]> 
 Sander Roobol <[EMAIL PROTECTED]> 
Those people commit to run-tests.php from now, whether a patch is 
valid or not. If too much other people keep messing with it we will 
never get a valid and stable testsuite.
Derick





--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: cvs: php4 / Makefile.global run-tests.php

2002-10-31 Thread Yasuo Ohgaki 
Derick,

I've pointed out problems _WEEKS_ ago.
I let you know problems _MANY_ times.

Derick, be responsible with your change and opinion at least.
Don't forget you're the one broke it w/o discussion first.
When I add "-c php.ini-dist", there is discussion. As a result,
there is -c option.

Please revert your patch. (And don't forget to remove double
-d 'safe_mode=0')

BTW, everyone agree with Derick's statement for such
a simple & obvious bug fixes with CVS managed sources?

--
Yasuo Ohgaki

Derick Rethans wrote:

On Thu, 31 Oct 2002, Yasuo Ohgaki wrote:



Derick Rethans wrote:


derick		Thu Oct 31 09:02:00 2002 EDT

 Modified files:  
   /php4	Makefile.global run-tests.php 
 Log:
 Discuss first!

Huh? What do you mean discuss first?
There is discussion and the patch is valid.

In addition, you're the one insisted certain ini should
not be used.

Let me know how you would like to solve puzzle. For instance,
if users is disabling some functions that are needed by
run-tests.php?

You should have clever idea that I cannot think of ;)



Authors: Ilia Alshanetsky <[EMAIL PROTECTED]> 
 Preston L. Bannister <[EMAIL PROTECTED]>   
 Marcus Boerger <[EMAIL PROTECTED]>  
 Derick Rethans <[EMAIL PROTECTED]> 
 Sander Roobol <[EMAIL PROTECTED]>  

Those people commit to run-tests.php from now, whether a patch is valid 
or not. If too much other people keep messing with it we will never get 
a valid and stable testsuite. 

Derick



--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: cvs: php4 / Makefile.global run-tests.php

2002-10-31 Thread Derick Rethans 
On Thu, 31 Oct 2002, Yasuo Ohgaki wrote:

> Derick Rethans wrote:
> > derick  Thu Oct 31 09:02:00 2002 EDT
> > 
> >   Modified files:  
> > /php4   Makefile.global run-tests.php 
> >   Log:
> >   Discuss first!
> 
> Huh? What do you mean discuss first?
> There is discussion and the patch is valid.
> 
> In addition, you're the one insisted certain ini should
> not be used.
> 
> Let me know how you would like to solve puzzle. For instance,
> if users is disabling some functions that are needed by
> run-tests.php?
> 
> You should have clever idea that I cannot think of ;)

Authors: Ilia Alshanetsky <[EMAIL PROTECTED]> 
 Preston L. Bannister <[EMAIL PROTECTED]>   
 Marcus Boerger <[EMAIL PROTECTED]>  
 Derick Rethans <[EMAIL PROTECTED]> 
 Sander Roobol <[EMAIL PROTECTED]>  

Those people commit to run-tests.php from now, whether a patch is valid 
or not. If too much other people keep messing with it we will never get 
a valid and stable testsuite. 

Derick

-- 

---
 Derick Rethans   http://derickrethans.nl/ 
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: cvs: php4 / Makefile.global run-tests.php

2002-10-31 Thread Yasuo Ohgaki 
Derick Rethans wrote:
> derickThu Oct 31 09:02:00 2002 EDT
> 
>   Modified files:  
> /php4 Makefile.global run-tests.php 
>   Log:
>   Discuss first!

Huh? What do you mean discuss first?
There is discussion and the patch is valid.

In addition, you're the one insisted certain ini should
not be used.

Let me know how you would like to solve puzzle. For instance,
if users is disabling some functions that are needed by
run-tests.php?

You should have clever idea that I cannot think of ;)

--
Yasuo Ohgaki

>   
>   
> Index: php4/Makefile.global
> diff -u php4/Makefile.global:1.38 php4/Makefile.global:1.39
> --- php4/Makefile.global:1.38 Thu Oct 31 08:52:58 2002
> +++ php4/Makefile.global  Thu Oct 31 09:01:58 2002
> @@ -50,7 +50,7 @@
>   @TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \
>TEST_PHP_SRCDIR=$(top_srcdir) \
>CC=$(CC) \
> - $(top_builddir)/$(SAPI_CLI_PATH) -d 'open_basedir=' -d 
>'safe_mode=0' -d 'safe_mode=0' -d 'output_buffering=Off' -d 'auto_prepend_file=' -d 
>'auto_append_file=' -d 'output_handler=' -d 'register_argv=1' -d 'disable_functions=' 
>$(top_srcdir)/run-tests.php $(TESTS)
> + $(top_builddir)/$(SAPI_CLI_PATH) -d 'open_basedir=' -d 
>'safe_mode=0' $(top_srcdir)/run-tests.php $(TESTS)
>  
>  clean:
>   find . -name \*.lo -o -name \*.o | xargs rm -f
> Index: php4/run-tests.php
> diff -u php4/run-tests.php:1.103 php4/run-tests.php:1.104
> --- php4/run-tests.php:1.103  Thu Oct 31 08:52:58 2002
> +++ php4/run-tests.phpThu Oct 31 09:01:58 2002
> @@ -44,9 +44,8 @@
>  
>  $cwd = getcwd();
>  set_time_limit(0);
> +ob_implicit_flush();
>  error_reporting(E_ALL);
> -ini_set('magic_quotes_runtime', 0);
> -ini_set('memory_limit', '8M');
>  
>  if (ini_get('safe_mode')) {
>   echo <<< SAFE_MODE_WARNING
> 
> 


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php