Re: [PHP-DEV] Reduce codebase

[Marcus Börger]

At 21:54 06.12.2002, Stig S. Bakken wrote:

--enable-maintainer-mode?

 - Stig



maintainer mode is already coupled to Zend's DEBUG_CFLAGS.
But it is a well known feature of the autoconf tools so the question
is mainly if we require all developers to run maintainer mode before
using that switch in the way described below.

marcus


On Thu, 2002-12-05 at 17:16, Marcus Börger wrote:
> In a discussion about image.c code i was reminded that we do not need
> to bother with emalloc returning NULL or array_init returning FAILURE.
> Unforuately there are hundreds of such cases in PHP. When removing
> all these parts with all the necessary checks and error messages we
> could reduce the code base
>
> Indeed there is a simple way of doing so for array_init: change those
> functions to be of return type void.
>
> To make everybodys life easier i suggest we create a new configure
> option --enable-developer or such which simply creates a define
> that allows such changes. I would the like to have --enable-developer
> being a shortcut for --enable-debug also (zts would break some builds
> otherwise that also). When all developers would use this option i
> guess such changes could be done easily and they would not harm
> the normal users.
>
> marcus
>

--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php



--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Reduce codebase

[Stig S. Bakken]

--enable-maintainer-mode?

 - Stig

On Thu, 2002-12-05 at 17:16, Marcus Börger wrote:
> In a discussion about image.c code i was reminded that we do not need
> to bother with emalloc returning NULL or array_init returning FAILURE.
> Unforuately there are hundreds of such cases in PHP. When removing
> all these parts with all the necessary checks and error messages we
> could reduce the code base
> 
> Indeed there is a simple way of doing so for array_init: change those
> functions to be of return type void.
> 
> To make everybodys life easier i suggest we create a new configure
> option --enable-developer or such which simply creates a define
> that allows such changes. I would the like to have --enable-developer
> being a shortcut for --enable-debug also (zts would break some builds
> otherwise that also). When all developers would use this option i
> guess such changes could be done easily and they would not harm
> the normal users.
> 
> marcus
> 

--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Reduce codebase

[Marcus Börger]

In a discussion about image.c code i was reminded that we do not need
to bother with emalloc returning NULL or array_init returning FAILURE.
Unforuately there are hundreds of such cases in PHP. When removing
all these parts with all the necessary checks and error messages we
could reduce the code base

Indeed there is a simple way of doing so for array_init: change those
functions to be of return type void.

To make everybodys life easier i suggest we create a new configure
option --enable-developer or such which simply creates a define
that allows such changes. I would the like to have --enable-developer
being a shortcut for --enable-debug also (zts would break some builds
otherwise that also). When all developers would use this option i
guess such changes could be done easily and they would not harm
the normal users.

marcus


--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php