Re: [PHP-DEV] please patch for dbmaker

[André Langhorst]

Jeffrey Lin wrote:

> Hey, there:
> 
> We just added some patch to php CVS specifically for
> our database driver - DBMaker.


Please file a bug (http://bugs.php.net) and copy your patch into it to 
ensure that it does not get overlooked.
Thanks.

-- 
· André Langhorstt: +49 331 5811560 ·
· [EMAIL PROTECTED]  m: +49 173 9558736 ·
* PHP Quality Assurance  http://qa.php.net  *


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] please patch for dbmaker

[Jeffrey Lin]

Jesus!! I couldn't get it right!! Why is that??
Seems to me we can't attach a file in our post.

The incorrect word wrap is at this line:

DM_VER=`echo $DBMAKER_VERSION | sed -e 's/\.//' | awk '{ print
$1-1;}'`





-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for dbmaker

[André Langhorst]

could anyone with basic m4 knowledge look into this, this should be a 
matter of minutes then I guess.

andré

-- 
· André Langhorstt: +49 331 5811560 ·
· [EMAIL PROTECTED]  m: +49 173 9558736 ·
* PHP Quality Assurance  http://qa.php.net  *



Sorry, some incorrect word wrap in my patch.
Please use the attachment instead.

Thanks.





begin 666 patch.txt
M9&EF9B M=7(@<&AP+30N,"XT<&PQ;VQD+V5X="]O9&)C+V-O;F9I9RYM-"!P
M:' M-"XP+C1P;#$O97AT+V]D8F,O8V]N9FEG+FTT#0HM+2T@<&AP+30N,"XT
M<&PQ;VQD+V5X="]O9&)C+V-O;F9I9RYM- E7960@3F]V(#(R(#(S.C,Q.C T
M(#(P,# -"BLK*R!P:' M-"XP+C1P;#$O97AT+V]D8F,O8V]N9FEG+FTT"5=E
M9"!&96(@,C$@,3(Z,C Z,#$@,C P,0T*0$ @+30P-RPX("LT,#http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for dbmaker

[Boian Bonev]

forgot to say that in case of [[ the test word is not needed - [[ is a test
itself:

if [[ -x somefile ]]; .

if test -x somefile; 

b.

- Original Message -
From: "Boian Bonev" <[EMAIL PROTECTED]>
To: "André Langhorst" <[EMAIL PROTECTED]>; "PHP Development"
<[EMAIL PROTECTED]>
Sent: Thursday, February 22, 2001 5:40 AM
Subject: Re: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch
for dbmaker


> hi,
>
> this is not m4 but /bin/sh stuff... afaik [[ is bash specific boolean
test.
> so the patch _seems_ to be correct...
>
> b.
>
> - Original Message -
> From: "André Langhorst" <[EMAIL PROTECTED]>
> To: "PHP Development" <[EMAIL PROTECTED]>
> Sent: Thursday, February 22, 2001 5:31 AM
> Subject: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for
> dbmaker
>
>
> > could anyone with basic m4 knowledge look into this, this should be a
> > matter of minutes then I guess.
> >
> > andré
> >
> > --
> > · André Langhorstt: +49 331 5811560 ·
> > · [EMAIL PROTECTED]  m: +49 173 9558736 ·
> > * PHP Quality Assurance  http://qa.php.net  *
> >
>
>
> --
--
> 
>
>
> > --
> > PHP Development Mailing List <http://www.php.net/>
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> > To contact the list administrators, e-mail: [EMAIL PROTECTED]
>
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> To contact the list administrators, e-mail: [EMAIL PROTECTED]
>
>


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] please patch for dbmaker

[Jeffrey Lin]

The original patch has some incorrect word wrap,
let me post it once again.
Sorry!!

 BEGIN PATCH 

diff -ur php-4.0.4pl1old/ext/odbc/config.m4 php-4.0.4pl1/ext/odbc/config.m4
--- php-4.0.4pl1old/ext/odbc/config.m4 Wed Nov 22 23:31:04 2000
+++ php-4.0.4pl1/ext/odbc/config.m4 Wed Feb 21 12:20:01 2001
@@ -407,8 +407,8 @@
 # check DBMaker version (from 5.0 to 2.0)
 DBMAKER_VERSION=5.0

-while [[ test ! -d $DBMAKER_HOME/$DBMAKER_VERSION -a \
- "$DBMAKER_VERSION" != "2.9" ]]; do
+while test ! -d $DBMAKER_HOME/$DBMAKER_VERSION -a \
+ "$DBMAKER_VERSION" != "2.9"; do
 DM_VER=`echo $DBMAKER_VERSION | sed -e 's/\.//' | awk '{ print
$1-1;}'`
 MAJOR_V=`echo $DM_VER | awk '{ print $1/10; }' \
  | awk  -F. '{ print $1; }'`
@@ -416,7 +416,7 @@
 DBMAKER_VERSION=$MAJOR_V.$MINOR_V
 done

-if [[ "$DBMAKER_VERSION" = "2.9" ]]; then
+if test "$DBMAKER_VERSION" = "2.9"; then
 withval=$DBMAKER_HOME
 else
 DBMAKER_PATH=$DBMAKER_HOME/$DBMAKER_VERSION

 END PATCH 





-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for dbmaker

[Jeffrey Lin]

That's what caused compilation error.
Originally in ext/odbc/config.m4, the line is
if [[ test -x somefile ]];

"Boian Bonev" ¼¶¼g©ó¤å³¹ <033801c09c81$afbe9170$040a0a0a@blue>...
>forgot to say that in case of [[ the test word is not needed - [[ is a test
>itself:
>
>if [[ -x somefile ]]; .
>
>if test -x somefile; 
>
>b.
>




-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for dbmaker

[Boian Bonev]

hi,

this is not m4 but /bin/sh stuff... afaik [[ is bash specific boolean test.
so the patch _seems_ to be correct...

b.

- Original Message -
From: "André Langhorst" <[EMAIL PROTECTED]>
To: "PHP Development" <[EMAIL PROTECTED]>
Sent: Thursday, February 22, 2001 5:31 AM
Subject: [PHP-DEV] anyone with m4 knowledge -> [PHP-DEV] please patch for
dbmaker


> could anyone with basic m4 knowledge look into this, this should be a
> matter of minutes then I guess.
>
> andré
>
> --
> · André Langhorstt: +49 331 5811560 ·
> · [EMAIL PROTECTED]  m: +49 173 9558736 ·
> * PHP Quality Assurance  http://qa.php.net  *
>






> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> To contact the list administrators, e-mail: [EMAIL PROTECTED]


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] please patch for dbmaker

[Jeffrey Lin]

Sorry, some incorrect word wrap in my patch.
Please use the attachment instead.

Thanks.





begin 666 patch.txt
M9&EF9B M=7(@<&AP+30N,"XT<&PQ;VQD+V5X="]O9&)C+V-O;F9I9RYM-"!P
M:' M-"XP+C1P;#$O97AT+V]D8F,O8V]N9FEG+FTT#0HM+2T@<&AP+30N,"XT
M<&PQ;VQD+V5X="]O9&)C+V-O;F9I9RYM- E7960@3F]V(#(R(#(S.C,Q.C T
M(#(P,# -"BLK*R!P:' M-"XP+C1P;#$O97AT+V]D8F,O8V]N9FEG+FTT"5=E
M9"!&96(@,C$@,3(Z,C Z,#$@,C P,0T*0$ @+30P-RPX("LT,#http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

[PHP-DEV] please patch for dbmaker

[Jeffrey Lin]

Hey, there:

We just added some patch to php CVS specifically for
our database driver - DBMaker.

The modifications are made in one file, ext/odbc/config.m4.

For config.m4, we did some modifications to the paths to
our database driver.

Would you please be kind enough to include this patch to the
future releases of PHP as soon as possible? We really
appreciate it.

Thanks a lot.

--chihfeng

 BEGIN PATCH 


diff -ur php-4.0.4pl1old/ext/odbc/config.m4 php-4.0.4pl1/ext/odbc/config.m4
--- php-4.0.4pl1old/ext/odbc/config.m4 Wed Nov 22 23:31:04 2000
+++ php-4.0.4pl1/ext/odbc/config.m4 Wed Feb 21 12:20:01 2001
@@ -407,8 +407,8 @@
 # check DBMaker version (from 5.0 to 2.0)
 DBMAKER_VERSION=5.0

-while [[ test ! -d $DBMAKER_HOME/$DBMAKER_VERSION -a \
- "$DBMAKER_VERSION" != "2.9" ]]; do
+while test ! -d $DBMAKER_HOME/$DBMAKER_VERSION -a \
+ "$DBMAKER_VERSION" != "2.9"; do
 DM_VER=`echo $DBMAKER_VERSION | sed -e 's/\.//' | awk '{ print
$1-1;}'`
 MAJOR_V=`echo $DM_VER | awk '{ print $1/10; }' \
  | awk  -F. '{ print $1; }'`
@@ -416,7 +416,7 @@
 DBMAKER_VERSION=$MAJOR_V.$MINOR_V
 done

-if [[ "$DBMAKER_VERSION" = "2.9" ]]; then
+if test "$DBMAKER_VERSION" = "2.9"; then
 withval=$DBMAKER_HOME
 else
 DBMAKER_PATH=$DBMAKER_HOME/$DBMAKER_VERSION


 END PATCH 




-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]