Re: [PHP-DEV] BC problem
Nope :) At 09:19 30/11/2001, Jani Taskinen wrote: As a minor cosmetic detail, could you set the version for the 'next' release of 4.1 to be 4.1.1 ? Many people have downloaded the broken 'release' of 4.1.0 now so we have to be able to know what version people are using when they submit bug reports. --Jani -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
On Fri, Nov 30, 2001 at 01:40:54PM +0200, Zeev Suraski wrote : Nope :) But you can update the NEWS file to say '4.1' and not '4.0' at the top X-D - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
How about in future to avoid this happening when we roll the release tag as 4.1.0 or whatever call the tar.gz file php-4.1.0pre1.tar.gz then it becomes slightly more obvious its not 4.1.0 also all we then have to do is rename php-4.1.0pre1 to php-4.1.0.tar.gz to do the release no need to reroll where a mistake could happen. - James Nope :) At 09:19 30/11/2001, Jani Taskinen wrote: As a minor cosmetic detail, could you set the version for the 'next' release of 4.1 to be 4.1.1 ? Many people have downloaded the broken 'release' of 4.1.0 now so we have to be able to know what version people are using when they submit bug reports. --Jani -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Yep :) At 13:53 30/11/2001, Markus Fischer wrote: On Fri, Nov 30, 2001 at 01:40:54PM +0200, Zeev Suraski wrote : Nope :) But you can update the NEWS file to say '4.1' and not '4.0' at the top X-D - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I I'll submit the patches to revert this change and roll RC4 today. I want to hear opinions on whether this RC4 should be based on the RC3 tag, or whether it should also include the few fixes that were submitted to the branch since RC3 was rolled... If you have one, let us know about it :) Zeev At 00:50 29/11/2001, Markus Fischer wrote: On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : Yep. As far as I remember it was reverted in 4.1.0 No, it doesn't seem to be reverted: $ ~/php410/bin/php -v 4.1.0 $ ~/php410/bin/php -f include_it.php 1br 2br br include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
On Thu, 29 Nov 2001, Zeev Suraski wrote: Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I I'll submit the patches to revert this change and roll RC4 today. I want to hear opinions on whether this RC4 should be based on the RC3 tag, or whether it should also include the few fixes that were submitted to the branch since RC3 was rolled... If you have one, let us know about it :) IMO, also include the few fixes after RC3 was rolled. Derick -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
RE: [PHP-DEV] BC problem
Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I I'll submit the patches to revert this change and roll RC4 today. I want to hear opinions on whether this RC4 should be based on the RC3 tag, or whether it should also include the few fixes that were submitted to the branch since RC3 was rolled... If you have one, let us know about it :) If this includes the imap patch, then I'm definitly for the inclusion. -- Richard Heyes If you have any trouble sounding condescending, find a Unix user to show you how it's done. - Scott Adams -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Can you verify that this problem is gone in the latest CVS of PHP_4_0_7
(make sure you update the Zend directory)
Zeev
At 20:05 28/11/2001, Markus Fischer wrote:
A small example which shows that BC seems to be broken for a
certain (but not uncommon) case:
cat include_me.php
?
if (!defined('I_AM_INCLUDED')) {
define('I_AM_INCLUDED', 1);
} else {
echo returningbr\n;
return;
}
function cant_be_redefined() {
}
?
cat include_it.php
?
echo 1br\n;
include 'include_me.php';
echo 2br\n;
include 'include_me.php';
echo 3br\n;
?
Now run include_it.php (it doesn't matter if its CGI or
module):
On PHP 4.0.4pl1 up to 4.0.6 this gives:
1br
2br
returningbr
3br
But now I get:
1br
2br
br /
Fatal error - Cannot redeclare cant_be_redefined()
(previously declared in include_me.php:9)
[I shortened the error message to be more readable]
If this is 'now the way it is' this should be mentioned
somewhere very clearly I think. Doesn't seem to be fixable in
some way? Couldn't find a reference to it e.g. in the NEWS
file.
I know that there should be used include_once() but
I'm talking about existing code writing that way which
definitely won't work without modifications.
- Markus
ps: thanks to Jan for verifying this!
--
Please always Cc to me when replying to me on the lists.
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
On Thu, Nov 29, 2001 at 01:16:02PM +0200, Zeev Suraski wrote : Can you verify that this problem is gone in the latest CVS of PHP_4_0_7 (make sure you update the Zend directory) Yes, it seems to work: $ ~/isrc/cvs/test/php4/php -v 4.1.0 $ ~/isrc/cvs/test/php4/php -f include_it.php 1br 2br returningbr 3br I just hope I did the checkout the right way? cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 php4 cd php4 cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 Zend cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 TSRM Someone else better test this too. - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
On Thu, 29 Nov 2001, Zeev Suraski wrote: Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I I'll submit the patches to revert this change and roll RC4 today. I want to hear opinions on whether this RC4 should be based on the RC3 tag, or whether it should also include the few fixes that were submitted to the branch since RC3 was rolled... If you have one, let us know about it :) Zeev I think that the small changes should be included. There is a fix for crash in sysvshm which does not affect anything else in the system and since we are going for RC4 anyway no reason to leave it out. Edin -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Are the changes that make Apache 2.0.28 work included in those changes? Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Markus Fischer [EMAIL PROTECTED] Cc: Andi Gutmans [EMAIL PROTECTED]; Brian Moon [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 4:09 AM Subject: Re: [PHP-DEV] BC problem | Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I | I'll submit the patches to revert this change and roll RC4 today. I want | to hear opinions on whether this RC4 should be based on the RC3 tag, or | whether it should also include the few fixes that were submitted to the | branch since RC3 was rolled... If you have one, let us know about it :) | | Zeev | | At 00:50 29/11/2001, Markus Fischer wrote: | On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : | Yep. As far as I remember it was reverted in 4.1.0 | | No, it doesn't seem to be reverted: | | $ ~/php410/bin/php -v | 4.1.0 | $ ~/php410/bin/php -f include_it.php | 1br | 2br | br | include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() | | - Markus | | -- | PHP Development Mailing List http://www.php.net/ | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | To contact the list administrators, e-mail: [EMAIL PROTECTED] | | | -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
I don't believe so. They should be either, as Apache 2.0 is alpha code... Zeev At 16:09 29/11/2001, Brian Moon wrote: Are the changes that make Apache 2.0.28 work included in those changes? Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Markus Fischer [EMAIL PROTECTED] Cc: Andi Gutmans [EMAIL PROTECTED]; Brian Moon [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 4:09 AM Subject: Re: [PHP-DEV] BC problem | Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I | I'll submit the patches to revert this change and roll RC4 today. I want | to hear opinions on whether this RC4 should be based on the RC3 tag, or | whether it should also include the few fixes that were submitted to the | branch since RC3 was rolled... If you have one, let us know about it :) | | Zeev | | At 00:50 29/11/2001, Markus Fischer wrote: | On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : | Yep. As far as I remember it was reverted in 4.1.0 | | No, it doesn't seem to be reverted: | | $ ~/php410/bin/php -v | 4.1.0 | $ ~/php410/bin/php -f include_it.php | 1br | 2br | br | include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() | | - Markus | | -- | PHP Development Mailing List http://www.php.net/ | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | To contact the list administrators, e-mail: [EMAIL PROTECTED] | | | -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
2.0.28 brought it into beta. Current HEAD of PHP works fine. I just thought if there is going to be a release of PHP we might want it to work with all the latest builds if possible. The code is there in HEAD. Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Brian Moon [EMAIL PROTECTED] Cc: Markus Fischer [EMAIL PROTECTED]; Andi Gutmans [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 8:14 AM Subject: Re: [PHP-DEV] BC problem I don't believe so. They should be either, as Apache 2.0 is alpha code... Zeev At 16:09 29/11/2001, Brian Moon wrote: Are the changes that make Apache 2.0.28 work included in those changes? Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Markus Fischer [EMAIL PROTECTED] Cc: Andi Gutmans [EMAIL PROTECTED]; Brian Moon [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 4:09 AM Subject: Re: [PHP-DEV] BC problem | Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I | I'll submit the patches to revert this change and roll RC4 today. I want | to hear opinions on whether this RC4 should be based on the RC3 tag, or | whether it should also include the few fixes that were submitted to the | branch since RC3 was rolled... If you have one, let us know about it :) | | Zeev | | At 00:50 29/11/2001, Markus Fischer wrote: | On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : | Yep. As far as I remember it was reverted in 4.1.0 | | No, it doesn't seem to be reverted: | | $ ~/php410/bin/php -v | 4.1.0 | $ ~/php410/bin/php -f include_it.php | 1br | 2br | br | include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() | | - Markus | | -- | PHP Development Mailing List http://www.php.net/ | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | To contact the list administrators, e-mail: [EMAIL PROTECTED] | | | -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
HEAD is very far away from 4.1.0. Apache 2.0 moves between Alpha and Beta, and this isn't necessarily a unidirectional move :) This won't be in 4.1.0. Zeev At 18:11 29/11/2001, Brian Moon wrote: 2.0.28 brought it into beta. Current HEAD of PHP works fine. I just thought if there is going to be a release of PHP we might want it to work with all the latest builds if possible. The code is there in HEAD. Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Brian Moon [EMAIL PROTECTED] Cc: Markus Fischer [EMAIL PROTECTED]; Andi Gutmans [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 8:14 AM Subject: Re: [PHP-DEV] BC problem I don't believe so. They should be either, as Apache 2.0 is alpha code... Zeev At 16:09 29/11/2001, Brian Moon wrote: Are the changes that make Apache 2.0.28 work included in those changes? Brian. - Original Message - From: Zeev Suraski [EMAIL PROTECTED] To: Markus Fischer [EMAIL PROTECTED] Cc: Andi Gutmans [EMAIL PROTECTED]; Brian Moon [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Thursday, November 29, 2001 4:09 AM Subject: Re: [PHP-DEV] BC problem | Ok then, looks like we got ourselves a winner. We'll have an RC4 after all :I | I'll submit the patches to revert this change and roll RC4 today. I want | to hear opinions on whether this RC4 should be based on the RC3 tag, or | whether it should also include the few fixes that were submitted to the | branch since RC3 was rolled... If you have one, let us know about it :) | | Zeev | | At 00:50 29/11/2001, Markus Fischer wrote: | On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : | Yep. As far as I remember it was reverted in 4.1.0 | | No, it doesn't seem to be reverted: | | $ ~/php410/bin/php -v | 4.1.0 | $ ~/php410/bin/php -f include_it.php | 1br | 2br | br | include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() | | - Markus | | -- | PHP Development Mailing List http://www.php.net/ | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | To contact the list administrators, e-mail: [EMAIL PROTECTED] | | | -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
RE: [PHP-DEV] BC problem
Title: RE: [PHP-DEV] BC problem [EMAIL PROTECTED] writes: IMO, also include the few fixes after RC3 was rolled. I agree. Mike Robinson IT / Developer - Toronto Star TV Phone: 416.945.8786 Fax: 416.869.4566 Email: [EMAIL PROTECTED] http://www.torontostartv.com - Webcasting Production http://www.tmgtv.ca - Hometown Television http://www.thestar.com - Canadas largest daily newspaper, The Toronto Star, online -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Hi, On Thu, 29 Nov 2001 12:49:19 +0100 Markus Fischer [EMAIL PROTECTED] wrote: On Thu, Nov 29, 2001 at 01:16:02PM +0200, Zeev Suraski wrote : Can you verify that this problem is gone in the latest CVS of PHP_4_0_7 (make sure you update the Zend directory) Yes, it seems to work: $ ~/isrc/cvs/test/php4/php -v 4.1.0 $ ~/isrc/cvs/test/php4/php -f include_it.php 1br 2br returningbr 3br I just hope I did the checkout the right way? cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 php4 cd php4 cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 Zend cvs -d :pserver:[EMAIL PROTECTED]:/repository co -r PHP_4_0_7 TSRM Someone else better test this too. I've got the same results on FreeBSD 4.2-STABLE with the PHP_4_0_7 branch. Jan -- Q: Thank Jan? A: http://geschenke.an.dasmoped.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
As a minor cosmetic detail, could you set the version for the 'next' release of 4.1 to be 4.1.1 ? Many people have downloaded the broken 'release' of 4.1.0 now so we have to be able to know what version people are using when they submit bug reports. --Jani -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
This has already been discussed at great length in another thread. I
believe it was decided to put it all back like it was for now and decide on
a better solution later.
Brian.
- Original Message -
From: Markus Fischer [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Wednesday, November 28, 2001 11:05 AM
Subject: [PHP-DEV] BC problem
A small example which shows that BC seems to be broken for a
certain (but not uncommon) case:
cat include_me.php
?
if (!defined('I_AM_INCLUDED')) {
define('I_AM_INCLUDED', 1);
} else {
echo returningbr\n;
return;
}
function cant_be_redefined() {
}
?
cat include_it.php
?
echo 1br\n;
include 'include_me.php';
echo 2br\n;
include 'include_me.php';
echo 3br\n;
?
Now run include_it.php (it doesn't matter if its CGI or
module):
On PHP 4.0.4pl1 up to 4.0.6 this gives:
1br
2br
returningbr
3br
But now I get:
1br
2br
br /
Fatal error - Cannot redeclare cant_be_redefined()
(previously declared in include_me.php:9)
[I shortened the error message to be more readable]
If this is 'now the way it is' this should be mentioned
somewhere very clearly I think. Doesn't seem to be fixable in
some way? Couldn't find a reference to it e.g. in the NEWS
file.
I know that there should be used include_once() but
I'm talking about existing code writing that way which
definitely won't work without modifications.
- Markus
ps: thanks to Jan for verifying this!
--
Please always Cc to me when replying to me on the lists.
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Yep. As far as I remember it was reverted in 4.1.0
Andi
At 01:54 PM 11/28/2001 -0600, Brian Moon wrote:
This has already been discussed at great length in another thread. I
believe it was decided to put it all back like it was for now and decide on
a better solution later.
Brian.
- Original Message -
From: Markus Fischer [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Wednesday, November 28, 2001 11:05 AM
Subject: [PHP-DEV] BC problem
A small example which shows that BC seems to be broken for a
certain (but not uncommon) case:
cat include_me.php
?
if (!defined('I_AM_INCLUDED')) {
define('I_AM_INCLUDED', 1);
} else {
echo returningbr\n;
return;
}
function cant_be_redefined() {
}
?
cat include_it.php
?
echo 1br\n;
include 'include_me.php';
echo 2br\n;
include 'include_me.php';
echo 3br\n;
?
Now run include_it.php (it doesn't matter if its CGI or
module):
On PHP 4.0.4pl1 up to 4.0.6 this gives:
1br
2br
returningbr
3br
But now I get:
1br
2br
br /
Fatal error - Cannot redeclare cant_be_redefined()
(previously declared in include_me.php:9)
[I shortened the error message to be more readable]
If this is 'now the way it is' this should be mentioned
somewhere very clearly I think. Doesn't seem to be fixable in
some way? Couldn't find a reference to it e.g. in the NEWS
file.
I know that there should be used include_once() but
I'm talking about existing code writing that way which
definitely won't work without modifications.
- Markus
ps: thanks to Jan for verifying this!
--
Please always Cc to me when replying to me on the lists.
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
On Wed, Nov 28, 2001 at 10:23:55PM +0200, Andi Gutmans wrote : Yep. As far as I remember it was reverted in 4.1.0 No, it doesn't seem to be reverted: $ ~/php410/bin/php -v 4.1.0 $ ~/php410/bin/php -f include_it.php 1br 2br br include_me.php(10) : Fatal error - Cannot redeclare cant_be_redefined() - Markus -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
This code:
$ less test.php
?php
echo phpversion();
echo br /;
include include.php;
include include.php;
test();
?
$ less include.php
?php
if(defined(INCLUDE)) return;
define(INCLUDE, 1);
function test(){
echo test;
}
?
With 4.0.6 I get:
4.0.6
test
With 4.1 RC3 I get:
4.1.0RC3br /br
bFatal error/b: Cannot redeclare test() in
b/home/brian/public_html/include.php/b on line b9/bbr
with CVS I get:
4.2.0-devbr /br /
bFatal error/b: Cannot redeclare test() (previously declared in
/home/brian/public_html/include.php:8) in
b/home/brian/public_html/include.php/b on line b9/bbr /
Andi, Zeev, I thought we were going to back out that change?
Brian.
- Original Message -
From: Andi Gutmans [EMAIL PROTECTED]
To: Brian Moon [EMAIL PROTECTED]; Markus Fischer
[EMAIL PROTECTED]; [EMAIL PROTECTED]
Sent: Wednesday, November 28, 2001 2:23 PM
Subject: Re: [PHP-DEV] BC problem
| Yep. As far as I remember it was reverted in 4.1.0
|
| Andi
|
| At 01:54 PM 11/28/2001 -0600, Brian Moon wrote:
| This has already been discussed at great length in another thread. I
| believe it was decided to put it all back like it was for now and decide
on
| a better solution later.
|
| Brian.
|
| - Original Message -
| From: Markus Fischer [EMAIL PROTECTED]
| To: [EMAIL PROTECTED]
| Sent: Wednesday, November 28, 2001 11:05 AM
| Subject: [PHP-DEV] BC problem
|
|
| A small example which shows that BC seems to be broken for a
| certain (but not uncommon) case:
|
| cat include_me.php
| ?
| if (!defined('I_AM_INCLUDED')) {
| define('I_AM_INCLUDED', 1);
| } else {
| echo returningbr\n;
| return;
| }
|
| function cant_be_redefined() {
| }
| ?
|
| cat include_it.php
| ?
| echo 1br\n;
| include 'include_me.php';
| echo 2br\n;
| include 'include_me.php';
| echo 3br\n;
| ?
|
| Now run include_it.php (it doesn't matter if its CGI or
| module):
|
| On PHP 4.0.4pl1 up to 4.0.6 this gives:
| 1br
| 2br
| returningbr
| 3br
|
| But now I get:
| 1br
| 2br
| br /
| Fatal error - Cannot redeclare cant_be_redefined()
| (previously declared in include_me.php:9)
|
| [I shortened the error message to be more readable]
|
|
| If this is 'now the way it is' this should be mentioned
| somewhere very clearly I think. Doesn't seem to be fixable in
| some way? Couldn't find a reference to it e.g. in the NEWS
| file.
|
|
| I know that there should be used include_once() but
| I'm talking about existing code writing that way which
| definitely won't work without modifications.
|
| - Markus
|
| ps: thanks to Jan for verifying this!
|
| --
| Please always Cc to me when replying to me on the lists.
|
| --
| PHP Development Mailing List http://www.php.net/
| To unsubscribe, e-mail: [EMAIL PROTECTED]
| For additional commands, e-mail: [EMAIL PROTECTED]
| To contact the list administrators, e-mail:
[EMAIL PROTECTED]
|
|
|
|
|
| --
| PHP Development Mailing List http://www.php.net/
| To unsubscribe, e-mail: [EMAIL PROTECTED]
| For additional commands, e-mail: [EMAIL PROTECTED]
| To contact the list administrators, e-mail: [EMAIL PROTECTED]
|
|
|
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
At 11:04 PM 11/28/2001 -0600, Brian Moon wrote: -snip- With 4.0.6 I get: 4.0.6 test With 4.1 RC3 I get: 4.1.0RC3br /br bFatal error/b: Cannot redeclare test() in b/home/brian/public_html/include.php/b on line b9/bbr with CVS I get: 4.2.0-devbr /br / bFatal error/b: Cannot redeclare test() (previously declared in /home/brian/public_html/include.php:8) in b/home/brian/public_html/include.php/b on line b9/bbr / Andi, Zeev, I thought we were going to back out that change? Did you check the 4.1.0 Zeev packaged? It was supposed to be backed out. I don't have time to check now. Andi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] BC problem
Did you check the 4.1.0 Zeev packaged? It was supposed to be backed out. I don't have time to check now. Still present in this package. Similar script as brian: F:\PHP-41~1.0\RELEAS~2php -q test.php hibr bFatal error/b: Cannot redeclare test() in bF:\PHP-41~1.0\RELEAS~2\include.php/b on line b10/bbr F:\PHP-41~1.0\RELEAS~2php -v 4.1.0 - James -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
