Re: [PHP-DEV] getimagesize() broken in HEAD
On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r2=1.73ty=h Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] getimagesize() broken in HEAD
At 11:20 18.11.2002, Derick Rethans wrote: On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r2=1.73ty=h Derick But i applied the same patch to 4.3 and branch. For me both 4.3 and branch are working. -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] getimagesize() broken in HEAD
I just merged some streams fixes back from the branch, so perhaps it was a streams problem after all? --Wez. On Mon, 18 Nov 2002, Marcus [iso-8859-1] Börger wrote: At 11:20 18.11.2002, Derick Rethans wrote: On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r2=1.73ty=h Derick But i applied the same patch to 4.3 and branch. For me both 4.3 and branch are working. -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] getimagesize() broken in HEAD
Try grabbing this image: lerdorf.com/serverside.png And do a getimagesize() on it. I am getting a negative value for the width. -Rasmus On Mon, 18 Nov 2002, Marcus Börger wrote: At 11:20 18.11.2002, Derick Rethans wrote: On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r2=1.73ty=h Derick But i applied the same patch to 4.3 and branch. For me both 4.3 and branch are working. -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] getimagesize() broken in HEAD
Fixed. Are you on a online book or where does the image come from? marcus At 16:23 18.11.2002, Rasmus Lerdorf wrote: Try grabbing this image: lerdorf.com/serverside.png And do a getimagesize() on it. I am getting a negative value for the width. -Rasmus On Mon, 18 Nov 2002, Marcus Börger wrote: At 11:20 18.11.2002, Derick Rethans wrote: On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r 2=1.73ty=h Derick But i applied the same patch to 4.3 and branch. For me both 4.3 and branch are working. -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] getimagesize() broken in HEAD
It is one I created for a presentation. Just about to give a tutorial at Apachecon here in Vegas and the slide with this image on it was broken because of this bug. I swear that my 100-slide PHP talk is one of the best regression test cases we have for PHP. ;) -Rasmus On Mon, 18 Nov 2002, Marcus Börger wrote: Fixed. Are you on a online book or where does the image come from? marcus At 16:23 18.11.2002, Rasmus Lerdorf wrote: Try grabbing this image: lerdorf.com/serverside.png And do a getimagesize() on it. I am getting a negative value for the width. -Rasmus On Mon, 18 Nov 2002, Marcus Börger wrote: At 11:20 18.11.2002, Derick Rethans wrote: On Mon, 18 Nov 2002, Rasmus Lerdorf wrote: getimagesize() works ok in the 4.3 branch, but in HEAD it is returning weird data. streams problem? too tired to track it down right now. It might have something to do with this patch: http://cvs.php.net/diff.php/php4/ext/standard/image.c?login=2r1=1.72r 2=1.73ty=h Derick But i applied the same patch to 4.3 and branch. For me both 4.3 and branch are working. -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
