Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Sterling Hughes

Christian Stocker wrote:

> On Yesterday, Colin Viebrock wrote:
> 
> 
>>>I've contacted Uwe, and if he doesn't object (or respond ;) within the
>>>next day or so, I'll revert the commit in the 4_0_6 branch (leaving head
>>>alone).
>>>
>>Whoa.
>>
>>Are you saying that 4.0.6 will revert to the domxml "syntax" that was in
>>4.0.4 and previous?  And that 4.0.5 will just have it's own "syntax"?
>>
> 
> no, i don't think, either, that this would be a good idea. but in 4.0.5
> the "old" and the "new" syntax worked (i'm not sure what's really old and
> what's new). so if i want to get the childrens of a root domNode
> i could write:
> 
> $children = domxml_children($root); (the old method ?)
> or
> $children = $root->children; (i assume the new one...)
> 


More accurately i believe:

$children = $root->children();
to
$children = $root->children;

I could be wrong though.


> in 4.0.5 both worked. in 4.0.6 only the second works, the first causes
> a segfault... and segfaults are very annoying for debugging php-code (and
> maybe some coders even don't know, where their error_log file is to look
> for segfaults...)
>


Well the commit I plan on reversing in the branch what happened during 
4.0.6-dev, I got permission from Uwe, so I'll go ahead and do that.

-Sterling


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Christian Stocker

On Yesterday, Colin Viebrock wrote:

>
> > I've contacted Uwe, and if he doesn't object (or respond ;) within the
> > next day or so, I'll revert the commit in the 4_0_6 branch (leaving head
> > alone).
>
> Whoa.
>
> Are you saying that 4.0.6 will revert to the domxml "syntax" that was in
> 4.0.4 and previous?  And that 4.0.5 will just have it's own "syntax"?

no, i don't think, either, that this would be a good idea. but in 4.0.5
the "old" and the "new" syntax worked (i'm not sure what's really old and
what's new). so if i want to get the childrens of a root domNode
i could write:

$children = domxml_children($root); (the old method ?)
or
$children = $root->children; (i assume the new one...)

in 4.0.5 both worked. in 4.0.6 only the second works, the first causes
a segfault... and segfaults are very annoying for debugging php-code (and
maybe some coders even don't know, where their error_log file is to look
for segfaults...)

and if you compare the returned array $children from the above example in
4.0.5 and in 4.0.6 they are quite different, and that's much more annoying
for writing cross-version (what a word...) code.

If the this change stays in 4.0.6 please please at least update the
documentation and clearly state the difference between 4.0.5 and 4.0.6.

chregu


-- 
nam...christian stockeradr...bremgartnerstr. 66, ch-8003 zurich
pho...+41  1 451 6021  www...http://phant.ch/chregu
mob...+41 76 561 8860  [EMAIL PROTECTED]


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Sterling Hughes

Colin Viebrock wrote:

>>I've contacted Uwe, and if he doesn't object (or respond ;) within the
>>next day or so, I'll revert the commit in the 4_0_6 branch (leaving head
>>alone).
>>
> 
> Whoa.
> 
> Are you saying that 4.0.6 will revert to the domxml "syntax" that was in
> 4.0.4 and previous?  And that 4.0.5 will just have it's own "syntax"?
> 
> I've already updated all my scripts to the new syntax, assuming it was the
> way of the future.  Don't tell me we are back-pedalling now!
> 


Ok, maybe I won't ;)))

its odd though, the NEWS file seems to show that 4.0.6 is the release 
where the syntax changes, not 4.0.5, perhaps we're talking about two 
different commits (in 4.0.4 DOM-XML was also overhauled)?

Its just the new syntax seems to be quite buggy (leaks and crashes) and 
a large amount of people are getting surprised and annoyed by the new 
syntax as the documentation does not reflect it, and neither do any of 
the notes in the NEWS file.

-Sterling


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Colin Viebrock


> I've contacted Uwe, and if he doesn't object (or respond ;) within the
> next day or so, I'll revert the commit in the 4_0_6 branch (leaving head
> alone).

Whoa.

Are you saying that 4.0.6 will revert to the domxml "syntax" that was in
4.0.4 and previous?  And that 4.0.5 will just have it's own "syntax"?

I've already updated all my scripts to the new syntax, assuming it was the
way of the future.  Don't tell me we are back-pedalling now!

- Colin


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Sterling Hughes

Andrei Zmievski wrote:

> On Wed, 16 May 2001, Christian Stocker wrote:
> 
>>Hello
>>
>>As mentioned in bug #9896 the api for domxml seems to has changed a
>>lot...
>>it's now almost impossible to write code with domxml which works in 4.0.5
>>and 4.0.6.
>>
>>for example  $root->children() returns a completely different Array
>>(tagname instead of name and so on...).
>>
>>Does this make sense for a minor-update?
>>
>>And all the domxml function still just produce a segfault on 4.0.6. if
>>this is not supported anymore, fine ($root->children() instead of
>>domxml_children($root) works also in 4.0.5), but i'd prefer a fatal error
>>instead of a segfault :)
>>
>>Maybe I have to live with all these api-changes and as soon as all our
>>servers have 4.0.6, it won't be a problem for me. But I think i'm not the
>>only one which disturbs that a little bit.
>>
> 
> I fixed a few memory leaks I found in that extension, but my feeling
> is that there are still lots of them and also many bugs lurking in
> there. I don't know where Uwe is or what he plans to do with the
> extension..
> 


I've contacted Uwe, and if he doesn't object (or respond ;) within the 
next day or so, I'll revert the commit in the 4_0_6 branch (leaving head 
alone).

-Sterling


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Andrei Zmievski

On Wed, 16 May 2001, Christian Stocker wrote:
> Hello
> 
> As mentioned in bug #9896 the api for domxml seems to has changed a
> lot...
> it's now almost impossible to write code with domxml which works in 4.0.5
> and 4.0.6.
> 
> for example  $root->children() returns a completely different Array
> (tagname instead of name and so on...).
> 
> Does this make sense for a minor-update?
> 
> And all the domxml function still just produce a segfault on 4.0.6. if
> this is not supported anymore, fine ($root->children() instead of
> domxml_children($root) works also in 4.0.5), but i'd prefer a fatal error
> instead of a segfault :)
> 
> Maybe I have to live with all these api-changes and as soon as all our
> servers have 4.0.6, it won't be a problem for me. But I think i'm not the
> only one which disturbs that a little bit.

I fixed a few memory leaks I found in that extension, but my feeling
is that there are still lots of them and also many bugs lurking in
there. I don't know where Uwe is or what he plans to do with the
extension..

-Andrei
* "Syntactic sugar causes cancer of the semicolon." -- Alan Perlis *

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Christian Stocker

On Wed, 16 May 2001, Jani Taskinen wrote:

> On Wed, 16 May 2001, Christian Stocker wrote:
>
> >As mentioned in bug #9896 the api for domxml seems to has changed a
> >lot...
> >it's now almost impossible to write code with domxml which works in 4.0.5
> >and 4.0.6.
> >
> >for example  $root->children() returns a completely different Array
> >(tagname instead of name and so on...).
> >
> >Does this make sense for a minor-update?
>
> No, it does not make any sense.
>
> Just curious..what would you think the version number change  should be?
> So that it would tell you that there has been major changes?

i think, 4.1 would make me to have a look, if there were some api-changes.
but not 4.0.5 to 4.0.6...

chregu


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-DEV] issues about domxml in 4.0.6

2001-05-16 Thread Jani Taskinen

On Wed, 16 May 2001, Christian Stocker wrote:

>As mentioned in bug #9896 the api for domxml seems to has changed a
>lot...
>it's now almost impossible to write code with domxml which works in 4.0.5
>and 4.0.6.
>
>for example  $root->children() returns a completely different Array
>(tagname instead of name and so on...).
>
>Does this make sense for a minor-update?

No, it does not make any sense.

Just curious..what would you think the version number change  should be?
So that it would tell you that there has been major changes?

--Jani



-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]