Re: [REVIEW] PSR-16 Simple Cache

[Nicolas Grekas]

On CacheInterface:

>
>- doesn't say what happens when $key is invalid. I guess the same
>exception as PSR-6. Should be written?
>
>
I missed adding one note here: the fact that getMultiple returns *all*
keys, even cache misses, makes it impossible to (efficiently) implement a
PSR-16 to PSR-6 bridge, because it makes it impossible to detect cache
misses.
when given an array, apcu_fetch for example has this other behavior of
returning only the "hit", so it doesn't suffer from this.
Could this be worth considering for a change?

Nicolas

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To post to this group, send email to php-fig@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAOWwgpmEuKiQ_CaNPphWemAKnnZ4isURHJhwt-SDyBetMmk1%3Dw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [REVIEW] PSR-16 Simple Cache

[Rasmus Schultz]

One, and one last minor thing... regarding the DateInterval overload for 
$ttl in set() ... well ... why?

Everyone is going to have to write ugly code to convert these into seconds.

Ironically, the answer is first thing that auto-completes on google as soon 
as you type in "dateinterval", but copy/pasting this garbage 
everywhere, well, why?

Being able to specify the TTL as DateInterval is just a clumsy, round-about 
way to pass an integer argument, is it not?


$seconds = ($delta->s)
 + ($delta->i * 60)
 + ($delta->h * 60 * 60)
 + ($delta->d * 60 * 60 * 24)
 + ($delta->m * 60 * 60 * 24 * 30)
 + ($delta->y * 60 * 60 * 24 * 365);



On Friday, November 25, 2016 at 1:46:23 PM UTC+1, Rasmus Schultz wrote:
>
> Oh, also - a minor question about the decrement() method. Does it go into 
> negative when you hit zero, or does it return false, or what?
>
> On Wednesday, November 16, 2016 at 3:22:20 PM UTC+1, Jordi Boggiano wrote:
>>
>> Heya, 
>>
>> We believe PSR-16, Simple Cache, is now ready for final review. As 
>> coordinator, I hereby open the mandatory review period prior to a formal 
>> acceptance vote; voting will begin no earlier than December 1st, 2016. 
>>
>> Here are links to the most current version and its meta document: 
>>
>>
>> https://github.com/php-fig/fig-standards/blob/1cf169c66747640c6bc7fb5097d84fbafcd00a0c/proposed/simplecache.md
>>  
>>
>>
>> https://github.com/php-fig/fig-standards/blob/1cf169c66747640c6bc7fb5097d84fbafcd00a0c/proposed/simplecache-meta.md
>>  
>>
>>
>> The package containing the interfaces is there: 
>>
>> https://github.com/php-fig/simplecache 
>>
>>
>> The latest important changes to the interfaces can be found at: 
>>
>> https://github.com/php-fig/simplecache/releases/tag/0.2.0 
>>
>>
>> And FWIW, Scrapbook already provides a PSR-16 implementation in its 
>> upcoming release: 
>>
>> https://github.com/matthiasmullie/scrapbook/blob/master/src/Psr16/SimpleCache.php
>>  
>>
>>
>> Thanks for your time reviewing! 
>>
>> Cheers 
>>
>> -- 
>> Jordi Boggiano 
>> @seldaek - http://seld.be 
>>
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To post to this group, send email to php-fig@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/4d133796-3988-4176-94dc-8ce53f034c0d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.