Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Jordi Martínez]

Hi Chris

Please, be aware that, once accepted, the PSR documentation was relocated. 
Therefore the urls should be replaced by these ones:

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide.md

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide-meta.md



Jordi 


El viernes, 26 de julio de 2019, 18:10:54 (UTC+2), Chris Tankersley 
escribió:
>
> Finally, after a very long review period and much discussion and tweaking, 
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> -- 
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/fc327e8c-4ed6-4440-a7dd-b4e882f747d7%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Asmir Mustafic]

To clarify some misinformation that is around (reddit, twitter):

As per https://www.php-fig.org/bylaws/voting-protocol/#approval-vote , the 
approval vote is limited to Core Members of the PHP-FIG.
In the voting period, some other people have "voted" with some "+1", but 
their votes have not been counted as it should be clear from the 
votes-summary in my previous message.

PSR-12 is the result of the hard work of more than 12 people. Actually is 
the result of more than 100 pull requests 

 and 
some names (and PHP projects) that participated in the realization of 
PSR-12 can be found at 
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide-meta.md
.

Asmir Mustafic
PHP-FIG secretary

On Saturday, 10 August 2019 08:37:52 UTC+2, Asmir Mustafic wrote:
>
> Voting for PSR-12 (Extended Coding Style Guide) closed yesterday, 9 August 
> 2019, at 23:59 UTC. 
> *I am happy to announce that the PSR-12 specification was approved.*
>
> In the next days the PHP FIG website will be updated.
>
> The breakdown of votes is below. 
>
> Voted +1:
> Beau Simensen (@beausimensen)
> Matthew Weier O’Phinney (@mwop)
> Cees-Jan Kiewiet (@WyriHaximus)
> Samantha Quiñones (@ieatkillerbees)
> Chris Tankersley (@dragonmantank)
> Korvin Szanto (@korvinszanto)
> Michael Cullum (@michaelcullumuk)
> Chuck Burgess (@ashnazg)
> Woody Gilk (@shadowhand)
> Matteo Beccati (@mbeccati)
>
> Voted -1:
> Larry Garfield (@Crell)
> Stefano Torresi (@storresi)
>
> Voted +0:
> No +0 votes
>
> Eleggibile members to vote: 12
> Quorum: 6 (50%) 
> Total votes: 12
> *Quorum: reached*
>
> Min votes to pass: 8 (2/3 of voters)
> Total in favor: 10 
> Total against: 2 
> Abstaining: 0 
> *Voting result: pass*
>
>
> Thank to everyone
>
> Asmir Mustafic
> PHP-FIG secretary
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/ce93acb7-133f-4741-a09a-180dc1c729ec%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Asmir Mustafic]

Voting for PSR-12 (Extended Coding Style Guide) closed yesterday, 9 August 
2019, at 23:59 UTC. 
*I am happy to announce that the PSR-12 specification was approved.*

In the next days the PHP FIG website will be updated.

The breakdown of votes is below. 

Voted +1:
Beau Simensen (@beausimensen)
Matthew Weier O’Phinney (@mwop)
Cees-Jan Kiewiet (@WyriHaximus)
Samantha Quiñones (@ieatkillerbees)
Chris Tankersley (@dragonmantank)
Korvin Szanto (@korvinszanto)
Michael Cullum (@michaelcullumuk)
Chuck Burgess (@ashnazg)
Woody Gilk (@shadowhand)
Matteo Beccati (@mbeccati)

Voted -1:
Larry Garfield (@Crell)
Stefano Torresi (@storresi)

Voted +0:
No +0 votes

Eleggibile members to vote: 12
Quorum: 6 (50%) 
Total votes: 12
*Quorum: reached*

Min votes to pass: 8 (2/3 of voters)
Total in favor: 10 
Total against: 2 
Abstaining: 0 
*Voting result: pass*


Thank to everyone

Asmir Mustafic
PHP-FIG secretary

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/d7518730-afec-4cb5-8b3f-12b2389d31c7%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

I'm awesome and didn't cast my vote for some reason.

+1

-Chris

On Fri, Jul 26, 2019, 12:10 PM Chris Tankersley 
wrote:

> Finally, after a very long review period and much discussion and tweaking,
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> --
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAL9n4XOiFRG9L0z_JyK6mhgT0mFXjS0DWBoxXyUaxSbH%2BmoB2Q%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Larry Garfield]

-1

-- 
  Larry Garfield
  la...@garfieldtech.com

On Fri, Jul 26, 2019, at 11:10 AM, Chris Tankersley wrote:
> Finally, after a very long review period and much discussion and 
> tweaking, I think we are finally ready for the acceptance vote for 
> PSR-12.
> 
> The specification can be found here:
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
> 
> And the meta document here:
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
> 
> Thank you to everyone involved!
> 
> -- 
> Chris Tankersley
> http://ctankersley.com
> 
>  -- 
>  You received this message because you are subscribed to the Google 
> Groups "PHP Framework Interoperability Group" group.
>  To unsubscribe from this group and stop receiving emails from it, send 
> an email to php-fig+unsubscr...@googlegroups.com.
>  To view this discussion on the web visit 
> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/1137894b-ced7-47ba-9f58-42266a89fcc7%40www.fastmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Stefano Torresi]

Hey list,

I'm afraid my vote is -1, as anticipated on Slack.

I have expressed some criticism which have not been addressed:
- it is not clear what version of PHP the spec is targeting
- IMHO, 7.4 should have been targeted, because it is only a few months away
- the splat operator is not covered by section 6.1

Plus, I don't quite fancy the "we'll fix it with an Errata" line of thought.

PSRs are made to last years, we don't have an efficient process to let them
evolve organically and incrementally, so I'd rather have them made as
thoroughly as possible, and as much as I can be thankful to the WG for
their efforts, I don't feel the work is quite done here.

Ad maiora!

Cheers,
Stefano

Il Gio 8 Ago 2019, 22:58 Cees-Jan Kiewiet  ha scritto:

> +1
>
> On Thu, Aug 8, 2019 at 5:43 PM Matthew Weier O'Phinney <
> mweierophin...@gmail.com> wrote:
>
>> +1 from me.
>>
>> On Fri, Jul 26, 2019 at 11:10 AM Chris Tankersley 
>> wrote:
>>
>>> Finally, after a very long review period and much discussion and
>>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>>
>>> The specification can be found here:
>>>
>>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>>
>>> And the meta document here:
>>>
>>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>>
>>> Thank you to everyone involved!
>>>
>>> --
>>> Chris Tankersley
>>> http://ctankersley.com
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "PHP Framework Interoperability Group" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to php-fig+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Matthew Weier O'Phinney
>> mweierophin...@gmail.com
>> https://mwop.net/
>> he/him
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "PHP Framework Interoperability Group" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to php-fig+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/php-fig/CAJp_myUWPOR50yBiMsB8R2tP7%2BZ90VC7CSa0k%2BpO_8ofCuMQbA%40mail.gmail.com
>> 
>> .
>>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAPY1sU-hiwjzU%3DPEvd0QALd8jVcjaqGSEaCDwr9uFPA3%2BQwroA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAFojS1s9EQqvT1cb-%3D8CKVuDtHMnSW6X-qHWQXqAsDqZ0bucRw%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Cees-Jan Kiewiet]

+1

On Thu, Aug 8, 2019 at 5:43 PM Matthew Weier O'Phinney <
mweierophin...@gmail.com> wrote:

> +1 from me.
>
> On Fri, Jul 26, 2019 at 11:10 AM Chris Tankersley 
> wrote:
>
>> Finally, after a very long review period and much discussion and
>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>
>> The specification can be found here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>
>> And the meta document here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>
>> Thank you to everyone involved!
>>
>> --
>> Chris Tankersley
>> http://ctankersley.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "PHP Framework Interoperability Group" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to php-fig+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
>> 
>> .
>>
>
>
> --
> Matthew Weier O'Phinney
> mweierophin...@gmail.com
> https://mwop.net/
> he/him
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAJp_myUWPOR50yBiMsB8R2tP7%2BZ90VC7CSa0k%2BpO_8ofCuMQbA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAPY1sU-hiwjzU%3DPEvd0QALd8jVcjaqGSEaCDwr9uFPA3%2BQwroA%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Matthew Weier O'Phinney]

+1 from me.

On Fri, Jul 26, 2019 at 11:10 AM Chris Tankersley 
wrote:

> Finally, after a very long review period and much discussion and tweaking,
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> --
> Chris Tankersley
> http://ctankersley.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
> 
> .
>


-- 
Matthew Weier O'Phinney
mweierophin...@gmail.com
https://mwop.net/
he/him

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAJp_myUWPOR50yBiMsB8R2tP7%2BZ90VC7CSa0k%2BpO_8ofCuMQbA%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

['Matteo Beccati' via PHP Framework Interoperability Group]

+1

On 26/07/2019 18:10, Chris Tankersley wrote:
> Finally, after a very long review period and much discussion and
> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
> 
> The specification can be found here:
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
> 
> And the meta document here:
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
> 
> Thank you to everyone involved!
> 
> -- 
> Chris Tankersley
> http://ctankersley.com
> 
> -- 
> You received this message because you are subscribed to the Google
> Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to php-fig+unsubscr...@googlegroups.com
> .
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
> .


-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/738d6d1f-6728-3aec-7241-0bc2a461f063%40beccati.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chuck Burgess]

+1

On Mon, Aug 5, 2019, 10:53 Samantha Quiñones 
wrote:

> +1
>
> Very exciting stuff!
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/4bf9d77c-41a5-41c8-af6b-db7a1beb5855%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CANsgjntmGdEu5f8dfW5pMkLTw8Yfw6-kQU7roScuUrFRUpxV1A%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Samantha Quiñones]

+1

Very exciting stuff!

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/4bf9d77c-41a5-41c8-af6b-db7a1beb5855%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Beau Simensen]

+1

On Friday, July 26, 2019 at 11:10:54 AM UTC-5, Chris Tankersley wrote:
>
> Finally, after a very long review period and much discussion and tweaking, 
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> -- 
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/d477b4af-c13b-403f-9e6e-cded4ccbe8c0%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Kenta Usami]

Hello Chris.

I wanted to confirm that PSR-12 did not cover it.
Thank you and I'm sorry.

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/25cc3f23-0e71-4af8-9079-3220d7fcd58b%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

Hello Kenta!

This thread is just for voting. Please keep any questions to separate
threads.

We do not plan on addressing 7.4 usage with PSR-12. PHP 7.4 is not
released, so we do not have any real-world usage patterns for it yet. Some
things may be able to be covered with errata, some may require a different
standard in the future.

-Chris

On Fri, Aug 2, 2019, 3:10 AM Kenta Usami  wrote:

> Hi,
>
> The current version of PSR-12 seems to lack mention of Arrow Functions[1]
> added in PHP 7.4.
> Do you have plans to add a chapter about the arraw function to PSR-12 (or
> next Coding Style Guide PSR)?
>
> It is possible to analogize the spacing around `fn` from other language
> constructs.
> However, I think that there is a controversy in the case of indentation
> followed by a line break and a long expression immediately after `=>`,
>
> [1] https://wiki.php.net/rfc/arrow_functions_v2
>
> 2019年7月27日土曜日 1時10分54秒 UTC+9 Chris Tankersley:
>>
>> Finally, after a very long review period and much discussion and
>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>
>> The specification can be found here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>
>> And the meta document here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>
>> Thank you to everyone involved!
>>
>> --
>> Chris Tankersley
>> http://ctankersley.com
>>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/47ac7aca-7a10-4624-8c11-7c13ff34b67f%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAL9n4XPrRGvfhbsYTk_WkJgtk34i9mL8m3eq3PMxtLo%3Dx87z0w%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Kenta Usami]

Hi,

The current version of PSR-12 seems to lack mention of Arrow Functions[1] 
added in PHP 7.4.
Do you have plans to add a chapter about the arraw function to PSR-12 (or 
next Coding Style Guide PSR)?

It is possible to analogize the spacing around `fn` from other language 
constructs.
However, I think that there is a controversy in the case of indentation 
followed by a line break and a long expression immediately after `=>`,

[1] https://wiki.php.net/rfc/arrow_functions_v2

2019年7月27日土曜日 1時10分54秒 UTC+9 Chris Tankersley:
>
> Finally, after a very long review period and much discussion and tweaking, 
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> -- 
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/47ac7aca-7a10-4624-8c11-7c13ff34b67f%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

Hello Matthew!

As far as I'm aware, we never retracted the review period, but it was
incredibly long. A big portion of that was getting two implementations
ready for the final acceptance vote. We had talked back in March internally
about going to the Acceptance vote, but needed the implementations.
Unfortunately, since this was not just a set of interfaces, we had to get
working style guide rules ready to go, and we wanted to make sure they were
ready for big-named style checkers.

During the review process we merged in a handful of grammar/typo PRs, but
functionality-wise only changed the following:

- Body must start on line after an opening brace [1]

This was added to provide consistency with the rule about no black lines
between the end of a body and a closing brace, and it was decided that this
would not be a major amount of work to implement for the reference
implementations.

As for feedback, I believe that was taken care of in the two threads[2][3].
The only major things that have come up (actually right after we called for
the Acceptance vote) are the accessibility debate on tabs vs spaces and 7.4
support. We've decided that since PSR-12 is based on PSR-2, tabs vs spaces
is outside of this PSR and will not be making that change as part of
PSR-12. I've also decided that since 7.4 is not released, we will not be
considering the syntax changes for it.

-Chris

[1] https://github.com/php-fig/fig-standards/pull/1164
[2]
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/jHf53u6PzHM/Ko9d8OR7BQAJ
[3]
https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/p94Hef2_ymA/ZkAfXwGhDAAJ

On Tue, Jul 30, 2019 at 6:39 PM Matthew Weier O'Phinney <
mweierophin...@gmail.com> wrote:

> Hi Chris!
>
> I don't recall seeing a review period. There was one some time ago
> (February), but my understanding was that it was retracted once some
> feedback came in (most recent was May). IIRC, we're supposed to reopen the
> review period if we don't go directly to the acceptance vote.
>
> Regardless, can you summarize what changes were made since then, and what,
> if any, feedback was addressed?
>
> Thanks!
>
> On Fri, Jul 26, 2019, 10:10 AM Chris Tankersley 
> wrote:
>
>> Finally, after a very long review period and much discussion and
>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>
>> The specification can be found here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>
>> And the meta document here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>
>> Thank you to everyone involved!
>>
>> --
>> Chris Tankersley
>> http://ctankersley.com
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "PHP Framework Interoperability Group" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to php-fig+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAJp_myWGb%3DCfYwhW7YRB5ADUx%3DJ%3Dov%3Dy4tp-dq0eTKPrOaTJFQ%40mail.gmail.com
> 
> .
>


-- 
Chris Tankersley
http://ctankersley.com

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAL9n4XOdZydJT6UyNROYfYnCEhfzsKLmuToP%2BykzDnTB1SSTdQ%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Matthew Weier O'Phinney]

Hi Chris!

I don't recall seeing a review period. There was one some time ago
(February), but my understanding was that it was retracted once some
feedback came in (most recent was May). IIRC, we're supposed to reopen the
review period if we don't go directly to the acceptance vote.

Regardless, can you summarize what changes were made since then, and what,
if any, feedback was addressed?

Thanks!

On Fri, Jul 26, 2019, 10:10 AM Chris Tankersley 
wrote:

> Finally, after a very long review period and much discussion and tweaking,
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> --
> Chris Tankersley
> http://ctankersley.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAJp_myWGb%3DCfYwhW7YRB5ADUx%3DJ%3Dov%3Dy4tp-dq0eTKPrOaTJFQ%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Dracony]

+1 from PHPixie

I a so happy an extended checkstyle is happening!

On Friday, July 26, 2019 at 9:10:54 AM UTC-7, Chris Tankersley wrote:
>
> Finally, after a very long review period and much discussion and tweaking, 
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> -- 
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/c9d0e41b-bb06-41c6-ad53-8a41d45c8ef9%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

As a general reminder, Approval votes are Core Committee members only[1]. I
left it out of the subject line since this isn't a split vote like some
things.

-Chris

[1] https://www.php-fig.org/bylaws/voting-protocol/#approval-vote

On Fri, Jul 26, 2019 at 4:19 PM Chris Tankersley 
wrote:

> Because I accidently left it out of the first e-mail, the two trial
> implementations are:
>
> PHP CodeSniffer:
> https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src/Standards/PSR12
> EasyCodingStandard: https://github.com/Symplify/EasyCodingStandard (
> https://www.tomasvotruba.cz/blog/2018/04/09/try-psr-12-on-your-code-today/
> )
>
>
>
> On Fri, Jul 26, 2019 at 12:10 PM Chris Tankersley 
> wrote:
>
>> Finally, after a very long review period and much discussion and
>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>
>> The specification can be found here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>
>> And the meta document here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>
>> Thank you to everyone involved!
>>
>> --
>> Chris Tankersley
>> http://ctankersley.com
>>
>
>
> --
> Chris Tankersley
> http://ctankersley.com
>


-- 
Chris Tankersley
http://ctankersley.com

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAL9n4XOnhfkEyin%3DOoRaRrwFjCOEk0A4ApJ%3DDvUcVNfgb4ApFA%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Josh Bruce]

First time.

+1

Do I get a vote??

Cheers,
Josh

> On Jul 28, 2019, at 7:21 AM, Michael Cullum  wrote:
> 
> +1
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/php-fig/52b2d22b-bee4-41f6-b61e-f7174f7f8b7d%40googlegroups.com.

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/3D113D20-54DF-4245-AE1E-3D569D404B0C%408fold.pro.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Michael Cullum]

+1

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/52b2d22b-bee4-41f6-b61e-f7174f7f8b7d%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Nikolaos Dimopoulos]

+1

Great work! Thank you for the time and effort

On Friday, July 26, 2019 at 12:10:54 PM UTC-4, Chris Tankersley wrote:
>
> Finally, after a very long review period and much discussion and tweaking, 
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> -- 
> Chris Tankersley
> http://ctankersley.com
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/f260e90b-ca75-4c05-9355-9de0437568e2%40googlegroups.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Woody Gilk]

+1

There are some examples that could be more logical, but those can be
improved with an errata.

On Fri, Jul 26, 2019, 15:20 Chris Tankersley  wrote:

> Because I accidently left it out of the first e-mail, the two trial
> implementations are:
>
> PHP CodeSniffer:
> https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src/Standards/PSR12
> EasyCodingStandard: https://github.com/Symplify/EasyCodingStandard (
> https://www.tomasvotruba.cz/blog/2018/04/09/try-psr-12-on-your-code-today/
> )
>
>
>
> On Fri, Jul 26, 2019 at 12:10 PM Chris Tankersley 
> wrote:
>
>> Finally, after a very long review period and much discussion and
>> tweaking, I think we are finally ready for the acceptance vote for PSR-12.
>>
>> The specification can be found here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>>
>> And the meta document here:
>>
>> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>>
>> Thank you to everyone involved!
>>
>> --
>> Chris Tankersley
>> http://ctankersley.com
>>
>
>
> --
> Chris Tankersley
> http://ctankersley.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to php-fig+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/php-fig/CAL9n4XNvPxjnYoOVCAaSzjfvU9p%3DrpnWPnLzAFGfUcfMwRJQGw%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAGOJM6JG7Sij_22U9i_yrL91F97fEcdszF5xh%2Bk18EZ9P8eoWA%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

Because I accidently left it out of the first e-mail, the two trial
implementations are:

PHP CodeSniffer:
https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src/Standards/PSR12
EasyCodingStandard: https://github.com/Symplify/EasyCodingStandard (
https://www.tomasvotruba.cz/blog/2018/04/09/try-psr-12-on-your-code-today/)



On Fri, Jul 26, 2019 at 12:10 PM Chris Tankersley 
wrote:

> Finally, after a very long review period and much discussion and tweaking,
> I think we are finally ready for the acceptance vote for PSR-12.
>
> The specification can be found here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md
>
> And the meta document here:
>
> https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md
>
> Thank you to everyone involved!
>
> --
> Chris Tankersley
> http://ctankersley.com
>


-- 
Chris Tankersley
http://ctankersley.com

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CAL9n4XNvPxjnYoOVCAaSzjfvU9p%3DrpnWPnLzAFGfUcfMwRJQGw%40mail.gmail.com.

Re: [VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Korvin Szanto]

Thanks for being our sponsor Chris!

+1

-- 
You received this message because you are subscribed to the Google Groups "PHP 
Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to php-fig+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/php-fig/CANeXGWV4JUEY_f%3Dw5FxGsPqDBB%2BbsokW1KbhAbN9Bg1D5220kA%40mail.gmail.com.