Re: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h

2001-04-06 Thread eschmid+sic

On Fri, Apr 06, 2001 at 11:17:32PM -, Jani Taskinen wrote:
 sniperFri Apr  6 16:17:32 2001 EDT
 
   Modified files:  
 /php4/ext/fdf fdf.c php_fdf.h 
   Log:
   Fixed some bugs.

Why are you changing in the describtions of protos "Sets" to "Set", "Adds"
to "Add" and so on? I think the former was the right english description.
Please look into CODING_STANDARDS at php.net and phpdoc/funcsummary.txt. 

Most descriptions starts with "Sets" or "Adds" which is IMHO the right way
to go and the example in CODING_STANDARDS could be changed.

Notice also, some people are adding a punctuation mark, which looks bad. I
hope Rasmus will give some advice, how we should do this in the future.

I have just reread that small chapter "Documentation and Folding Hooks" in
CODING_STANDARDS. Compare the two examples and you know what I am speaking 
off (add a "s" to Return in the first example and remove the punctuation
mark in the second example).

-Egon

-- 
LinuxTag, Stuttgart, Germany: July 5-8 2001: http://www.linuxtag.de/
All known books about PHP and related books: http://php.net/books.php 
Concert Band of the University of Hohenheim: http://www.concert-band.de/
First and second bestselling book in German: http://www.php-buch.de/

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




RE: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h

2001-04-06 Thread Sean R. Bright

Speaking of which.  How do I enable this mysterious folding mode in emacs?
I can't seem to find any documentation on it.

 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
 Sent: Friday, April 06, 2001 8:19 PM
 To: Jani Taskinen; [EMAIL PROTECTED]
 Subject: Re: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h


 On Fri, Apr 06, 2001 at 11:17:32PM -, Jani Taskinen wrote:
  sniper  Fri Apr  6 16:17:32 2001 EDT
 
Modified files:
  /php4/ext/fdf   fdf.c php_fdf.h
Log:
Fixed some bugs.

 Why are you changing in the describtions of protos "Sets" to
 "Set", "Adds"
 to "Add" and so on? I think the former was the right english
 description.
 Please look into CODING_STANDARDS at php.net and
 phpdoc/funcsummary.txt.

 Most descriptions starts with "Sets" or "Adds" which is IMHO
 the right way
 to go and the example in CODING_STANDARDS could be changed.

 Notice also, some people are adding a punctuation mark, which
 looks bad. I
 hope Rasmus will give some advice, how we should do this in
 the future.

 I have just reread that small chapter "Documentation and
 Folding Hooks" in
 CODING_STANDARDS. Compare the two examples and you know what
 I am speaking
 off (add a "s" to Return in the first example and remove the
 punctuation
 mark in the second example).

 -Egon

 --
 LinuxTag, Stuttgart, Germany: July 5-8 2001: http://www.linuxtag.de/
 All known books about PHP and related books: http://php.net/books.php
 Concert Band of the University of Hohenheim:
 http://www.concert-band.de/
 First and second bestselling book in German: http://www.php-buch.de/

 --
 PHP CVS Mailing List (http://www.php.net/)
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 To contact the list administrators, e-mail:
 [EMAIL PROTECTED]



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h

2001-04-06 Thread eschmid+sic

On Fri, Apr 06, 2001 at 08:55:40PM -0400, Sean R. Bright wrote:
 Speaking of which.  How do I enable this mysterious folding mode in emacs?
 I can't seem to find any documentation on it.

PHP 4/CODING_STANDARDS. You can also check http://cvs.php.net/ -- php4
-- CODING_STANDARDS.

-Egon

-- 
LinuxTag, Stuttgart, Germany: July 5-8 2001: http://www.linuxtag.de/
All known books about PHP and related books: http://php.net/books.php 
Concert Band of the University of Hohenheim: http://www.concert-band.de/
First and second bestselling book in German: http://www.php-buch.de/

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h

2001-04-06 Thread Jani Taskinen

On Sat, 7 Apr 2001 [EMAIL PROTECTED] wrote:

Why are you changing in the describtions of protos "Sets" to "Set", "Adds"
to "Add" and so on? I think the former was the right english description.
Please look into CODING_STANDARDS at php.net and phpdoc/funcsummary.txt.

hmm..well, I checked the documentation and there they seem to be
differently written. And it seems our 'example' code, mysql extension,
doesn't follow these standards either.

Notice also, some people are adding a punctuation mark, which looks bad. I
hope Rasmus will give some advice, how we should do this in the future.

Ok.

I have just reread that small chapter "Documentation and Folding Hooks" in
CODING_STANDARDS. Compare the two examples and you know what I am speaking
off (add a "s" to Return in the first example and remove the punctuation
mark in the second example).

Eh..that 'standard' seems to suggest two different ways of doing it.. :)

--Jani



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




RE: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h

2001-04-06 Thread Sean R. Bright

I know where the CODING_STANDARDS file is, but it only mentions Emacs'
folding mechanism, it does not talk about how to use it.  I was hoping that
someone could give me some insight into how to enable this function under
Emacs, as I cannot find any other documentation on it.

 -Original Message-
 From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
 Sent: Friday, April 06, 2001 9:22 PM
 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
 Subject: Re: [PHP-CVS] cvs: php4 /ext/fdf fdf.c php_fdf.h


 On Fri, Apr 06, 2001 at 08:55:40PM -0400, Sean R. Bright wrote:
  Speaking of which.  How do I enable this mysterious folding
 mode in emacs?
  I can't seem to find any documentation on it.

 PHP 4/CODING_STANDARDS. You can also check
 http://cvs.php.net/ -- php4
 -- CODING_STANDARDS.

 -Egon

 --
 LinuxTag, Stuttgart, Germany: July 5-8 2001: http://www.linuxtag.de/
 All known books about PHP and related books: http://php.net/books.php
 Concert Band of the University of Hohenheim:
 http://www.concert-band.de/
 First and second bestselling book in German: http://www.php-buch.de/



-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]