[PHP-WEBMASTER] [web-php] PR #1162: Improve Found A Problem?

2024-11-23 Thread kamil-tekiela
Pull Request: https://github.com/php/web-php/pull/1162
Author: kamil-tekiela

I propose a slight modification to the "Improve this page" box. The changes I 
am proposing should look something like this:

![image](https://github.com/user-attachments/assets/502c673b-9a43-4d11-ab91-2c7a3f65979f)

The title text is changed from being a command to a polite enquiry. It also 
reduces duplication with the link below it. 


[PHP-WEBMASTER] [web-php] PR #1162: Improve Found A Problem?

2024-11-23 Thread saundefined
Pull Request: https://github.com/php/web-php/pull/1162

Closed by saundefined.


[PHP-WEBMASTER] [web-php] master: Improve Found A Problem? (#1162)

2024-11-23 Thread Kamil Tekiela via GitHub
Author: Kamil Tekiela (kamil-tekiela)
Committer: GitHub (web-flow)
Pusher: saundefined
Date: 2024-11-24T09:05:43+03:00

Commit: 
https://github.com/php/web-php/commit/e02d74cff08b3c6158b65d9827458a5a451e637a
Raw diff: 
https://github.com/php/web-php/commit/e02d74cff08b3c6158b65d9827458a5a451e637a.diff

Improve Found A Problem? (#1162)

Changed paths:
  M  include/ui_translation/en.ini
  M  styles/theme-base.css


Diff:

diff --git a/include/ui_translation/en.ini b/include/ui_translation/en.ini
index 32ae383609..1a6aa3ecd3 100644
--- a/include/ui_translation/en.ini
+++ b/include/ui_translation/en.ini
@@ -1,5 +1,5 @@
 change_language = "Change language"
-improve_this_page = "Improve This Page"
+improve_this_page = "Found A Problem?"
 how_to_improve_this_page = "Learn How To Improve This Page"
 contribution_guidlines_on_github = "This will take you to our contribution 
guidelines on GitHub"
 submit_a_pull_request = "Submit a Pull Request"
diff --git a/styles/theme-base.css b/styles/theme-base.css
index ea754a7cdc..beec0bc1f9 100644
--- a/styles/theme-base.css
+++ b/styles/theme-base.css
@@ -362,14 +362,17 @@ hr {
 
 .contribute {
   border: 1px solid #888;
-  border-radius: 3px;
-  margin: 0px -10px 0px -10px;
-  padding: 0 10px 5px 10px;
+  border-width: 1px 0;
+  margin: 0px -24px 0px -24px;
+  padding: 0 24px 5px 24px;
   background-color: #E2E2E2;
 }
 .contribute .edit-bug a {
 border: 0;
 }
+.contribute h3.title {
+  margin-bottom: 10px;
+}
 
 /**
  * User notes


[PHP-WEBMASTER] [web-php] PR #1161: 8.4: Changed announced version to 8.4 from 8.4.0

2024-11-23 Thread jorgsowa
Pull Request: https://github.com/php/web-php/pull/1161
Author: jorgsowa

The version officially announced was 8.4.1, so it's better to skip the patch 
version in the page header.


[PHP-WEBMASTER] [web-php] PR #1161: 8.4: Changed announced version to 8.4 from 8.4.0

2024-11-23 Thread saundefined
Pull Request: https://github.com/php/web-php/pull/1161

Closed by saundefined.


[PHP-WEBMASTER] [web-php] master: Changed announced version to 8.4 from 8.4.0 (#1161)

2024-11-23 Thread Jorg Adam Sowa via GitHub
Author: Jorg Adam Sowa (jorgsowa)
Committer: GitHub (web-flow)
Pusher: saundefined
Date: 2024-11-23T15:11:33+03:00

Commit: 
https://github.com/php/web-php/commit/1eadd1bf7b974bde804e296cd4a740ef4e55fce2
Raw diff: 
https://github.com/php/web-php/commit/1eadd1bf7b974bde804e296cd4a740ef4e55fce2.diff

Changed announced version to 8.4 from 8.4.0 (#1161)

The version officially announced was 8.4.1, so it's better to skip the patch 
version.

Changed paths:
  M  releases/8.4/common.php


Diff:

diff --git a/releases/8.4/common.php b/releases/8.4/common.php
index ab6e7c3973..5c89a3211e 100644
--- a/releases/8.4/common.php
+++ b/releases/8.4/common.php
@@ -26,7 +26,7 @@ function common_header(string $description): void {
 \filter_var($MYSITE . 'images/php8/php_8_4_released.png', 
\FILTER_VALIDATE_URL));
 $meta_description = \htmlspecialchars($description);
 
-\site_header("PHP 8.4.0 Release Announcement", [
+\site_header("PHP 8.4 Release Announcement", [
 'current' => 'php8',
 'css' => ['php8.css'],
 'meta_tags' => <<