[PHP-DOC] #40088 [Opn-Bgs]: 'binary-safe' explanation needed in documentation

2007-01-11 Thread betz
 ID:   40088
 Updated by:   [EMAIL PROTECTED]
 Reported By:  stepheneliotdewey at gmail dot com
-Status:   Open
+Status:   Bogus
 Bug Type: Documentation problem
 Operating System: irrelevant
 PHP Version:  Irrelevant
 New Comment:

Hi,

the PHP-Manual is not the place to explain fundamental concepts. You
can, for example, search the web to get the answer what binary-safe
means.
There is nothing php-specific about binary-safe.

That said, don't expect the PHP-Manual to be the place to get
explanations what common terms mean ;-)

Friedhelm 


Previous Comments:


[2007-01-10 13:08:56] stepheneliotdewey at gmail dot com

Description:

It would be good to include a description of what binary-safe means
in PHP in the documentation along with some examples of differences
between how functions would perform if they were and if they were not
binary-safe.

This would be helpful to users like myself who are not experienced with
those concepts.






-- 
Edit this bug report at http://bugs.php.net/?id=40088edit=1


[PHP-DOC] cvs: phpdoc /en/reference/outcontrol/functions ob-end-clean.xml

2007-01-11 Thread Etienne Kneuss
colder  Thu Jan 11 12:49:41 2007 UTC

  Modified files:  
/phpdoc/en/reference/outcontrol/functions   ob-end-clean.xml 
  Log:
  improve example
  
http://cvs.php.net/viewvc.cgi/phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml?r1=1.9r2=1.10diff_format=u
Index: phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml
diff -u phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.9 
phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.10
--- phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.9   Sat Oct 
29 06:45:22 2005
+++ phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml   Thu Jan 11 
12:49:41 2007
@@ -1,5 +1,5 @@
 ?xml version=1.0 encoding=iso-8859-1?
-!-- $Revision: 1.9 $ --
+!-- $Revision: 1.10 $ --
 !-- splitted from ./en/functions/outcontrol.xml, last change in rev 1.1 --
   refentry id=function.ob-end-clean
refnamediv
@@ -35,7 +35,9 @@
   programlisting role=php
 ![CDATA[
 ?php
-while (@ob_end_clean());
+while (ob_get_level() !== 0) {
+ob_end_clean();
+}
 ?
 ]]
   /programlisting


[PHP-DOC] Re: cvs: phpdoc /en/reference/outcontrol/functions ob-end-clean.xml

2007-01-11 Thread Michael Wallner
Etienne Kneuss wrote:
 colderThu Jan 11 12:49:41 2007 UTC
 
   Modified files:  
 /phpdoc/en/reference/outcontrol/functions ob-end-clean.xml 
   Log:
   improve example

 @@ -35,7 +35,9 @@
programlisting role=php
  ![CDATA[
  ?php
 -while (@ob_end_clean());
 +while (ob_get_level() !== 0) {
 +ob_end_clean();
 +}

Hi, this will generate an infinite loop if there's a non-erasable output 
handler on the stack.

Regards,
-- 
Michael


Re: [PHP-DOC] Re: cvs: phpdoc /en/reference/outcontrol/functions ob-end-clean.xml

2007-01-11 Thread Etienne Kneuss

I see, thanks for the note.

In that case, the whole example doesn't make much sense, I'll rewrite it.

-E

Michael Wallner wrote:

Etienne Kneuss wrote:
  

colder  Thu Jan 11 12:49:41 2007 UTC

  Modified files:  
/phpdoc/en/reference/outcontrol/functions	ob-end-clean.xml 
  Log:

  improve example



  

@@ -35,7 +35,9 @@
   programlisting role=php
 ![CDATA[
 ?php
-while (@ob_end_clean());
+while (ob_get_level() !== 0) {
+ob_end_clean();
+}



Hi, this will generate an infinite loop if there's a non-erasable output 
handler on the stack.

Regards,
  



--
Etienne Kneuss
http://www.colder.ch
[EMAIL PROTECTED]

Men never do evil so completely and cheerfully as 
when they do it from a religious conviction.

-- Pascal


[PHP-DOC] cvs: phpdoc /en/reference/outcontrol/functions ob-end-clean.xml

2007-01-11 Thread Etienne Kneuss
colder  Thu Jan 11 16:36:46 2007 UTC

  Modified files:  
/phpdoc/en/reference/outcontrol/functions   ob-end-clean.xml 
  Log:
  fix example
  
http://cvs.php.net/viewvc.cgi/phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml?r1=1.10r2=1.11diff_format=u
Index: phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml
diff -u phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.10 
phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.11
--- phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml:1.10  Thu Jan 
11 12:49:41 2007
+++ phpdoc/en/reference/outcontrol/functions/ob-end-clean.xml   Thu Jan 11 
16:36:46 2007
@@ -1,5 +1,5 @@
 ?xml version=1.0 encoding=iso-8859-1?
-!-- $Revision: 1.10 $ --
+!-- $Revision: 1.11 $ --
 !-- splitted from ./en/functions/outcontrol.xml, last change in rev 1.1 --
   refentry id=function.ob-end-clean
refnamediv
@@ -35,9 +35,9 @@
   programlisting role=php
 ![CDATA[
 ?php
-while (ob_get_level() !== 0) {
-ob_end_clean();
-}
+ob_start();
+echo 'Text that won\'t get displayed.';
+ob_end_clean();
 ?
 ]]
   /programlisting


[PHP-DOC] cvs: phpdoc /en/language/oop5 overloading.xml

2007-01-11 Thread Hannes Magnusson
bjori   Thu Jan 11 23:05:52 2007 UTC

  Modified files:  
/phpdoc/en/language/oop5overloading.xml 
  Log:
  Fixed bug#40103 (Visibility should be public for overload methods in the 
documentation)
  
  
http://cvs.php.net/viewvc.cgi/phpdoc/en/language/oop5/overloading.xml?r1=1.13r2=1.14diff_format=u
Index: phpdoc/en/language/oop5/overloading.xml
diff -u phpdoc/en/language/oop5/overloading.xml:1.13 
phpdoc/en/language/oop5/overloading.xml:1.14
--- phpdoc/en/language/oop5/overloading.xml:1.13Wed Feb 22 13:26:05 2006
+++ phpdoc/en/language/oop5/overloading.xml Thu Jan 11 23:05:52 2007
@@ -1,5 +1,5 @@
 ?xml version=1.0 encoding=iso-8859-1?
-!-- $Revision: 1.13 $ --
+!-- $Revision: 1.14 $ --
  sect1 id=language.oop5.overloading
   titleOverloading/title
 
@@ -10,7 +10,7 @@
member or method you're trying to access.
All overloading methods must not be defined as
link linkend=language.oop5.staticstatic/link.
-   In PHP 5.0.x, all overloading methods must be defined as
+   All overloading methods must be defined as
link linkend=language.oop5.visibilitypublic/link.
   /para
   para
@@ -58,7 +58,7 @@
 public $n;
 private $x = array(a = 1, b = 2, c = 3);
 
-private function __get($nm)
+public function __get($nm)
 {
 echo Getting [$nm]\n;
 
@@ -71,7 +71,7 @@
 }
 }
 
-private function __set($nm, $val)
+public function __set($nm, $val)
 {
 echo Setting [$nm] to $val\n;
 
@@ -83,14 +83,14 @@
 }
 }
 
-private function __isset($nm)
+public function __isset($nm)
 {
 echo Checking if $nm is set\n;
 
 return isset($this-x[$nm]);
 }
 
-private function __unset($nm)
+public function __unset($nm)
 {
 echo Unsetting $nm\n;
 
@@ -182,7 +182,7 @@
 {
 private $x = array(1, 2, 3);
 
-private function __call($m, $a)
+public function __call($m, $a)
 {
 print Method $m called:\n;
 var_dump($a);


[PHP-DOC] #40103 [NEW]: Visibility should be public for overload methods in the documentation

2007-01-11 Thread mattsch at gmail dot com
From: mattsch at gmail dot com
Operating system: *
PHP version:  Irrelevant
PHP Bug Type: Documentation problem
Bug description:  Visibility should be public for overload methods in the 
documentation

Description:

http://www.php.net/manual/en/language.oop5.overloading.php

The example sets the visibility of the overload methods to private when
they should be public.  AFAIK it shouldn't override the visibility of the
method it is overloading.

Reproduce code:
---
private

Expected result:

public

Actual result:
--
private

-- 
Edit bug report at http://bugs.php.net/?id=40103edit=1
-- 
Try a CVS snapshot (PHP 4.4): 
http://bugs.php.net/fix.php?id=40103r=trysnapshot44
Try a CVS snapshot (PHP 5.2): 
http://bugs.php.net/fix.php?id=40103r=trysnapshot52
Try a CVS snapshot (PHP 6.0): 
http://bugs.php.net/fix.php?id=40103r=trysnapshot60
Fixed in CVS: http://bugs.php.net/fix.php?id=40103r=fixedcvs
Fixed in release: 
http://bugs.php.net/fix.php?id=40103r=alreadyfixed
Need backtrace:   http://bugs.php.net/fix.php?id=40103r=needtrace
Need Reproduce Script:http://bugs.php.net/fix.php?id=40103r=needscript
Try newer version:http://bugs.php.net/fix.php?id=40103r=oldversion
Not developer issue:  http://bugs.php.net/fix.php?id=40103r=support
Expected behavior:http://bugs.php.net/fix.php?id=40103r=notwrong
Not enough info:  
http://bugs.php.net/fix.php?id=40103r=notenoughinfo
Submitted twice:  
http://bugs.php.net/fix.php?id=40103r=submittedtwice
register_globals: http://bugs.php.net/fix.php?id=40103r=globals
PHP 3 support discontinued:   http://bugs.php.net/fix.php?id=40103r=php3
Daylight Savings: http://bugs.php.net/fix.php?id=40103r=dst
IIS Stability:http://bugs.php.net/fix.php?id=40103r=isapi
Install GNU Sed:  http://bugs.php.net/fix.php?id=40103r=gnused
Floating point limitations:   http://bugs.php.net/fix.php?id=40103r=float
No Zend Extensions:   http://bugs.php.net/fix.php?id=40103r=nozend
MySQL Configuration Error:http://bugs.php.net/fix.php?id=40103r=mysqlcfg