Re: [PHP-DOC] Re: Images
On Sun, 21 Jan 2007, Nuno Lopes wrote: > > This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote: > > > > > Yes, Hannes commited his patch. > > > See the imagesetpixel.xml file. > > > > excellent, what is the max dimensions/filesize of images? > > We haven't defined any hard max dimensions/filesize. But try to keep them > small (less than 15 KBs +/-) and viewable on a 640x480 display. Erm, 640x480? I think we can atleast go for 800x600... regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org
Re: [PHP-DOC] Re: Images
This one time, at band camp, "Nuno Lopes" <[EMAIL PROTECTED]> wrote: > * descripton text isn't wrapped Done > * detirmined vs determined Done > * same comment for returnvalues section I thought this was discussed previously and decided as an exception is not a return value it did not belong here? > * there's no need to comment every single line of the examples. it just > clutters them and adds no real value (everyone knows how to read PHP code in > the first place, right?). Wrong. I sit daily with people who have used the manual examples but still do not understand them. Even in the real world, my code is heavily commented. Updated doc is here Kevin -- "Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is a well-armed lamb contesting the vote."
Re: [PHP-DOC] Re: Images
In the example you use realpath. Why so? the extension should be smart enough to figure it out. Was from a devel example You also include an image as the output of the example, but why? the example does nothing but loading an external image and printing a string (as it seems), so printing a random image is really pointless. yes, a better example would be blurimage... http://phpro.org/sandbox/blurimage.xml How is this? * descripton text isn't wrapped * detirmined vs determined * same comment for returnvalues section * there's no need to comment every single line of the examples. it just clutters them and adds no real value (everyone knows how to read PHP code in the first place, right?). Nuno
Re: [PHP-DOC] Re: Images
Hi Kevin On 1/21/07, Kevin Waterson <[EMAIL PROTECTED]> wrote: This one time, at band camp, "Nuno Lopes" <[EMAIL PROTECTED]> wrote: > In the example you use realpath. Why so? the extension should be smart > enough to figure it out. Was from a devel example > You also include an image as the output of the example, but why? the example > does nothing but loading an external image and printing a string (as it > seems), so printing a random image is really pointless. yes, a better example would be blurimage... http://phpro.org/sandbox/blurimage.xml How is this? This should probably be figures/magickwand.blurimage.png if the image is in magickwand/figures/blurimage.png -Hannes Kevin -- "Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is a well-armed lamb contesting the vote."
Re: [PHP-DOC] Re: Images
This one time, at band camp, "Nuno Lopes" <[EMAIL PROTECTED]> wrote: > In the example you use realpath. Why so? the extension should be smart > enough to figure it out. Was from a devel example > You also include an image as the output of the example, but why? the example > does nothing but loading an external image and printing a string (as it > seems), so printing a random image is really pointless. yes, a better example would be blurimage... http://phpro.org/sandbox/blurimage.xml How is this? Kevin -- "Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is a well-armed lamb contesting the vote."
Re: [PHP-DOC] Re: Images
This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote: Yes, Hannes commited his patch. See the imagesetpixel.xml file. seems to be missing some OO goodness for extensions with a OOP interface. This si what I have now.. http://phpro.org/sandbox/readimage.xml Kevin some comments: in the returnvalues section you say: "Returns &true; on success". You are missing the full-stop and you aren't saying what it returns on failure (maybe just an exception?). You may want to use the &return.success; entity here. In the example you use realpath. Why so? the extension should be smart enough to figure it out. You also include an image as the output of the example, but why? the example does nothing but loading an external image and printing a string (as it seems), so printing a random image is really pointless. Nuno
Re: [PHP-DOC] Re: Images
This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote: Yes, Hannes commited his patch. See the imagesetpixel.xml file. excellent, what is the max dimensions/filesize of images? We haven't defined any hard max dimensions/filesize. But try to keep them small (less than 15 KBs +/-) and viewable on a 640x480 display. Nuno
Re: [PHP-DOC] Re: Images
This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote: > Yes, Hannes commited his patch. > See the imagesetpixel.xml file. seems to be missing some OO goodness for extensions with a OOP interface. This si what I have now.. http://phpro.org/sandbox/readimage.xml Kevin -- "Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is a well-armed lamb contesting the vote."
Re: [PHP-DOC] Re: Images
This one time, at band camp, Mehdi Achour <[EMAIL PROTECTED]> wrote: > Yes, Hannes commited his patch. > See the imagesetpixel.xml file. excellent, what is the max dimensions/filesize of images? Kevin -- "Democracy is two wolves and a lamb voting on what to have for lunch. Liberty is a well-armed lamb contesting the vote."
