[piccolo2d-dev] Issue 86 in piccolo2d: inconsistencies of position method in PNode

2009-07-10 Thread codesite-noreply

Status: New
Owner: 

New issue 86 by allain.lalonde: inconsistencies of position method in PNode
http://code.google.com/p/piccolo2d/issues/detail?id=86

The position method of PNode is the only animation function that doesn't
begin with the word animate.  Also, it doesn't return a PAcvitity instance,
making it rather difficult to test.

I've attached a patch that renames is animateToRelativePosition and makes it
return a PActivity.  With said activity I was able to write a little test
that bumped PNode's coverage up to 51.5% from 46.7%.


Attachments:
PNode.position.diff  4.2 KB

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---



[piccolo2d-dev] Re: Issue 12 in piccolo2d: Generics Support

2009-07-10 Thread Samuel Robert Reid





One effective way to obtain a vote would be to: 
1. branch now (leaving generics in HEAD and 1.4 as an old branch)
2. publish a new version of piccolo with generics and 1.5 dependencies
3. see how many people complain

If there is an overwhelming response that we need to keep up
significant support for 1.4, we can always focus our efforts on the
branch, or just revert HEAD to the 1.4 branch.

Sam Reid

allain wrote:

  If this is the direction the project wants to go in, I'd more than
gladly make the changes to the rest of the code base. Just want to
know that it won't be wasted effort.

When will we have a result for this "vote"?

On Jul 8, 4:04 pm, codesite-nore...@google.com wrote:
  
  
Comment #11 on issue 12 by willismorse: Generics Supporthttp://code.google.com/p/piccolo2d/issues/detail?id=12

I vote for adding generics. We're almost ready to drop support for 1.5 in  
our products; 1.4 has been off our
radar for a couple years now.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:http://code.google.com/hosting/settings

  
  
  


--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---





[piccolo2d-dev] Helper Function

2009-07-10 Thread allain

I find myself writing code like this far too often:

  node.getScale() * node.getHeight(), node.getScale()*node.getWidth()

But it'd be handy to have helper functions of the form:

  node.getScaledHeight() and node.getScaledWidth()

Anyone else feel the same?
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---



[piccolo2d-dev] Issue 16 in piccolo2d: Support non-rectangular zooming of PCameras on nodes

2009-07-10 Thread codesite-noreply


Comment #5 on issue 16 by lionel.victor: Support non-rectangular zooming of  
PCameras on nodes
http://code.google.com/p/piccolo2d/issues/detail?id=16

As I understand the above code, this would set a different scale on the X  
and Y axis.

Then (unless I misunderstood the code) I completely agree that this should  
be done in
an extra method, leaving the existing method in place because it  
dramatically changes
its behaviour (and would surely break some existing client code).

In addition, I may suggest to add other setScaleX() and setScaleY() methods  
in most
components that can be scaled...
At the moment, only setScale(double) is available... sometimes  
setScale(double,
double) can be used... But having convenience method that only set the  
scale on one
particular axis could be fine...

I have written the code already for some nodes, I can provide support/diff  
to help
supporting "non isomorphic" scaling.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---



[piccolo2d-dev] Re: Issue 12 in piccolo2d: Generics Support

2009-07-10 Thread allain

If this is the direction the project wants to go in, I'd more than
gladly make the changes to the rest of the code base. Just want to
know that it won't be wasted effort.

When will we have a result for this "vote"?

On Jul 8, 4:04 pm, codesite-nore...@google.com wrote:
> Comment #11 on issue 12 by willismorse: Generics 
> Supporthttp://code.google.com/p/piccolo2d/issues/detail?id=12
>
> I vote for adding generics. We're almost ready to drop support for 1.5 in  
> our products; 1.4 has been off our
> radar for a couple years now.
>
> --
> You received this message because you are listed in the owner
> or CC fields of this issue, or because you starred this issue.
> You may adjust your issue notification preferences 
> at:http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---