[piccolo2d-dev] Re: Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related
Updates: Labels: Milestone-2.0 Type-Enhancement Priority-Low OpSys-All Effort-Low Toolkit-Piccolo2D.Java Component-Core Usability Comment #1 on issue 166 by allain.lalonde: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 Unless you keep the existing methods doesn't moving a child to be immediately before one of its siblings cumbersome? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] [piccolo2d] r973 committed - Fix for Issue 163 changes in size of node itself were being detected, ...
Revision: 973
Author: allain.lalonde
Date: Fri Feb 26 13:32:02 2010
Log: Fix for Issue 163 changes in size of node itself were being detected,
but not changes in the size of its progeny.
I'm not entirely sure why a method called ancestorResized gets called
when a subcomponent changes... but I'm not going to complain. Just works.
http://code.google.com/p/piccolo2d/source/detail?r=973
Modified:
/piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java
===
---
/piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java
Tue Feb 2 11:20:47 2010
+++
/piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java
Fri Feb 26 13:32:02 2010
@@ -42,6 +42,8 @@
import java.awt.event.ContainerAdapter;
import java.awt.event.ContainerEvent;
import java.awt.event.ContainerListener;
+import java.awt.event.HierarchyBoundsAdapter;
+import java.awt.event.HierarchyEvent;
import java.awt.geom.Rectangle2D;
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
@@ -323,7 +325,13 @@
public void propertyChange(final PropertyChangeEvent evt) {
updateBounds();
}
-});
+});
+component.addHierarchyBoundsListener(new HierarchyBoundsAdapter() {
+/** {...@inheritdoc} */
+public void ancestorResized(HierarchyEvent arg0) {
+updateBounds();
+}
+});
updateBounds();
listenForCanvas(this);
@@ -430,9 +438,9 @@
/** {...@inheritdoc} */
public void setVisible(final boolean visible) {
super.setVisible(visible);
-
+
if (component.isVisible() != visible) {
- component.setVisible(visible);
+component.setVisible(visible);
}
}
@@ -643,8 +651,9 @@
}
if (newCanvas == null) {
- canvas = null;
-} else {
+canvas = null;
+}
+else {
canvas = newCanvas;
canvas.addPSwing(this);
updateBounds();
--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly
Updates: Status: Fixed Comment #4 on issue 163 by allain.lalonde: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Fixed in r973 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] [piccolo2d] r974 committed - Issue 166 ; improved javadoc comments for moveToFront and related. Fi...
Revision: 974
Author: heuermh
Date: Fri Feb 26 13:55:45 2010
Log: Issue 166 ; improved javadoc comments for moveToFront and related.
Fixes issue 166.
http://code.google.com/p/piccolo2d/source/detail?r=974
Modified:
/piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
===
--- /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
Mon Feb 1 11:58:18 2010
+++ /piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
Fri Feb 26 13:55:45 2010
@@ -3328,9 +3328,9 @@
/**
* Change the order of this node in its parent's children list so that
it
- * will draw in front of all of its other sibling nodes.
+ * will draw in back of the specified sibling node.
*
- * @param sibling sibling in back of which this nodes should be moved.
+ * @param sibling sibling to move in back of
*/
public void moveInBackOf(final PNode sibling) {
final PNode p = parent;
@@ -3343,7 +3343,7 @@
/**
* Change the order of this node in its parent's children list so that
it
- * will draw after the given sibling node.
+ * will draw in front of all of its other sibling nodes.
*/
public void moveToFront() {
final PNode p = parent;
@@ -3355,9 +3355,9 @@
/**
* Change the order of this node in its parent's children list so that
it
- * will draw before the given sibling node.
+ * will draw in front of the specified sibling node.
*
- * @param sibling sibling in front of which this nodes should be moved.
+ * @param sibling sibling to move in front of
*/
public void moveInFrontOf(final PNode sibling) {
final PNode p = parent;
--
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 166 in piccolo2d: Refactor PNode.moveToBack() and related
Updates: Status: Accepted Comment #3 on issue 166 by heue...@gmail.com: Refactor PNode.moveToBack() and related http://code.google.com/p/piccolo2d/issues/detail?id=166 False alarm, issue 165 was fixed by r974, not this one. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly
Comment #5 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 Verified that r973 solves the problem, both in TestPSwingDynamicComponent and the PhET application where this was first noticed. Note that there were a couple of unrelated format changes in PSwing r973, probably attributable to Eclipse. Thanks once again Allain. HierarchyBoundsListener is a new one for me. Should someone change their vote and fail 1.3-rc3? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: [VOTE] Release Piccolo2D.Java 1.3
Michael Heuer wrote: Vote will close at 12:00 GMT Friday 26 February 2010. I would like to extend to vote deadline until Monday 01 March 2010 to allow for feedback on recently fixed issues 163 and 165. The current vote would pass as it stands and the fixes for those issues would not be released until a later version. michael -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Release Piccolo2D.Java 1.3
My client (PhET) uses PSwing quite heavily. But I'm not going to -1 in order to get the 163 fix, for 3 reasons: (1) The consensus within PhET is that we're comfortable with patching our 1.3 copy to resolve 163. (2) Imho PSwing needs an internal overhaul, to bring the code up to the standards of Piccolo. Poor name choices is my biggest beef, luckily with private stuff. (3) There are additional PSwing issues that need to be resolved. We have not yet reported these, but are tracking them internally. The big 2 issues are focus traversal and memory leaks when PSwings are removed from the scenegraph. Chris On Feb 26, 4:16 pm, Michael Heuer heue...@gmail.com wrote: Michael Heuer wrote: Vote will close at 12:00 GMT Friday 26 February 2010. I would like to extend to vote deadline until Monday 01 March 2010 to allow for feedback on recently fixed issues 163 and 165. The current vote would pass as it stands and the fixes for those issues would not be released until a later version. michael -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
