[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Updates: Status: Verified Comment #7 on issue 90 by mr0...@mro.name: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Updates: Status: Fixed Comment #6 on issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 I am rolling back r395 to fix Issue 90 and await further comment on Issue 19. $ svn commit -m "Issue 19, Issue 90 ; rolling back changes made in r395" Sending... Transmitting file data ... Committed revision 592. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Comment #5 on issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 I'm currently leaning towards rolling back r395, as the original motivation for the change in Issue 19 is not very strong. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Comment #4 on issue 90 by allain.lalonde: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 Also, since the constructor to PInputEvent is primbary only invoked form PInputManager (processEvent and keyboardFocus events), I'm not sure breaking this particular binary compatibility will actually affect any clients. You can't subclass PInputEvent and have Piccolo use your customization. I can't conceivably think of a reason for creating instances of PInputEvent other than maybe unit testing, though I'd love to hear one. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Comment #3 on issue 90 by allain.lalonde: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 Almost seems like we're trying to force two different kinds of things into one. Seems like there could be two subclasses PPickPathInputEvent event and PCameraInputEvent since there are methods that assume you have a PPickpath, like getPickedNode and lots of "return (getPath() == null)? inputSource : getPath().get..." thoughts? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Updates: Status: Accepted Owner: heuermh Comment #2 on issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Status: New Owner: Labels: Type-Defect Priority-Critical OpSys-All Toolkit-Piccolo2D.Java Component-Core Milestone-1.3 New issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 Clirr reports a binary incompatible change to PInputEvent $ clirr.sh -o piccolo2d-core-1.2.1.jar -n piccolo2d-core-1.3-SNAPSHOT.jar ERROR: 7004: edu.umd.cs.piccolo.event.PInputEvent: In method 'public PInputEvent(edu.umd.cs.piccolo.PInputManager, java.awt.event.InputEvent )' the number of arguments has changed See http://clirr.sourceforge.net/ http://wiki.eclipse.org/index.php/Evolving_Java-based_APIs -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Comment #1 on issue 90 by heuermh: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 Re-opened Issue 19. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
