[jira] Commented: (PIG-878) Pig is returning too many blocks in the InputSplit
[ https://issues.apache.org/jira/browse/PIG-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733293#action_12733293 ] Alan Gates commented on PIG-878: Should note also that I didn't add any tests because this was a fix for existing functionality, and frankly I'm not exactly sure how to test it. Also should have noted thanks to Milind for first brining this to our attention. Pig is returning too many blocks in the InputSplit -- Key: PIG-878 URL: https://issues.apache.org/jira/browse/PIG-878 Project: Pig Issue Type: Bug Affects Versions: 0.3.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Fix For: 0.4.0 Attachments: PIG-878.patch When SlicerWrapper builds a slice, it currently returns the 3 locations for every block in the file it is slicing, instead of the 3 locations for the block covered by that slice. This means Pig's odds of having its maps placed on nodes local to the data goes way down. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-878) Pig is returning too many blocks in the InputSplit
[ https://issues.apache.org/jira/browse/PIG-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733311#action_12733311 ] Arun C Murthy commented on PIG-878: --- bq. Should note also that I didn't add any tests because this was a fix for existing functionality, and frankly I'm not exactly sure how to test it. We could check the #splits returned by the slicer to ensure it's equal to the replication factor of the input files? Pig is returning too many blocks in the InputSplit -- Key: PIG-878 URL: https://issues.apache.org/jira/browse/PIG-878 Project: Pig Issue Type: Bug Affects Versions: 0.3.0 Reporter: Alan Gates Assignee: Alan Gates Priority: Critical Fix For: 0.4.0 Attachments: PIG-878.patch When SlicerWrapper builds a slice, it currently returns the 3 locations for every block in the file it is slicing, instead of the 3 locations for the block covered by that slice. This means Pig's odds of having its maps placed on nodes local to the data goes way down. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-885) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate)
[ https://issues.apache.org/jira/browse/PIG-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-885: --- Status: In Progress (was: Patch Available) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate) Key: PIG-885 URL: https://issues.apache.org/jira/browse/PIG-885 Project: Pig Issue Type: New Feature Affects Versions: 0.3.0 Reporter: Daniel Dai Assignee: Daniel Dai Priority: Minor Fix For: 0.4.0 Attachments: PIG-885-2.patch, PIG-885-3.patch, PIG-885.patch Bunch of UDFs: 1. Bin -- Converts a continuous value into discrete values 2. Decode -- Converts a given attribute or expression into another string value, based on the value of the source attribute 3. LookupInFiles -- Check for the existence of an expression in a serial of text files 4. RegexExtract and RegexMatch -- Similar to perl regexes 5. HashFNV -- An implementation of FNV hash 6. DiffDate -- Caculate the number of days in between -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-885) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate)
[ https://issues.apache.org/jira/browse/PIG-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-885: --- Status: Patch Available (was: In Progress) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate) Key: PIG-885 URL: https://issues.apache.org/jira/browse/PIG-885 Project: Pig Issue Type: New Feature Affects Versions: 0.3.0 Reporter: Daniel Dai Assignee: Daniel Dai Priority: Minor Fix For: 0.4.0 Attachments: PIG-885-2.patch, PIG-885-3.patch, PIG-885.patch Bunch of UDFs: 1. Bin -- Converts a continuous value into discrete values 2. Decode -- Converts a given attribute or expression into another string value, based on the value of the source attribute 3. LookupInFiles -- Check for the existence of an expression in a serial of text files 4. RegexExtract and RegexMatch -- Similar to perl regexes 5. HashFNV -- An implementation of FNV hash 6. DiffDate -- Caculate the number of days in between -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich updated PIG-892: --- Status: Patch Available (was: Open) Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-885) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate)
[ https://issues.apache.org/jira/browse/PIG-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-885: --- Attachment: PIG-885-4.patch New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate) Key: PIG-885 URL: https://issues.apache.org/jira/browse/PIG-885 Project: Pig Issue Type: New Feature Affects Versions: 0.3.0 Reporter: Daniel Dai Assignee: Daniel Dai Priority: Minor Fix For: 0.4.0 Attachments: PIG-885-2.patch, PIG-885-3.patch, PIG-885-4.patch, PIG-885.patch Bunch of UDFs: 1. Bin -- Converts a continuous value into discrete values 2. Decode -- Converts a given attribute or expression into another string value, based on the value of the source attribute 3. LookupInFiles -- Check for the existence of an expression in a serial of text files 4. RegexExtract and RegexMatch -- Similar to perl regexes 5. HashFNV -- An implementation of FNV hash 6. DiffDate -- Caculate the number of days in between -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-885) New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate)
[ https://issues.apache.org/jira/browse/PIG-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733376#action_12733376 ] Hadoop QA commented on PIG-885: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414031/PIG-885-3.patch against trunk revision 795931. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/136/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/136/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/136/console This message is automatically generated. New UDFs for piggybank (Bin, Decode, LookupInFiles, RegexExtract, RegexMatch, HashFVN, DiffDate) Key: PIG-885 URL: https://issues.apache.org/jira/browse/PIG-885 Project: Pig Issue Type: New Feature Affects Versions: 0.3.0 Reporter: Daniel Dai Assignee: Daniel Dai Priority: Minor Fix For: 0.4.0 Attachments: PIG-885-2.patch, PIG-885-3.patch, PIG-885-4.patch, PIG-885.patch Bunch of UDFs: 1. Bin -- Converts a continuous value into discrete values 2. Decode -- Converts a given attribute or expression into another string value, based on the value of the source attribute 3. LookupInFiles -- Check for the existence of an expression in a serial of text files 4. RegexExtract and RegexMatch -- Similar to perl regexes 5. HashFNV -- An implementation of FNV hash 6. DiffDate -- Caculate the number of days in between -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-875) Making COUNT and AVG semantics SQL compliant
[ https://issues.apache.org/jira/browse/PIG-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733400#action_12733400 ] David Ciemiewicz commented on PIG-875: -- Can I suggest that we might the default to behavior to be to not count nulls, but we might want a way for nulls to be counted with AVG_WITH_NULLS and COUNT_WITH_NULLS or that we might want a DEFINE statement to set an option to turn on and off null count behavior. Making COUNT and AVG semantics SQL compliant Key: PIG-875 URL: https://issues.apache.org/jira/browse/PIG-875 Project: Pig Issue Type: Bug Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Currently both AVG and COUNT counts NULLs -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-875) Making COUNT and AVG semantics SQL compliant
[ https://issues.apache.org/jira/browse/PIG-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733403#action_12733403 ] Olga Natkovich commented on PIG-875: I don't think we want to define at runtime whether UDF needs to count nulls since it complicates and slows the code. I don't think there is a precedent of AVG counting NULLs and so I don't feel we need to support it. Otherwise, why not do the same for SUM, MIN, and MAX. If users want to do that, they can implement their own UDFs but I don't feel we need to support this by default. I can change the name of the function if it makes it more intuitive. It just seems a bit long. Making COUNT and AVG semantics SQL compliant Key: PIG-875 URL: https://issues.apache.org/jira/browse/PIG-875 Project: Pig Issue Type: Bug Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Currently both AVG and COUNT counts NULLs -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-875) Making COUNT and AVG semantics SQL compliant
[ https://issues.apache.org/jira/browse/PIG-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich resolved PIG-875. Resolution: Duplicate opened two issues by mistake. This is duplicate of https://issues.apache.org/jira/browse/PIG-892 Making COUNT and AVG semantics SQL compliant Key: PIG-875 URL: https://issues.apache.org/jira/browse/PIG-875 Project: Pig Issue Type: Bug Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Currently both AVG and COUNT counts NULLs -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: Pig-Patch-minerva.apache.org #137
See http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/137/ -- [...truncated 96327 lines...] [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: PacketResponder 0 for block blk_251446121189542907_1011 terminating [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: Received block blk_251446121189542907_1011 of size 6 from /127.0.0.1 [exec] [junit] 09/07/21 00:12:34 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:44369 is added to blk_251446121189542907_1011 size 6 [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: PacketResponder 1 for block blk_251446121189542907_1011 terminating [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: Received block blk_251446121189542907_1011 of size 6 from /127.0.0.1 [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: PacketResponder 2 for block blk_251446121189542907_1011 terminating [exec] [junit] 09/07/21 00:12:34 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:57975 is added to blk_251446121189542907_1011 size 6 [exec] [junit] 09/07/21 00:12:34 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:39793 is added to blk_251446121189542907_1011 size 6 [exec] [junit] 09/07/21 00:12:34 INFO executionengine.HExecutionEngine: Connecting to hadoop file system at: hdfs://localhost:33085 [exec] [junit] 09/07/21 00:12:34 INFO executionengine.HExecutionEngine: Connecting to map-reduce job tracker at: localhost:50178 [exec] [junit] 09/07/21 00:12:34 INFO mapReduceLayer.MultiQueryOptimizer: MR plan size before optimization: 1 [exec] [junit] 09/07/21 00:12:34 INFO mapReduceLayer.MultiQueryOptimizer: MR plan size after optimization: 1 [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: Deleting block blk_-3764337067040815955_1005 file dfs/data/data1/current/blk_-3764337067040815955 [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: Deleting block blk_-719990796447918754_1006 file dfs/data/data2/current/blk_-719990796447918754 [exec] [junit] 09/07/21 00:12:34 INFO dfs.DataNode: Deleting block blk_2272703488235946744_1004 file dfs/data/data2/current/blk_2272703488235946744 [exec] [junit] 09/07/21 00:12:35 INFO mapReduceLayer.JobControlCompiler: Setting up single store job [exec] [junit] 09/07/21 00:12:35 WARN mapred.JobClient: Use GenericOptionsParser for parsing the arguments. Applications should implement Tool for the same. [exec] [junit] 09/07/21 00:12:35 INFO dfs.StateChange: BLOCK* NameSystem.allocateBlock: /tmp/hadoop-hudson/mapred/system/job_200907210011_0002/job.jar. blk_750383680635397624_1012 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Receiving block blk_750383680635397624_1012 src: /127.0.0.1:37942 dest: /127.0.0.1:39793 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Receiving block blk_750383680635397624_1012 src: /127.0.0.1:38834 dest: /127.0.0.1:58501 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Receiving block blk_750383680635397624_1012 src: /127.0.0.1:55031 dest: /127.0.0.1:57975 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Received block blk_750383680635397624_1012 of size 1453715 from /127.0.0.1 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: PacketResponder 0 for block blk_750383680635397624_1012 terminating [exec] [junit] 09/07/21 00:12:35 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:57975 is added to blk_750383680635397624_1012 size 1453715 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Received block blk_750383680635397624_1012 of size 1453715 from /127.0.0.1 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: PacketResponder 1 for block blk_750383680635397624_1012 terminating [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: Received block blk_750383680635397624_1012 of size 1453715 from /127.0.0.1 [exec] [junit] 09/07/21 00:12:35 INFO dfs.DataNode: PacketResponder 2 for block blk_750383680635397624_1012 terminating [exec] [junit] 09/07/21 00:12:35 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:58501 is added to blk_750383680635397624_1012 size 1453715 [exec] [junit] 09/07/21 00:12:35 INFO dfs.StateChange: BLOCK* NameSystem.addStoredBlock: blockMap updated: 127.0.0.1:39793 is added to blk_750383680635397624_1012 size 1453715 [exec] [junit] 09/07/21 00:12:35 INFO fs.FSNamesystem: Increasing replication for file /tmp/hadoop-hudson/mapred/system/job_200907210011_0002/job.jar. New replication is 2 [exec] [junit] 09/07/21 00:12:35 INFO fs.FSNamesystem: Reducing replication for file /tmp/hadoop-hudson/mapred/system/job_200907210011_0002/job.jar. New replication is
[jira] Commented: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733412#action_12733412 ] Hadoop QA commented on PIG-892: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414035/PIG-892.patch against trunk revision 795931. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/137/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/137/console This message is automatically generated. Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-660) Integration with Hadoop 0.20
[ https://issues.apache.org/jira/browse/PIG-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitriy V. Ryaboy updated PIG-660: -- Attachment: PIG-660_5.patch Updating the patch to set PIG_HADOOP_VERSION to 20 by default. Integration with Hadoop 0.20 Key: PIG-660 URL: https://issues.apache.org/jira/browse/PIG-660 Project: Pig Issue Type: Bug Components: impl Affects Versions: 0.2.0 Environment: Hadoop 0.20 Reporter: Santhosh Srinivasan Assignee: Santhosh Srinivasan Fix For: 0.4.0 Attachments: PIG-660.patch, PIG-660_1.patch, PIG-660_2.patch, PIG-660_3.patch, PIG-660_4.patch, PIG-660_5.patch With Hadoop 0.20, it will be possible to query the status of each map and reduce in a map reduce job. This will allow better error reporting. Some of the other items that could be on Hadoop's feature requests/bugs are documented here for tracking. 1. Hadoop should return objects instead of strings when exceptions are thrown 2. The JobControl should handle all exceptions and report them appropriately. For example, when the JobControl fails to launch jobs, it should handle exceptions appropriately and should support APIs that query this state, i.e., failure to launch jobs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-695) Pig should not fail when error logs cannot be created
[ https://issues.apache.org/jira/browse/PIG-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733415#action_12733415 ] Pradeep Kamath commented on PIG-695: +1 Pig should not fail when error logs cannot be created - Key: PIG-695 URL: https://issues.apache.org/jira/browse/PIG-695 Project: Pig Issue Type: Bug Components: impl Affects Versions: 0.2.0 Reporter: Santhosh Srinivasan Assignee: Santhosh Srinivasan Attachments: PIG-695.patch Currently, PIG validates the log file location and fails/exits when the log file cannot be created. Instead, it should print a warning and continue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich updated PIG-892: --- Attachment: PIG-892_v2.patch Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch, PIG-892_v2.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich updated PIG-892: --- Status: Open (was: Patch Available) Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch, PIG-892_v2.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olga Natkovich updated PIG-892: --- Status: Patch Available (was: Open) resubmitting the patch with resolved findbug warnings which was related to using Long constructor. We are actually using it in many other cases and might have to review this later Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch, PIG-892_v2.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-892) Make COUNT and AVG deal with nulls accordingly with SQL standar
[ https://issues.apache.org/jira/browse/PIG-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733457#action_12733457 ] Hadoop QA commented on PIG-892: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414046/PIG-892_v2.patch against trunk revision 795931. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/138/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/138/console This message is automatically generated. Make COUNT and AVG deal with nulls accordingly with SQL standar --- Key: PIG-892 URL: https://issues.apache.org/jira/browse/PIG-892 Project: Pig Issue Type: Improvement Affects Versions: 0.3.0 Reporter: Olga Natkovich Assignee: Olga Natkovich Fix For: 0.4.0 Attachments: PIG-892.patch, PIG-892_v2.patch both COUNT and AVG need to ignore nulls. Also add COUNT_STAR to match COUNT(*) in SQL -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
