[jira] Commented: (PIG-1572) change default datatype when relations are used as scalar to bytearray

2010-09-01 Thread Daniel Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905293#action_12905293
 ] 

Daniel Dai commented on PIG-1572:
-

Patch looks good. One minor doubt is when we migrate to new logical plan, 
UserFuncExpression already have necessary cast inserted, seems we do not need 
to change new logical plan's UserFuncExpression.getFieldSchema(), am I right?

 change default datatype when relations are used as scalar to bytearray
 --

 Key: PIG-1572
 URL: https://issues.apache.org/jira/browse/PIG-1572
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Thejas M Nair
 Fix For: 0.8.0

 Attachments: PIG-1572.1.patch, PIG-1572.2.patch


 When relations are cast to scalar, the current default type is chararray. 
 This is inconsistent with the behavior in rest of pig-latin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1572) change default datatype when relations are used as scalar to bytearray

2010-09-01 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905324#action_12905324
 ] 

Thejas M Nair commented on PIG-1572:


Yes, the changes to UserFuncExpression.getFieldSchema() are no longer required 
because the cast inserted to appropriate type. But while thinking about that I 
believe I have found an issue with the handling of non PigStorage load 
functions.
Since this patch address a bunch of issues I will commit it and create a new 
jira to address that, and also look at the utility of this change to 
UserFuncExpression.getFieldSchema().



 change default datatype when relations are used as scalar to bytearray
 --

 Key: PIG-1572
 URL: https://issues.apache.org/jira/browse/PIG-1572
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Thejas M Nair
 Fix For: 0.8.0

 Attachments: PIG-1572.1.patch, PIG-1572.2.patch


 When relations are cast to scalar, the current default type is chararray. 
 This is inconsistent with the behavior in rest of pig-latin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1572) change default datatype when relations are used as scalar to bytearray

2010-09-01 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905332#action_12905332
 ] 

Thejas M Nair commented on PIG-1572:


Patch committed to 0.8 branch as well .

 change default datatype when relations are used as scalar to bytearray
 --

 Key: PIG-1572
 URL: https://issues.apache.org/jira/browse/PIG-1572
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Thejas M Nair
 Fix For: 0.8.0

 Attachments: PIG-1572.1.patch, PIG-1572.2.patch


 When relations are cast to scalar, the current default type is chararray. 
 This is inconsistent with the behavior in rest of pig-latin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (PIG-1572) change default datatype when relations are used as scalar to bytearray

2010-09-01 Thread Thejas M Nair (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905346#action_12905346
 ] 

Thejas M Nair commented on PIG-1572:


bq. Yes, the changes to UserFuncExpression.getFieldSchema() are no longer 
required because the cast inserted to appropriate type. But while thinking 
about that I believe I have found an issue with the handling of non PigStorage 
load functions.
Since this patch address a bunch of issues I will commit it and create a new 
jira to address that, and also look at the utility of this change to 
UserFuncExpression.getFieldSchema().

Created  PIG-1595 to address the issue.

 change default datatype when relations are used as scalar to bytearray
 --

 Key: PIG-1572
 URL: https://issues.apache.org/jira/browse/PIG-1572
 Project: Pig
  Issue Type: Bug
Reporter: Thejas M Nair
Assignee: Thejas M Nair
 Fix For: 0.8.0

 Attachments: PIG-1572.1.patch, PIG-1572.2.patch


 When relations are cast to scalar, the current default type is chararray. 
 This is inconsistent with the behavior in rest of pig-latin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.