[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757237#action_12757237 ] Olga Natkovich commented on PIG-964: patch committed to the trunk > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skewedjoinnull.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756970#action_12756970 ] Olga Natkovich commented on PIG-964: patch committed to branch-0.5 > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skewedjoinnull.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756958#action_12756958 ] Olga Natkovich commented on PIG-964: +1 on the code > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skewedjoinnull.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756891#action_12756891 ] Hadoop QA commented on PIG-964: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419938/skewedjoinnull.patch against trunk revision 816339. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/37/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/37/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/37/console This message is automatically generated. > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skewedjoinnull.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756700#action_12756700 ] Olga Natkovich commented on PIG-964: The patch needs unit tests > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skjoin2b.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-964) Handling null in skewed join
[ https://issues.apache.org/jira/browse/PIG-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756454#action_12756454 ] Hadoop QA commented on PIG-964: --- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419855/skjoin2b.patch against trunk revision 816012. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/36/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/36/console This message is automatically generated. > Handling null in skewed join > - > > Key: PIG-964 > URL: https://issues.apache.org/jira/browse/PIG-964 > Project: Pig > Issue Type: Bug >Reporter: Sriranjan Manjunath >Assignee: Sriranjan Manjunath > Attachments: skjoin2b.patch > > > For null tuples, the tuple size is calculated incorrectly and thus skewed > join ends up expecting a large number of reducers. Further, skewed join > should not bail out after the second job if the number of reducers specified > by the user is low. It should print a warning message and continue execution. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.