[jira] Commented: (PIG-968) findContainingJar fails when there's a + in the path
[ https://issues.apache.org/jira/browse/PIG-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763271#action_12763271 ] Todd Lipcon commented on PIG-968: - Yes, I think that would be a good manual test. > findContainingJar fails when there's a + in the path > > > Key: PIG-968 > URL: https://issues.apache.org/jira/browse/PIG-968 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.4.0, 0.5.0 >Reporter: Todd Lipcon > Attachments: pig-968.txt > > > This is the same bug as in MAPREDUCE-714. Please see discussion there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-968) findContainingJar fails when there's a + in the path
[ https://issues.apache.org/jira/browse/PIG-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759188#action_12759188 ] Alan Gates commented on PIG-968: Ok, if it's hard to test in an automated way that's fine. To test it manually, is it sufficient to create a jar with a + in the path, register it in a Pig Latin script, and then use a UDF from that jar in the script? > findContainingJar fails when there's a + in the path > > > Key: PIG-968 > URL: https://issues.apache.org/jira/browse/PIG-968 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.4.0, 0.5.0 >Reporter: Todd Lipcon > Attachments: pig-968.txt > > > This is the same bug as in MAPREDUCE-714. Please see discussion there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-968) findContainingJar fails when there's a + in the path
[ https://issues.apache.org/jira/browse/PIG-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758394#action_12758394 ] Todd Lipcon commented on PIG-968: - bq. You need to add a unit test that checks that this works when there is a + in the path. This is very difficult to test - we'd need to add several more ant rules to build a jar into the test directory with a + in it and get that on the classpath for tests. findContainingJar itself is not currently tested. bq. Also, a more general question: I'm guessing that '+' isn't the only mishandled character. Are there others that should be checked? It's well-known that URLDecoder actually decodes x-www-form-urlencoded rather than true URL encoding. The spec for that encoding is here: http://www.w3.org/MarkUp/html-spec/html-spec_8.html#SEC8.2.1 As far as I've been able to find, '+' is the only difference, except for perhaps newlines which can't occur in pathnames afaik. More info here: http://en.wikipedia.org/wiki/Percent-encoding#The_application.2Fx-www-form-urlencoded_type > findContainingJar fails when there's a + in the path > > > Key: PIG-968 > URL: https://issues.apache.org/jira/browse/PIG-968 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.4.0, 0.5.0 >Reporter: Todd Lipcon > Attachments: pig-968.txt > > > This is the same bug as in MAPREDUCE-714. Please see discussion there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-968) findContainingJar fails when there's a + in the path
[ https://issues.apache.org/jira/browse/PIG-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757596#action_12757596 ] Hadoop QA commented on PIG-968: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420098/pig-968.txt against trunk revision 816723. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/39/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/39/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/39/console This message is automatically generated. > findContainingJar fails when there's a + in the path > > > Key: PIG-968 > URL: https://issues.apache.org/jira/browse/PIG-968 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.4.0, 0.5.0 >Reporter: Todd Lipcon > Attachments: pig-968.txt > > > This is the same bug as in MAPREDUCE-714. Please see discussion there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
