[jira] Commented: (PIG-989) Allow type merge between numerical type and non-numerical type
[ https://issues.apache.org/jira/browse/PIG-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763592#action_12763592 ] Olga Natkovich commented on PIG-989: +1, looks good. Please, commit > Allow type merge between numerical type and non-numerical type > -- > > Key: PIG-989 > URL: https://issues.apache.org/jira/browse/PIG-989 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.5.0 >Reporter: Daniel Dai > Attachments: PIG-989-1.patch, PIG-989-2.patch > > > Currently, we do not allow type merge between numerical type and > non-numerical type. And the error message is confusing. > Eg, if you run: > a = load '1.txt' as (a0:chararray, a1:chararray); > b = load '2.txt' as (b0:long, b1:chararray); > c = join a by a0, b by b0; > dump c; > And the error message is "ERROR 1051: Cannot cast to Unknown" > We shall: > 1. Allow the type merge between numerical type and non-numerical type > 2. Or at least, provide more meaningful error message to the user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-989) Allow type merge between numerical type and non-numerical type
[ https://issues.apache.org/jira/browse/PIG-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761454#action_12761454 ] Hadoop QA commented on PIG-989: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421079/PIG-989-1.patch against trunk revision 820394. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/12/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/12/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/12/console This message is automatically generated. > Allow type merge between numerical type and non-numerical type > -- > > Key: PIG-989 > URL: https://issues.apache.org/jira/browse/PIG-989 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.5.0 >Reporter: Daniel Dai > Attachments: PIG-989-1.patch > > > Currently, we do not allow type merge between numerical type and > non-numerical type. And the error message is confusing. > Eg, if you run: > a = load '1.txt' as (a0:chararray, a1:chararray); > b = load '2.txt' as (b0:long, b1:chararray); > c = join a by a0, b by b0; > dump c; > And the error message is "ERROR 1051: Cannot cast to Unknown" > We shall: > 1. Allow the type merge between numerical type and non-numerical type > 2. Or at least, provide more meaningful error message to the user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-989) Allow type merge between numerical type and non-numerical type
[ https://issues.apache.org/jira/browse/PIG-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761390#action_12761390 ] Daniel Dai commented on PIG-989: There is no good way to add a unit test to it. I tested it manually. > Allow type merge between numerical type and non-numerical type > -- > > Key: PIG-989 > URL: https://issues.apache.org/jira/browse/PIG-989 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.5.0 >Reporter: Daniel Dai > Attachments: PIG-989-1.patch > > > Currently, we do not allow type merge between numerical type and > non-numerical type. And the error message is confusing. > Eg, if you run: > a = load '1.txt' as (a0:chararray, a1:chararray); > b = load '2.txt' as (b0:long, b1:chararray); > c = join a by a0, b by b0; > dump c; > And the error message is "ERROR 1051: Cannot cast to Unknown" > We shall: > 1. Allow the type merge between numerical type and non-numerical type > 2. Or at least, provide more meaningful error message to the user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-989) Allow type merge between numerical type and non-numerical type
[ https://issues.apache.org/jira/browse/PIG-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761351#action_12761351 ] Daniel Dai commented on PIG-989: I agree. Merge numerical type and non-numerical type have a semantic problem of which way to cast (whether to cast numerical to non-numerical, or vice versa). I think at this point, we can just fix the error message. > Allow type merge between numerical type and non-numerical type > -- > > Key: PIG-989 > URL: https://issues.apache.org/jira/browse/PIG-989 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.5.0 >Reporter: Daniel Dai > > Currently, we do not allow type merge between numerical type and > non-numerical type. And the error message is confusing. > Eg, if you run: > a = load '1.txt' as (a0:chararray, a1:chararray); > b = load '2.txt' as (b0:long, b1:chararray); > c = join a by a0, b by b0; > dump c; > And the error message is "ERROR 1051: Cannot cast to Unknown" > We shall: > 1. Allow the type merge between numerical type and non-numerical type > 2. Or at least, provide more meaningful error message to the user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-989) Allow type merge between numerical type and non-numerical type
[ https://issues.apache.org/jira/browse/PIG-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761347#action_12761347 ] Alan Gates commented on PIG-989: I agree the error message here is bad. It is not clear to me that we should do this join though. It's hard to see why people would want to join on two different key types when one of those is numeric and one is string. If they really want that, I think we should require an explicit cast, as in most cases I suspect this is a user error rather than desired behavior. > Allow type merge between numerical type and non-numerical type > -- > > Key: PIG-989 > URL: https://issues.apache.org/jira/browse/PIG-989 > Project: Pig > Issue Type: Bug > Components: impl >Affects Versions: 0.5.0 >Reporter: Daniel Dai > > Currently, we do not allow type merge between numerical type and > non-numerical type. And the error message is confusing. > Eg, if you run: > a = load '1.txt' as (a0:chararray, a1:chararray); > b = load '2.txt' as (b0:long, b1:chararray); > c = join a by a0, b by b0; > dump c; > And the error message is "ERROR 1051: Cannot cast to Unknown" > We shall: > 1. Allow the type merge between numerical type and non-numerical type > 2. Or at least, provide more meaningful error message to the user -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
