Re: [Piglit] [PATCH 5/5] fbo-clear-formats: Return texture name as uint.
Thanks. I went ahead and pushed this commit. Marek On Fri, May 3, 2013 at 9:18 AM, Fabian Bieler fabianbie...@fastmail.fm wrote: --- tests/fbo/fbo-clear-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-clear-formats.c b/tests/fbo/fbo-clear-formats.c index 690df72..8ee8e97 100644 --- a/tests/fbo/fbo-clear-formats.c +++ b/tests/fbo/fbo-clear-formats.c @@ -227,7 +227,7 @@ do_stencil_clear(GLenum format, GLuint tex, int level, int size) return true; } -static bool +static GLuint create_tex(GLenum internalformat, GLenum baseformat) { GLuint tex; -- 1.8.1.2 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader
On 05/08/2013 07:27 PM, Marek Olšák wrote: On Thu, May 9, 2013 at 1:16 AM, Brian Paulbri...@vmware.com wrote: BTW, I tried to test this with NVIDIA's driver but it appears that piglit can't create a GL 3.1 context: $ bin/gl-3.1-max-samplers -auto piglit: info: Failed to create GL 3.1 core context piglit: info: Failed to create any GL context PIGLIT: {'result': 'skip' } The issue with NVIDIA's driver is that it advertises ARB_compatibility, so it's not a 3.1 core profile. Piglit sees that and assumes the context creation failed and skips the test. It also doesn't run if I try to request a GL 3.1 compatibility context. Does this test really need GL 3.1? I changed the test to use config.supports_gl_compat_version = 20 (AFAICT only GL 2.0 features are used). Plus, I had to increase the window size to 300x300 because 32 vertex/fragment image units are reported on my system. Now the test passes with my NVIDIA driver. A patch with my changes is attached. -Brian max-samplers.patch Description: application/pgp-keys ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit