[Piglit] [Bug 86361] [Bisected]Piglit compile-program.c make fail
https://bugs.freedesktop.org/show_bug.cgi?id=86361 lu hua changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #3 from lu hua --- Verified.Fixed. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 86361] [Bisected]Piglit compile-program.c make fail
https://bugs.freedesktop.org/show_bug.cgi?id=86361 lu hua changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from lu hua --- It works well again. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH piglit] Don't test floats with the form ‘1f’
On Wed, Nov 26, 2014 at 10:43 AM, Neil Roberts wrote: > There is nothing in the GLSL spec which says you can have a float > literal without an exponent or a decimal point even if you add the ‘f’ > suffix. This patch replaces that literal with some other variations > that should be accepted according to the spec. > --- Indeed, you're right. The GLSL grammar is for once clear! Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH v2] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems
This patch fixes all issues with linking piglit gl/gles tests.
Thanks for addressing it.
-Mark
Emil Velikov writes:
> Similar to the earlier patch for waffle-less (glut) builds. The need
> for this patch became apparent as we removed the libGL link dependency
> in waffle.
>
> v2: Try to handle both gl and gles*.
>
> Cc: Mark Janes
> Reported-by: Mark Janes
> Signed-off-by: Emil Velikov
> ---
> tests/util/CMakeLists.txt | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt
> index 98eedd0..b95ed2f 100644
> --- a/tests/util/CMakeLists.txt
> +++ b/tests/util/CMakeLists.txt
> @@ -83,6 +83,11 @@ if(PIGLIT_USE_WAFFLE)
> list(APPEND UTIL_GL_LIBS
> ${WAFFLE_LDFLAGS}
> )
> + IF(PIGLIT_BUILD_GLX_TESTS)
> + list(APPEND UTIL_GL_LIBS
> + ${OPENGL_gl_LIBRARY}
> + )
> + ENDIF(PIGLIT_BUILD_GLX_TESTS)
> else()
> list(APPEND UTIL_GL_SOURCES
> piglit-framework-gl/piglit_glut_framework.c
> --
> 2.1.3
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH piglit] Don't test floats with the form ‘1f’
There is nothing in the GLSL spec which says you can have a float
literal without an exponent or a decimal point even if you add the ‘f’
suffix. This patch replaces that literal with some other variations
that should be accepted according to the spec.
---
tests/shaders/glsl-floating-constant-120.shader_test | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/glsl-floating-constant-120.shader_test
b/tests/shaders/glsl-floating-constant-120.shader_test
index 6695f79..5c7ec92 100644
--- a/tests/shaders/glsl-floating-constant-120.shader_test
+++ b/tests/shaders/glsl-floating-constant-120.shader_test
@@ -12,12 +12,14 @@ void main()
void main()
{
- float f1 = 1f;
- float f2 = 0.5F;
+ float f1 = 1.0f;
+ float f2 = 0.F;
+ float f3 = .2f;
+ float f4 = 5e-1F;
- gl_FragColor = vec4(f2, f1, 0.0, 0.0);
+ gl_FragColor = vec4(f1, f2, f3, f4);
}
[test]
draw rect -1 -1 2 2
-probe rgba 1 1 0.5 1.0 0.0 0.0
+probe rgba 1 1 1.0 0.0 0.2 0.5
--
1.9.3
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 86361] [Bisected]Piglit compile-program.c make fail
https://bugs.freedesktop.org/show_bug.cgi?id=86361 --- Comment #1 from EdB --- Created attachment 110060 --> https://bugs.freedesktop.org/attachment.cgi?id=110060&action=edit fix clCompileProgram with CL1.1 headers Hello If you need to stick with OpenCL 1.1 headers, please try this patch. Best regards -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems
Similar to the earlier patch for waffle-less (glut) builds. The need
for this patch became apparent as we removed the libGL link dependency
in waffle.
v2: Try to handle both gl and gles*.
Cc: Mark Janes
Reported-by: Mark Janes
Signed-off-by: Emil Velikov
---
tests/util/CMakeLists.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt
index 98eedd0..b95ed2f 100644
--- a/tests/util/CMakeLists.txt
+++ b/tests/util/CMakeLists.txt
@@ -83,6 +83,11 @@ if(PIGLIT_USE_WAFFLE)
list(APPEND UTIL_GL_LIBS
${WAFFLE_LDFLAGS}
)
+ IF(PIGLIT_BUILD_GLX_TESTS)
+ list(APPEND UTIL_GL_LIBS
+ ${OPENGL_gl_LIBRARY}
+ )
+ ENDIF(PIGLIT_BUILD_GLX_TESTS)
else()
list(APPEND UTIL_GL_SOURCES
piglit-framework-gl/piglit_glut_framework.c
--
2.1.3
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems
On 25/11/14 18:45, Mark Janes wrote:
> This patched fixed the gl tests, but I encountered the same error for
> gles1/gles2/gles3.
>
> Piglit built for me when I added the same link instruction to:
>
> tests/util/CMakeLists.gles1.txt
> tests/util/CMakeLists.gles2.txt
> tests/util/CMakeLists.gles3.txt
>
Please don't. A slightly better patch is on it's way.
> Is there a more specific (GLES) link instruction that should be used,
> instead of linking the gles tests against GL?
>
Things are not as black and white as you might think. Most of piglit
uses what I call "target-less rules", which means that when one does
add_definitions ( -DPIGLIT_USE_GLX )
or
link_libraries(${OPENGL_gl_LIBRARY})
the rule is applied for up-to XX (don't remember the limit) cmake files.
Meaning that despite the PIGLIT_USE_GLX define being inside
tests/util/CMakeLists.gl.txt it will be applied when building any of the
es* targets.
So if you build everything in one go, and then you're interested in
running the es* tests on a libGL(glx)-less setup if won't work :\
Things are rather messy...
Cheers,
Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
