Re: [Piglit] [PATCH v5] cl: add clEnqueue-read_write BufferRect releated tests
Hello
I was about to push it, be find that some of the errors tests return CL_SUCCESS
when they shouldn't have, sorry about that.
Does this test pass on INTEL OCL?
See comments below
On Monday 03 August 2015 01:59:44 Meng Mengmeng wrote:
It's a simple function test for clEnqueueReadBufferRect and
clEnqueueWriteBufferRect.
---
tests/cl.py | 2 +
tests/cl/api/CMakeLists.cl.txt| 1 +
tests/cl/api/enqueue-read_write-buffer-rect.c | 338
++ 3 files changed, 341 insertions(+)
create mode 100644 tests/cl/api/enqueue-read_write-buffer-rect.c
diff --git a/tests/cl.py b/tests/cl.py
index 4668ddc..572ccdc 100644
--- a/tests/cl.py
+++ b/tests/cl.py
@@ -58,6 +58,8 @@ with profile.group_manager(PiglitCLTest, 'api') as g:
g(['cl-api-enqueue-copy-buffer-rect'], 'clEnqueueCopyBufferRect')
g(['cl-api-enqueue-read_write-buffer'],
'clEnqueueReadBuffer and clEnqueueWriteBuffer')
+g(['cl-api-enqueue-read_write-buffer-rect'],
+ 'clEnqueueReadBufferRect and clEnqueueWriteBufferRect')
g(['cl-api-get-mem-object-info'], 'clGetMemObjectInfo')
g(['cl-api-get-image-info'], 'clGetImageInfo')
g(['cl-api-retain_release-mem-object'],
diff --git a/tests/cl/api/CMakeLists.cl.txt b/tests/cl/api/CMakeLists.cl.txt
index b598528..f0a388f 100644
--- a/tests/cl/api/CMakeLists.cl.txt
+++ b/tests/cl/api/CMakeLists.cl.txt
@@ -21,6 +21,7 @@ piglit_cl_add_api_test (enqueue-copy-buffer
enqueue-copy-buffer.c) piglit_cl_add_api_test (enqueue-map-buffer
enqueue-map-buffer.c)
piglit_cl_add_api_test (enqueue-copy-buffer-rect
enqueue-copy-buffer-rect.c) piglit_cl_add_api_test
(enqueue-read_write-buffer enqueue-read_write-buffer.c)
+piglit_cl_add_api_test (enqueue-read_write-buffer-rect
enqueue-read_write-buffer-rect.c) piglit_cl_add_api_test
(retain_release-mem-object retain_release-mem-object.c)
piglit_cl_add_api_test (get-mem-object-info get-mem-object-info.c)
piglit_cl_add_api_test (get-image-info get-image-info.c)
diff --git a/tests/cl/api/enqueue-read_write-buffer-rect.c
b/tests/cl/api/enqueue-read_write-buffer-rect.c new file mode 100644
index 000..6f7d2ca
--- /dev/null
+++ b/tests/cl/api/enqueue-read_write-buffer-rect.c
@@ -0,0 +1,338 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the
Software), + * to deal in the Software without restriction, including
without limitation + * the rights to use, copy, modify, merge, publish,
distribute, sublicense, + * and/or sell copies of the Software, and to
permit persons to whom the + * Software is furnished to do so, subject to
the following conditions: + *
+ * The above copyright notice and this permission notice (including the
next + * paragraph) shall be included in all copies or substantial portions
of the + * Software.
+ *
+ * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS
OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE.
+ *
+ * Authors: Meng Mengmeng mengmeng.meng at intel.com
+ *
+ */
+
+#include piglit-framework-cl-api.h
+#include piglit-util-cl.h
+
+
+PIGLIT_CL_API_TEST_CONFIG_BEGIN
+
+ config.name = clEnqueueReadBufferRect and clEnqueueWriteBufferRect;
+ config.version_min = 11;
+
+ config.run_per_platform = true;
+ config.create_context = true;
+
+PIGLIT_CL_API_TEST_CONFIG_END
+
+static bool
+test_read_rect(cl_command_queue command_queue,
+ cl_mem buffer,
+ cl_bool blocking_read,
+ const size_t * buffer_origin,
+ const size_t * host_origin,
+ const size_t * region,
+ size_t buffer_row_pitch,
+ size_t buffer_slice_pitch,
+ size_t host_row_pitch,
+ size_t host_slice_pitch,
+ void *ptr,
+ cl_uint num_events_in_wait_list,
+ const cl_event *event_wait_list,
+ cl_event *event,
+ cl_int expected_error,
+ enum piglit_result* result,
+ const char* test_str) {
+ cl_int errNo;
+
+ errNo = clEnqueueReadBufferRect(command_queue,
+ buffer,
+ blocking_read,
+ buffer_origin,
+ host_origin,
+ region,
+
Re: [Piglit] [PATCH] cl-api-get-kernel-work-group-info: Fix memory leak.
Reviewed-by: Serge Martin (EdB) edb+pig...@sigluy.net On Monday 17 August 2015 21:37:14 Vinson Lee wrote: Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/get-kernel-work-group-info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cl/api/get-kernel-work-group-info.c b/tests/cl/api/get-kernel-work-group-info.c index 5942e15..4a393c3 100644 --- a/tests/cl/api/get-kernel-work-group-info.c +++ b/tests/cl/api/get-kernel-work-group-info.c @@ -94,6 +94,7 @@ piglit_cl_test(const int argc, piglit_cl_get_device_info(env-device_id, CL_DEVICE_TYPE); if (*dev_type_ptr != CL_DEVICE_TYPE_CUSTOM) success_code = CL_INVALID_VALUE; + free(dev_type_ptr); } #endif ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 91670] [bisected] piglit.spec.!opengl 3_2.layered-rendering.framebuffertexture fails
https://bugs.freedesktop.org/show_bug.cgi?id=91670 Mark Janes mark.a.ja...@intel.com changed: What|Removed |Added Component|Drivers/DRI/i965|tests Version|git |unspecified Assignee|i...@freedesktop.org |pig...@lists.freedesktop.or ||g Product|Mesa|piglit QA Contact|intel-3d-bugs@lists.freedes |pig...@lists.freedesktop.or |ktop.org|g --- Comment #3 from Mark Janes mark.a.ja...@intel.com --- Timothy's patch works as expected. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] gl-3.2: fix layered-rendering test
Tested-by: Mark Janes mark.a.ja...@intel.com
Timothy Arceri t_arc...@yahoo.com.au writes:
Samples must be greater than 0 and color formats must match.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91670
---
tests/spec/gl-3.2/layered-rendering/framebuffertexture.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/gl-3.2/layered-rendering/framebuffertexture.c
b/tests/spec/gl-3.2/layered-rendering/framebuffertexture.c
index d6eef1e..88599de 100644
--- a/tests/spec/gl-3.2/layered-rendering/framebuffertexture.c
+++ b/tests/spec/gl-3.2/layered-rendering/framebuffertexture.c
@@ -137,10 +137,10 @@ create_bind_texture(GLenum textureType) {
}
break;
case GL_TEXTURE_2D_MULTISAMPLE:
- glTexImage2DMultisample(textureType, 0, GL_RGB, 6, 6, GL_FALSE);
+ glTexImage2DMultisample(textureType, 1, GL_RGBA, 6, 6,
GL_FALSE);
break;
case GL_TEXTURE_2D_MULTISAMPLE_ARRAY:
- glTexImage3DMultisample(textureType, 0, GL_RGB,
+ glTexImage3DMultisample(textureType, 1, GL_RGBA,
6, 6, 6, GL_FALSE);
break;
}
--
2.4.3
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 91680] Different stats in output reports
https://bugs.freedesktop.org/show_bug.cgi?id=91680 Dylan baker.dyla...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #1 from Dylan baker.dyla...@gmail.com --- This isn't actually a bug. What's happening is that 'piglit run' and 'piglit summary' are counting two different things. Piglit run counts the number of tests as defined in the profile (in your case tests/all.py), it counts them up and sees that there are 28030 Test derived objects in the python file. Piglit summary counts the number of tests + subtests as a total (tests with subtests are treated as a group rather than as a test), so while there were 28030 Test.run() calls, there were actually 28904 test + subtest results generated. There is no way for the runner to know if a test has subtests or how many it has until it has finished running that test; and I prefer to keep the number of tests counted deterministic at start time (ie, not changing as the run goes, which would be confusing when running a summary against two incomplete results). I've attached a very simple results file that hopefully will make it clearer how this works. I'll also send a patch that updates the README file with this information. Sorry for the confusion. -- You are receiving this mail because: You are the QA Contact for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] README: add a note about the test counts
It's worth noting that piglit run and piglit summary count tests differently. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README | 9 + 1 file changed, 9 insertions(+) diff --git a/README b/README index 773a350..8381ff4 100644 --- a/README +++ b/README @@ -274,6 +274,15 @@ The summary shows the 'status' of a test: There are also dmesg-* statuses. These have the same meaning as above, but are triggered by dmesg related messages. +3.1 Note + + +The way 'piglit run' and 'piglit summary' count tests are different, 'piglit +run' counts the number of Test derived instance in the profile(s) selected, +while 'piglit summary' counts the number of subtests a result contains, or it's +result if there are no subtests. This means that the number shown by 'piglit +run' and the total as calculated by 'piglit summary' may not match. + 4. Available test sets -- -- 2.5.0 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 91670] [bisected] piglit.spec.!opengl 3_2.layered-rendering.framebuffertexture fails
https://bugs.freedesktop.org/show_bug.cgi?id=91670 Timothy Arceri t_arc...@yahoo.com.au changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Timothy Arceri t_arc...@yahoo.com.au --- Fix pushed to piglit. authorTimothy Arceri t_arc...@yahoo.com.au2015-08-18 04:34:14 (GMT) committerTimothy Arceri t_arc...@yahoo.com.au2015-08-18 23:56:03 (GMT) commitb4b8c87ea78a53673c52d06af5abb5b7b263ddc9 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 91680] New: Different stats in output reports
https://bugs.freedesktop.org/show_bug.cgi?id=91680 Bug ID: 91680 Summary: Different stats in output reports Product: piglit Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: infrastructure Assignee: baker.dyla...@gmail.com Reporter: christophe.prig...@intel.com QA Contact: piglit@lists.freedesktop.org Created attachment 117768 -- https://bugs.freedesktop.org/attachment.cgi?id=117768action=edit results.json.bz2 Linux distribution: Ubuntu 14.04 LTS 64 bits piglit: (HEAD, origin/master, origin/HEAD, master) 846755508ac44924b154a280e7a84c8004b6b085 from git://git.freedesktop.org/git/piglit Steps: -- 1. Execute command: ./piglit run tests/all results/all-reference 2. Wait the result 3. Execute command: ./piglit summary console results/all2 4. Compare the stats Actual result: -- 2. Piglit reports: [28030/28030] crash: 26, fail: 135, pass: 18692, skip: 9174, warn: 3 - Thank you for running Piglit! 3. Summary is: pass: 28904 fail: 164 crash: 26 skip: 9457 timeout: 0 warn: 3 incomplete: 0 dmesg-warn: 0 dmesg-fail: 0 total: 38554 4. Numbers are different (example: 135 fail vs 164) Info: -- Same problem when generating an HTML or a CVS report, numbers are again different. -- You are receiving this mail because: You are the QA Contact for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
