[Piglit] [PATCH v2] cl-api-enqueue-fill-image: Fix memory leaks.

2015-11-22 Thread Vinson Lee 
Fixes Coverity "resource leak" defects.

Suggested-by: Serge Martin 
Signed-off-by: Vinson Lee 
---
 tests/cl/api/enqueue-fill-image.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/cl/api/enqueue-fill-image.c 
b/tests/cl/api/enqueue-fill-image.c
index ebcfba4..2839b67 100644
--- a/tests/cl/api/enqueue-fill-image.c
+++ b/tests/cl/api/enqueue-fill-image.c
@@ -114,6 +114,9 @@ piglit_cl_test(const int argc,
return PIGLIT_SKIP;
}
 
+   free(image_support);
+   image_support = NULL;
+
img_format.image_channel_order = CL_RGBA;
img_format.image_channel_data_type = CL_UNSIGNED_INT8;
img_desc.image_type = CL_MEM_OBJECT_IMAGE2D;
@@ -325,7 +328,6 @@ piglit_cl_test(const int argc,
 */
/* This is a per device test, clCreateImage would have failed before */
 
-   free(image_support);
clReleaseMemObject(image);
return result;
 #else
-- 
2.6.3

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] non-concurrent piglit tests

2015-11-22 Thread Eric Anholt 
Ilia Mirkin  writes:

> It looks like we're up to something like 1K non-concurrent piglit
> tests... maybe more. Can someone who actually understands the issues
> explain what makes a piglit test unreliable when run concurrently with
> another test? Then we can go and enable concurrency on probably 75% of
> the currently-marked-nonconcurrent tests.

It's mostly us being conservative, historically.  We were scared to turn
it on for everything because of DRI1 buffer sharing , and just did it
for compiler tests first.  Then I moved shader_runner to do things to
fbos instead of windows and set a bunch of those to concurrent.  Then we
added more, etc.

It turns out we haven't really had any problems with concurrent being
set, so we should probably just set it on for everything and see if
anything even breaks.


signature.asc
Description: PGP signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH V5 2/2] SSO: new test to ensure matching with various qualifier

2015-11-22 Thread Gregory Hainaut 
Test is composed of 2 major steps.

First part ensure that a matching (same on both VS & FS) qualifier doesn't
pertubate the location assignment

Second part ensure that a non-matching qualifier also work. Final interpolation
qualifier is the one of the FS.
Technically it is only allowed from GLSL4.5. However I don't know if any gl
implementation really implement this constraint.

v5:
* rely on pick_a_glsl_version (sso-common)
* Update test description

v2: add the test to all.py

Reviewed-by: Timothy Arceri 
Signed-off-by: Gregory Hainaut 
---
 tests/all.py   |   2 +
 .../arb_separate_shader_objects/CMakeLists.gl.txt  |   1 +
 .../rendezvous_by_name_interpolation.c | 207 +
 3 files changed, 210 insertions(+)
 create mode 100644 
tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c

diff --git a/tests/all.py b/tests/all.py
index c9b4ffa..21bee3d 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -2152,6 +2152,8 @@ with profile.group_manager(
   'ProgramUniform coverage')
 g(['arb_separate_shader_object-rendezvous_by_name'],
   'Rendez vous by name')
+g(['arb_separate_shader_object-rendezvous_by_name_interpolation'],
+  'Rendez vous by name with multiple interpolation qualifier')
 g(['arb_separate_shader_object-rendezvous_by_location', '-fbo'],
   'Rendezvous by location', run_concurrent=False)
 g(['arb_separate_shader_object-rendezvous_by_location-5-stages'],
diff --git a/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt 
b/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
index 3957409..1dc5f14 100644
--- a/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
+++ b/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
@@ -19,5 +19,6 @@ piglit_add_executable 
(arb_separate_shader_object-rendezvous_by_location rendezv
 piglit_add_executable 
(arb_separate_shader_object-rendezvous_by_location-3-stages 
rendezvous_by_location-3-stages.c)
 piglit_add_executable 
(arb_separate_shader_object-rendezvous_by_location-5-stages 
rendezvous_by_location-5-stages.c)
 piglit_add_executable (arb_separate_shader_object-rendezvous_by_name 
rendezvous_by_name.c sso-common.c)
+piglit_add_executable 
(arb_separate_shader_object-rendezvous_by_name_interpolation 
rendezvous_by_name_interpolation.c sso-common.c)
 piglit_add_executable 
(arb_separate_shader_object-UseProgramStages-non-separable 
UseProgramStages-non-separable.c)
 piglit_add_executable (arb_separate_shader_object-ValidateProgramPipeline 
ValidateProgramPipeline.c)
diff --git 
a/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c 
b/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
new file mode 100644
index 000..98d3f43
--- /dev/null
+++ b/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
@@ -0,0 +1,207 @@
+/*
+ * Copyright © 2015 Gregory Hainaut 
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file rendezvous_by_name_interpolation.c
+ * Simple test for separate shader objects that use rendezvous-by-name.
+ *
+ * This test ensures that multiple interpolation qualifiers don't break
+ * interface matching.
+ *
+ * We first test matching of a VS and FS with matching interpolation
+ * qualifiers. Next we ensure that non-matching interpolation qualifiers
+ * also work. Technically interpolation mismatching is only allowed
+ * starting with GLSL 4.5 however its unlikely any implementation inforces
+ * this constraint.
+ */
+#include "piglit-util-gl.h"
+#include "sso-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+   config.supports_gl_compat_version = 10;
+   config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+static GLuint pipeline_match[4];

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-22 Thread Vinson Lee 
On Wed, Nov 11, 2015 at 10:07 AM, Emil Velikov  wrote:
> From: Emil Velikov 
>
> Noticed as some of these have been intermittently failing on llvmpipe,
> resulting in a few "not run" test across mesa release checks.
>
> Signed-off-by: Emil Velikov 
> ---
>
> XXX:
> At some point we'd want to do a tree-wide:
>  - s/GLboolean pass/bool pass/
>  - s/pass = pass && foo/pass &= foo/
>  - s/pass = foo && pass/pass &= foo/
>
> We might want to convert the test to use the piglit_probe_pixels over
> it's custom ones.
>
> -Emil
>
>  tests/texturing/texwrap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/texturing/texwrap.c b/tests/texturing/texwrap.c
> index fbe9068..60ffa73 100644
> --- a/tests/texturing/texwrap.c
> +++ b/tests/texturing/texwrap.c
> @@ -1134,7 +1134,7 @@ static GLboolean test_format_npot(const struct 
> format_desc *format, GLboolean np
>  * It has to be enabled on the command line.
>  */
> if (!texture_swizzle && !npot && !test_border_color && 
> has_texture_swizzle) {
> -   pass = pass && test_format_npot_swizzle(format, npot, 
> 1);
> +   pass = test_format_npot_swizzle(format, npot, 1) && 
> pass;
> }
> }
> return pass;
> @@ -1149,7 +1149,7 @@ static GLboolean test_format(const struct format_desc 
> *format)
> } else {
> pass = test_format_npot(format, 0);
> if (has_npot && !test_border_color) {
> -   pass = pass && test_format_npot(format, 1);
> +   pass = test_format_npot(format, 1) && pass;
> }
> }
> return pass;
> @@ -1163,7 +1163,7 @@ enum piglit_result piglit_display()
> pass = test_format(init_format ? init_format : 
> >format[0]);
> } else {
> if (init_format) {
> -   pass = pass && test_format(init_format);
> +   pass = test_format(init_format) && pass;
> } else {
> int i;
> for (i = 0; i < test->num_formats; i++) {
> --
> 2.6.2
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Vinson Lee 
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] non-concurrent piglit tests

2015-11-22 Thread Ilia Mirkin 
On Sun, Nov 22, 2015 at 7:12 PM, Eric Anholt  wrote:
> Ilia Mirkin  writes:
>
>> It looks like we're up to something like 1K non-concurrent piglit
>> tests... maybe more. Can someone who actually understands the issues
>> explain what makes a piglit test unreliable when run concurrently with
>> another test? Then we can go and enable concurrency on probably 75% of
>> the currently-marked-nonconcurrent tests.
>
> It's mostly us being conservative, historically.  We were scared to turn
> it on for everything because of DRI1 buffer sharing , and just did it
> for compiler tests first.  Then I moved shader_runner to do things to
> fbos instead of windows and set a bunch of those to concurrent.  Then we
> added more, etc.
>
> It turns out we haven't really had any problems with concurrent being
> set, so we should probably just set it on for everything and see if
> anything even breaks.

It looks like we only add -auto to all piglits. Should we be adding
-fbo -auto instead so that an fbo is bound to a drawbuffer? Presumably
it falls back on regular winsys when EXT_framebuffer_object is not
supported...

  -ilia
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

2015-11-22 Thread Emil Velikov 
On 18 November 2015 at 20:59, Dave Airlie  wrote:
> On 19 November 2015 at 02:05, Emil Velikov  wrote:
>> On 17 November 2015 at 15:25, Samuel Pitoiset  
>> wrote:
>>> piglit_require_GLSL_version() requires an integer as parameter, not a float.
>>> This fixes an implicit conversion spotted by Clang.
>>>
>>> Signed-off-by: Samuel Pitoiset 
>>> ---
>>>  .../arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c  | 
>>> 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>>>  
>>> b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>>> index ff4b0e0..36b0a2d 100644
>>> --- 
>>> a/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>>> +++ 
>>> b/tests/spec/arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c
>>> @@ -115,7 +115,7 @@ piglit_init(int argc, char **argv)
>>> int i;
>>>
>>> /* Set up test */
>>> -   piglit_require_GLSL_version(1.50);
>>> +   piglit_require_GLSL_version(150);
>> I felt bored for a few minutes and had a quick look at the whole of
>> piglit. This is the only case where we implicitly or explicitly try to
>> feed an incorrect value (float in this case) into
>> piglit_require_GLSL_version().
>
> Do I win a prize? :-P

Sure thing. Leaning towards "have a potato", as you have dozens of
gadgets around already ;-)

-Emil

P.S. No ill intent, picked this up from an Irish friend who uses it
quite heavily.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [Bug 93064] New: no generated_tests for CL

2015-11-22 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=93064

Bug ID: 93064
   Summary: no generated_tests for CL
   Product: piglit
   Version: unspecified
  Hardware: Other
OS: All
Status: NEW
  Severity: normal
  Priority: medium
 Component: infrastructure
  Assignee: baker.dyla...@gmail.com
  Reporter: i.gnatenko.br...@gmail.com
QA Contact: piglit@lists.freedesktop.org

$ piglit run quick_cl results/quick_cl
Warning: A python exception that should have been handled was not. This is bug
and should be reported.
BUG: [Errno 2] No such file or directory:
'/usr/lib64/piglit/generated_tests/cl/builtin/int'

I see only:
-- Installing:
/builddir/build/BUILDROOT/piglit-1.0.20151122-1.gitd095ba0.fc24.x86_64/usr/lib64/piglit/generated_tests/cl
-- Installing:
/builddir/build/BUILDROOT/piglit-1.0.20151122-1.gitd095ba0.fc24.x86_64/usr/lib64/piglit/generated_tests/cl/store
-- Installing:
/builddir/build/BUILDROOT/piglit-1.0.20151122-1.gitd095ba0.fc24.x86_64/usr/lib64/piglit/generated_tests/cl/store/store-kernels-local.inc
-- Installing:
/builddir/build/BUILDROOT/piglit-1.0.20151122-1.gitd095ba0.fc24.x86_64/usr/lib64/piglit/generated_tests/cl/store/store-kernels-global.inc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] texwrap: do no short circuit remaining tests if one fails

2015-11-22 Thread Emil Velikov 
On 11 November 2015 at 18:07, Emil Velikov  wrote:
> From: Emil Velikov 
>
> Noticed as some of these have been intermittently failing on llvmpipe,
> resulting in a few "not run" test across mesa release checks.
>
> Signed-off-by: Emil Velikov 
> ---
>
> XXX:
> At some point we'd want to do a tree-wide:
>  - s/GLboolean pass/bool pass/
>  - s/pass = pass && foo/pass &= foo/
>  - s/pass = foo && pass/pass &= foo/
>
> We might want to convert the test to use the piglit_probe_pixels over
> it's custom ones.
>
> -Emil
>
>  tests/texturing/texwrap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/texturing/texwrap.c b/tests/texturing/texwrap.c
> index fbe9068..60ffa73 100644
> --- a/tests/texturing/texwrap.c
> +++ b/tests/texturing/texwrap.c
> @@ -1134,7 +1134,7 @@ static GLboolean test_format_npot(const struct 
> format_desc *format, GLboolean np
>  * It has to be enabled on the command line.
>  */
> if (!texture_swizzle && !npot && !test_border_color && 
> has_texture_swizzle) {
> -   pass = pass && test_format_npot_swizzle(format, npot, 
> 1);
> +   pass = test_format_npot_swizzle(format, npot, 1) && 
> pass;
> }
> }
> return pass;
> @@ -1149,7 +1149,7 @@ static GLboolean test_format(const struct format_desc 
> *format)
> } else {
> pass = test_format_npot(format, 0);
> if (has_npot && !test_border_color) {
> -   pass = pass && test_format_npot(format, 1);
> +   pass = test_format_npot(format, 1) && pass;
> }
> }
> return pass;
> @@ -1163,7 +1163,7 @@ enum piglit_result piglit_display()
> pass = test_format(init_format ? init_format : 
> >format[0]);
> } else {
> if (init_format) {
> -   pass = pass && test_format(init_format);
> +   pass = test_format(init_format) && pass;
> } else {
> int i;
> for (i = 0; i < test->num_formats; i++) {
> --
Any takers on this trivial patch ? I guess we can bikeshed the "pass =
foo && pass" vs "pass &= foo" at a later stage.

-Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] cl-api-enqueue-fill-image: Fix memory leaks.

2015-11-22 Thread Serge Martin 
I think we can

free(image_support):
image_suppot = NULL;

 right after the test

if (!*image_support) {
fprintf(stderr, "No image support\n");
free(image_support);
return PIGLIT_SKIP;
}

that would avoid the need to add it in every PIGLIT_FAIL return;

Serge

On Monday 16 November 2015 23:48:14 Vinson Lee wrote:
> Fixes Coverity "resource leak" defects.
> 
> Signed-off-by: Vinson Lee 
> ---
>  tests/cl/api/enqueue-fill-image.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/cl/api/enqueue-fill-image.c
> b/tests/cl/api/enqueue-fill-image.c index ebcfba4..994ccb4 100644
> --- a/tests/cl/api/enqueue-fill-image.c
> +++ b/tests/cl/api/enqueue-fill-image.c
> @@ -129,12 +129,14 @@ piglit_cl_test(const int argc,
>   if(!piglit_cl_check_error(err, CL_SUCCESS)) {
>   fprintf(stderr, "Failed (error code: %s): Creating an image\n",
>   piglit_cl_get_error_name(err));
> + free(image_support);
>   return PIGLIT_FAIL;
>   }
> 
>   if (!test(queue, image, pattern, origin, region,
> 0, NULL, NULL,
> CL_SUCCESS, , "Enqueuing the image to be filled")) {
> + free(image_support);
>   return PIGLIT_FAIL;
>   }
> 
> @@ -145,6 +147,7 @@ piglit_cl_test(const int argc,
>   if(!piglit_cl_check_error(err, CL_SUCCESS)) {
>   fprintf(stderr, "Failed (error code: %s): Reading image\n",
>   piglit_cl_get_error_name(err));
> + free(image_support);
>   return PIGLIT_FAIL;
>   }
> 
> @@ -169,6 +172,7 @@ piglit_cl_test(const int argc,
>   if (!piglit_cl_probe_integer(dst_buf[i], exp_buf[i], 0)) {
>   fprintf(stderr, "Error at %d: got %d, expected %d\n",
>   i, dst_buf[i], exp_buf[i]);
> + free(image_support);
>   return PIGLIT_FAIL;
>   }
>   }

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] SSO: new test to ensure matching with various qualifier

2015-11-22 Thread Timothy Arceri 
On Tue, 2015-11-03 at 20:09 +0100, Gregory Hainaut wrote:
> Test is composed of 2 major steps.
> 
> First part ensure that a matching (same on both VS & FS) qualifier doesn't
> pertubate the location assignment
> 
> Second part ensure that a non-matching qualifier also work. Final
> interpolation
> qualifier is the one of the FS.
> Technically it is only allowed from GLSL4.5. However I don't know if any gl
> implementation really implement this constraint.
> 
> v2: add the test to all.py
> Signed-off-by: Gregory Hainaut 
> ---
>  tests/all.py   |   2 +
>  .../arb_separate_shader_objects/CMakeLists.gl.txt  |   1 +
>  .../rendezvous_by_name_interpolation.c | 210
> +
>  3 files changed, 213 insertions(+)
>  create mode 100644
> tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
> 
> diff --git a/tests/all.py b/tests/all.py
> index 35c330b..585e39d 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -2147,6 +2147,8 @@ with profile.group_manager(
>'ProgramUniform coverage')
>  g(['arb_separate_shader_object-rendezvous_by_name'],
>'Rendez vous by name')
> +g(['arb_separate_shader_object-rendezvous_by_name_interpolation'],
> +  'Rendez vous by name with multiple interpolation qualifier')
>  g(['arb_separate_shader_object-rendezvous_by_location', '-fbo'],
>'Rendezvous by location', run_concurrent=False)
>  g(['arb_separate_shader_object-rendezvous_by_location-5-stages'],
> diff --git a/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
> b/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
> index 9ab6606..22a04b7 100644
> --- a/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
> +++ b/tests/spec/arb_separate_shader_objects/CMakeLists.gl.txt
> @@ -19,5 +19,6 @@ piglit_add_executable (arb_separate_shader_object
> -rendezvous_by_location rendezv
>  piglit_add_executable (arb_separate_shader_object-rendezvous_by_location-3
> -stages rendezvous_by_location-3-stages.c)
>  piglit_add_executable (arb_separate_shader_object-rendezvous_by_location-5
> -stages rendezvous_by_location-5-stages.c)
>  piglit_add_executable (arb_separate_shader_object-rendezvous_by_name
> rendezvous_by_name.c)
> +piglit_add_executable (arb_separate_shader_object
> -rendezvous_by_name_interpolation rendezvous_by_name_interpolation.c)
>  piglit_add_executable (arb_separate_shader_object-UseProgramStages-non
> -separable UseProgramStages-non-separable.c)
>  piglit_add_executable (arb_separate_shader_object-ValidateProgramPipeline
> ValidateProgramPipeline.c)
> diff --git
> a/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
> b/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
> new file mode 100644
> index 000..5a99871
> --- /dev/null
> +++
> b/tests/spec/arb_separate_shader_objects/rendezvous_by_name_interpolation.c
> @@ -0,0 +1,210 @@
> +/*
> + * Copyright © 2015 Gregory Hainaut 
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the
> "Software"),
> + * to deal in the Software without restriction, including without
> limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the
> next
> + * paragraph) shall be included in all copies or substantial portions of
> the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/**
> + * \file rendezvous_by_name_interpolation.c
> + * Simple test for separate shader objects that use rendezvous-by-name.
> + *
> + * The test ensures that multiple interpolation qualifier doesn't break
> + * the interface matching.

I suggest some rewording of the above and adding more information taken from
the commit message.

* Simple test for separate shader objects that use rendezvous-by-name.
*
* This test ensures that multiple interpolation qualifiers don't break
* interface matching.
*
* We first test matching of a VS and FS with matching interpolation
* qualifiers. Next we ensure that non-matching interpolation qualifiers
* also work. Technically interpolation mismatching is only allowed 
* starting with GLSL 4.5 however its