Re: [Piglit] [PATCH] Add test-list after resume test
Quoting Rami Ben Hassine (2016-11-18 04:53:41) > Hello all, > > Actually piglit don’t use the test-list option if we reboot (for x resons) > and want to resume a test , note that is not related to suspend test. This is not a good commit message. A commit message should explain the change, and the reason for the change. Consider something like: Sometimes we want to resume an interrupted run which was started with --test-list. Currently piglit does not support --test-list with resume, this patch adds support for the option to piglit resume. > > --- > framework/programs/run.py | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/framework/programs/run.py b/framework/programs/run.py > index e5d5583..2a11288 100644 > --- a/framework/programs/run.py > +++ b/framework/programs/run.py > @@ -228,6 +228,7 @@ def _create_metadata(args, name): > opts['concurrent'] = args.concurrency > opts['include_filter'] = args.include_tests > opts['exclude_filter'] = args.exclude_tests > +opts['test_list']= args.test_list I think it would be better to actually store the processed testlist in the metadata rather than re-opening and re-reading the list (imagine that the list was generated by another script), and then pass that into _create_metadata instaed of using args.test_list. That would mean that resume wouldn't need to be passed --test-list at all, it would just automatically resume. One of the promises of piglit resume is that it doesn't change anything about how the run was started, so I think we should store the test_list and resume it. > opts['dmesg'] = args.dmesg > opts['monitoring'] = args.monitored > if args.platform: > @@ -423,6 +424,12 @@ def resume(input_): > if results.options['include_filter']: > p.filters.append( > profile.RegexFilter(results.options['include_filter'])) > +# If a test list is provided then set the forced_test_list value. > +if results.options['test_list']: > + with open(results.options['test_list']) as test_list: > +# Strip newlines The indentation on this comment looks wrong > + profiles[0].forced_test_list = [t.strip() for t in test_list] > + > > # This is resumed, don't bother with time since it won't be accurate > anyway > profile.run( > -- > 2.7.4 > > - > Intel Corporation SAS (French simplified joint stock company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > 92196 Meudon Cedex, France > Registration Number: 302 456 199 R.C.S. NANTERRE > Capital: 4,572,000 Euros > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 98769] New: Build broken: piglit needs to link against libwaylandclient
https://bugs.freedesktop.org/show_bug.cgi?id=98769 Bug ID: 98769 Summary: Build broken: piglit needs to link against libwaylandclient Product: piglit Version: unspecified Hardware: All OS: Linux (All) Status: NEW Severity: blocker Priority: medium Component: infrastructure Assignee: lem...@gmail.com Reporter: mark.a.ja...@intel.com QA Contact: piglit@lists.freedesktop.org series ending in: 2881f72d6b55864ceaeb2a7acf38bd28b3850139 Author: Tapani Pälli util: implement eventloop for wayland platform fails linking: lib/libpiglitutil_gl.so.0: undefined reference to `wl_keyboard_interface' Adding -lwayland-client on the command line links the library. -- You are receiving this mail because: You are the QA Contact for the bug.___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH v2 0/2] eventloop for Wayland platform
This series breaks my compilation: gcc -m64 -Wall -std=gnu99 -Werror=vla -Werror=pointer-arith -Werror=variadic-macros -g target_api/gl/tests/bugs/CMakeFiles/point-sprite.dir/point-sprite.c.o -o bin/point-sprite -rdynamic lib/libpiglitutil_gl.so.0 -lGL lib/libpiglitutil.so.0 -lrt -ldl -lxkbcommon -lpng -lz -lm -lEGL -L/tmp/build_root/m64/lib -lgbm -L/tmp/build_root/m64/lib/x86_64-linux-gnu -lwaffle-1 -ldrm -lxcb -lxcb-dri2 -ldrm_intel -ldrm -lxcb -lxcb-dri2 -ldrm_intel -lX11 -lGL -Wl,-rpath,/home/majanes/src/jenkins/repos/piglit/build_m64/lib: && : lib/libpiglitutil_gl.so.0: undefined reference to `wl_keyboard_interface' lib/libpiglitutil_gl.so.0: undefined reference to `wl_display_dispatch' adding -lwayland-client gets the link working. -Mark Tapani Pälli writes: > Round 2 *gonggg* > > Here's another try to implement eventloop for Wayland. I've done fixes > based on Pekka's review. I did not attempt to support multiseat or multiple > keyboards, such configurations are considered exotic for running Piglit and > support can be added later. Main thing is to try to be consistent with > existing X11 backend. > > Thanks; > > Tapani Pälli (2): > cmake: require libxkbcommon when building with Wayland > util: implement eventloop for wayland platform > > CMakeLists.txt | 7 + > tests/util/CMakeLists.txt | 5 + > .../util/piglit-framework-gl/piglit_wl_framework.c | 253 > +++-- > 3 files changed, 249 insertions(+), 16 deletions(-) > > -- > 2.7.4 > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] Add test-list after resume test
Hello all, Actually piglit don’t use the test-list option if we reboot (for x resons) and want to resume a test , note that is not related to suspend test. --- framework/programs/run.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/framework/programs/run.py b/framework/programs/run.py index e5d5583..2a11288 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -228,6 +228,7 @@ def _create_metadata(args, name): opts['concurrent'] = args.concurrency opts['include_filter'] = args.include_tests opts['exclude_filter'] = args.exclude_tests +opts['test_list']= args.test_list opts['dmesg'] = args.dmesg opts['monitoring'] = args.monitored if args.platform: @@ -423,6 +424,12 @@ def resume(input_): if results.options['include_filter']: p.filters.append( profile.RegexFilter(results.options['include_filter'])) +# If a test list is provided then set the forced_test_list value. +if results.options['test_list']: + with open(results.options['test_list']) as test_list: +# Strip newlines + profiles[0].forced_test_list = [t.strip() for t in test_list] + # This is resumed, don't bother with time since it won't be accurate anyway profile.run( -- 2.7.4 - Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
