Re: [Piglit] [PATCH] GL_ARB_draw_instanced/dlist: Fix crash
arthur.huil...@free.fr writes: > From: Arthur Huillet > > The test was passing a NULL indices pointer without an element buffer bound. > Nothing in the GL spec requires a NULL check, so drivers were free to crash > before checking the error condition that the test attempts to check. Fix this > by passing an index buffer. > > Also swap vertex counts and instance counts, which I suspect were mixed up in > the test author's head. That part is strictly cosmetic and has no functional > impact. Pushed. Thanks! signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] fbo-maxsize: Try to avoid allocating miplevels.
On Monday, December 12, 2016 10:14:35 AM PST Eric Anholt wrote: > Kenneth Graunke writes: > > > A 16384x16384 RGBA buffer takes 1GB of RAM. If the driver allocates > > mipmap levels, that increases our storage requirements to 1.5GB. The > > test doesn't use mipmapping, so this seems like a waste. > > > > Disabling mipmap filtering before allocating the texture provides a hint > > to the driver, suggesting that it should only allocate space for the > > base level. Most Mesa drivers (Gallium and i965) follow this practice. > > > > Signed-off-by: Kenneth Graunke > > It would probably be good for coverage if the fbo-maxsize test tested > that you could render all the way down the miptree of a maximum-sized > FBO, but given that it doesnt, this is: > > Reviewed-by: Eric Anholt > Thanks! I screwed up and missed applying the Reviewed-by tag, and apparently Piglit doesn't allow non-fast-forward pushes (like Mesa), so I can't fix it. Sorry :( signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] fbo-maxsize: Try to avoid allocating miplevels.
Kenneth Graunke writes: > A 16384x16384 RGBA buffer takes 1GB of RAM. If the driver allocates > mipmap levels, that increases our storage requirements to 1.5GB. The > test doesn't use mipmapping, so this seems like a waste. > > Disabling mipmap filtering before allocating the texture provides a hint > to the driver, suggesting that it should only allocate space for the > base level. Most Mesa drivers (Gallium and i965) follow this practice. > > Signed-off-by: Kenneth Graunke It would probably be good for coverage if the fbo-maxsize test tested that you could render all the way down the miptree of a maximum-sized FBO, but given that it doesnt, this is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
