On Tue, 2017-03-07 at 13:20 -0800, Francisco Jerez wrote: > Andres Gomez <ago...@igalia.com> writes: > > > This adds a test to check that a link error is expected when > > specifying different binding points among compilation units for atomic > > counters with the same name. > > > > From the ARB_shader_atomic_counters spec: > > > > " It is legal for some shaders to provide a layout qualifier for a > > uniform variable of the same name, while another shader does not > > provide a layout qualifier for a uniform variable of the same > > name, but if provided, all provided layout qualifiers must be > > equal for a uniform variable of the same name, and if not > > provided, all implicitly provided layout qualifiers must be equal > > for a uniform variable of the same name." > > > > v2: Added GL minimum version restriction. > > > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > Cc: Francisco Jerez <curroje...@riseup.net> > > Cc: Ian Romanick <ian.d.roman...@intel.com> > > --- > > .../different-bindings-atomic-counter.shader_test | 51 > > ++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 > > tests/spec/arb_shader_atomic_counters/linker/different-bindings-atomic-counter.shader_test > > > > diff --git > > a/tests/spec/arb_shader_atomic_counters/linker/different-bindings-atomic-counter.shader_test > > > > b/tests/spec/arb_shader_atomic_counters/linker/different-bindings-atomic-counter.shader_test > > new file mode 100644 > > index 000000000..b331650cc > > --- /dev/null > > +++ > > b/tests/spec/arb_shader_atomic_counters/linker/different-bindings-atomic-counter.shader_test > > @@ -0,0 +1,51 @@ > > +/* The ARB_shader_atomic_counters says: > > + * > > + * "It is legal for some shaders to provide a layout qualifier for > > + * a uniform variable of the same name, while another shader does > > + * not provide a layout qualifier for a uniform variable of the > > + * same name, but if provided, all provided layout qualifiers > > + * must be equal for a uniform variable of the same name, and if > > + * not provided, all implicitly provided layout qualifiers must > > + * be equal for a uniform variable of the same name." > > + * > > + * Verify that a link error happens when using different binding > > + * points for an atomic counter with the same name in different > > + * compilation units. > > + */ > > + > > +[require] > > +GL >= 3.00 > > The GL version specification seems inconsistent with the GLSL version > specified below, I think you want to ask for 3.1 here, with that fixed:
Thanks! Updated and pushed ☺ -- Br, Andres _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit