Re: [Piglit] [PATCH 0/2] Rewind the changes to the Khronos GL CTS profiles

2017-06-06 Thread Marek Olšák 
Acked-by: Marek Olšák 

Marek

On Tue, Jun 6, 2017 at 6:08 PM, Andres Gomez  wrote:
> Recently I added some changes in the cts_gl* profiles to adapt to
> renames in the opensourced Khronos CTS at:
> https://github.com/KhronosGroup/VK-GL-CTS
>
> Unfortunately, I didn't foresee that this change would break backward
> compatibility with previous CTS releases and with branches created for
> API-specific release, as explained at:
> https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches
>
> Now, we revert the changes and provide 2 new profiles to use with the
> renamed tests.
>
> Andres Gomez (2):
>   Revert "tests: Update integration for khronos CTS runner."
>   tests: Added a couple of new test profies for the Khronos CTS runner
>
>  tests/cts_gl.py   | 20 ++--
>  tests/cts_gl45.py |  2 +-
>  tests/khr_gl.py   | 93 
> +++
>  tests/khr_gl45.py | 69 +
>  4 files changed, 173 insertions(+), 11 deletions(-)
>  create mode 100644 tests/khr_gl.py
>  create mode 100644 tests/khr_gl45.py
>
> --
> 2.11.0
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 0/2] Rewind the changes to the Khronos GL CTS profiles

2017-06-06 Thread Mark Janes 
Tested-by: Mark Janes 

Andres Gomez  writes:

> Recently I added some changes in the cts_gl* profiles to adapt to
> renames in the opensourced Khronos CTS at:
> https://github.com/KhronosGroup/VK-GL-CTS
>
> Unfortunately, I didn't foresee that this change would break backward
> compatibility with previous CTS releases and with branches created for
> API-specific release, as explained at:
> https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches
>
> Now, we revert the changes and provide 2 new profiles to use with the
> renamed tests.
>
> Andres Gomez (2):
>   Revert "tests: Update integration for khronos CTS runner."
>   tests: Added a couple of new test profies for the Khronos CTS runner
>
>  tests/cts_gl.py   | 20 ++--
>  tests/cts_gl45.py |  2 +-
>  tests/khr_gl.py   | 93 
> +++
>  tests/khr_gl45.py | 69 +
>  4 files changed, 173 insertions(+), 11 deletions(-)
>  create mode 100644 tests/khr_gl.py
>  create mode 100644 tests/khr_gl45.py
>
> -- 
> 2.11.0
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] Revert "tests: Update integration for khronos CTS runner."

2017-06-06 Thread Andres Gomez 
This reverts commit 1f93e29d853c0dc9ee1a22bb7e6366b6eb8d5ac7.

This broke backwards compatibility with already released API-specific
test sets.

Signed-off-by: Andres Gomez 
---
 tests/cts_gl.py   | 20 ++--
 tests/cts_gl45.py |  2 +-
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/tests/cts_gl.py b/tests/cts_gl.py
index a40b0b369..d650ffd4b 100644
--- a/tests/cts_gl.py
+++ b/tests/cts_gl.py
@@ -69,24 +69,24 @@ class DEQPCTSTest(deqp.DEQPBaseTest):
 profile = deqp.make_profile(  # pylint: disable=invalid-name
 itertools.chain(
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL30-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL30-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL31-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL31-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL32-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL32-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL33-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL33-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL40-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL40-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL41-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL41-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL42-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL42-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL43-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL43-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL44-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL44-CTS-cases.txt', 
_EXTRA_ARGS)),
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL45-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL45-CTS-cases.txt', 
_EXTRA_ARGS)),
 ),
 DEQPCTSTest)
diff --git a/tests/cts_gl45.py b/tests/cts_gl45.py
index 580c8760a..2782e18f4 100644
--- a/tests/cts_gl45.py
+++ b/tests/cts_gl45.py
@@ -63,6 +63,6 @@ class DEQPCTSTest(deqp.DEQPBaseTest):
 profile = deqp.make_profile(  # pylint: disable=invalid-name
 itertools.chain(
 deqp.iter_deqp_test_cases(
-deqp.gen_caselist_txt(_CTS_BIN, 'KHR-GL45-cases.txt', 
_EXTRA_ARGS)),
+deqp.gen_caselist_txt(_CTS_BIN, 'GL45-CTS-cases.txt', 
_EXTRA_ARGS)),
 ),
 DEQPCTSTest)
-- 
2.11.0

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 0/2] Rewind the changes to the Khronos GL CTS profiles

2017-06-06 Thread Andres Gomez 
Recently I added some changes in the cts_gl* profiles to adapt to
renames in the opensourced Khronos CTS at:
https://github.com/KhronosGroup/VK-GL-CTS

Unfortunately, I didn't foresee that this change would break backward
compatibility with previous CTS releases and with branches created for
API-specific release, as explained at:
https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches

Now, we revert the changes and provide 2 new profiles to use with the
renamed tests.

Andres Gomez (2):
  Revert "tests: Update integration for khronos CTS runner."
  tests: Added a couple of new test profies for the Khronos CTS runner

 tests/cts_gl.py   | 20 ++--
 tests/cts_gl45.py |  2 +-
 tests/khr_gl.py   | 93 +++
 tests/khr_gl45.py | 69 +
 4 files changed, 173 insertions(+), 11 deletions(-)
 create mode 100644 tests/khr_gl.py
 create mode 100644 tests/khr_gl45.py

-- 
2.11.0

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v3] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. Accord

2017-06-06 Thread Józef Kucia 
On Thu, Jun 1, 2017 at 1:11 PM, sandra koroniewska
 wrote:
> Hi,
> this change fixes a real problem for me (a crash on an Intel driver).
> I don't know if I understand this right, but for glPixelMap there is written
> in a spec (core 2.1, page 117): "If a pixel unpack buffer is bound (as
> indicated by a non-zero value of PIXEL UNPACK BUFFER BINDING), values is an
> offset into the pixel unpack buffer; otherwise, values is a pointer to
> client memory"
>
> There is a call after glUnmapBuffer:
> glPixelMapusv(GL_PIXEL_MAP_R_TO_R, max, NULL);
>
> So I understand that this "NULL" is an offset into the pixel unpack buffer,
> because it doesn't look like a pointer to client memory. But when I unmap
> it, the pointer is invalid, so there is a crash in this function.
> Tell me if I'm wrong, but I'm not sure if pbo_mem is not used.

PIXEL UNPACK BUFFER BINDING is changed using glBindBuffer() command.
glUnmapBuffer() does not modify buffer bindings.
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] khr_texture_compression_astc: change the subtest array declaration to prevent the crash coming from Visual Studio's optimisation

2017-06-06 Thread Sandra Koroniewska 
This fixes
spec/khr_texture_compression_astc/khr_compressed_astc-array_gl on
Intel Windows driver.
---
 .../khr_compressed_astc-miptree-array.c| 37 +++---
 1 file changed, 19 insertions(+), 18 deletions(-)

diff --git 
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c 
b/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c
index 0cc0ec819..b15ab0b37 100644
--- 
a/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c
+++ 
b/tests/spec/khr_texture_compression_astc/khr_compressed_astc-miptree-array.c
@@ -57,26 +57,27 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
config.window_width = 2 * level0_width;
config.window_height = level0_height + (level0_height >> 1);
config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
-   static bool is_odd[2] = {true, false};
-
-   config.subtests = (struct piglit_subtest[]) {
-   {
-   "5x5 Block Dim",
-   "odd",
-   test_miptrees,
-   _odd[0]
-   },
-   {
-   "12x12 Block Dim",
-   "even",
-   test_miptrees,
-   _odd[1]
-   },
-   {NULL},
-   };
 
 PIGLIT_GL_TEST_CONFIG_END
 
+static bool is_odd[2] = { true, false };
+
+const struct piglit_subtest subtests[] = {
+   {
+   "5x5 Block Dim",
+   "odd",
+   test_miptrees,
+   _odd[0]
+   },
+   {
+   "12x12 Block Dim",
+   "even",
+   test_miptrees,
+   _odd[1]
+   },
+   { NULL },
+};
+
 /**
  * The \a filename is relative to the current test's source directory.
  *
@@ -293,7 +294,7 @@ piglit_init(int argc, char **argv)
 enum piglit_result
 piglit_display(void)
 {
-   return piglit_run_selected_subtests(piglit_config->subtests,
+   return piglit_run_selected_subtests(subtests,
  piglit_config->selected_subtests,
  piglit_config->num_selected_subtests,
  PIGLIT_SKIP);
-- 
2.11.0.windows.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit