Re: [Piglit] [PATCH 0/3] Enable generator unittests

2017-12-19 Thread Juan A. Suarez Romero 
For the series:

Reviewed-by: Juan A. Suarez 


On Mon, 2017-12-18 at 18:14 +0200, Andres Gomez wrote:
> This is a small series which correct some small mistakes, update the
> unit test for the generator and enables it in Travis CI.
> 
> Andres Gomez (3):
>   unittests: correct tessellation typo
>   unittests: update python generator
>   travis: add generator unittests
> 
>  .travis.yml | 10 +-
>  unittests/generators/test_generators.py |  7 ++-
>  unittests/generators/test_glsl.py   | 16 
>  3 files changed, 19 insertions(+), 14 deletions(-)
> 
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_internalformat_query2: correct tessellation typo

2017-12-19 Thread Andres Gomez 
On Tue, 2017-12-19 at 08:52 +0100, Alejandro Piñeiro wrote:
> Reviewed-by: Alejandro Piñeiro 
> 
> PS: in fact I have that fix as part of one of my patches, but I have
> pending to answer one Ilia question (need some investigation). In any
> case, I think that we can fix the typo now. Thanks!

OK. Sorry I didn't realize about that.

I'll push this now.

Thanks!

-- 
Br,

Andres
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_shader_image_load_store: correct tessellation typo

2017-12-19 Thread Andres Gomez 
On Mon, 2017-12-18 at 09:47 -0800, Francisco Jerez wrote:
> Andres Gomez  writes:
> 
> > Cc: Francisco Jerez 
> > Signed-off-by: Andres Gomez 
> > ---
> >  tests/spec/arb_shader_image_load_store/grid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/spec/arb_shader_image_load_store/grid.c 
> > b/tests/spec/arb_shader_image_load_store/grid.c
> > index 68d80b102..261dbfd13 100644
> > --- a/tests/spec/arb_shader_image_load_store/grid.c
> > +++ b/tests/spec/arb_shader_image_load_store/grid.c
> > @@ -261,7 +261,7 @@ generate_program_v(const struct grid_info grid, const 
> > char **sources)
> >   GL_GEOMETRY_SHADER_BIT);
> >  const unsigned stages =
> >  (grid.stages |
> > - /* Make a full pipeline if a tesselation shader was
> > + /* Make a full pipeline if a tessellation shader was
> 
> Actually both are valid spellings AFAIA -- Unless you are searching for
> the ARB extension string I guess ;).

Ouch!

I didn't know tesselate was a valid alternative spelling. Now I've
learned something new ☺

Yes, I was doing a quick check for typos in the extensions after
finding by chance one of them.

Consider this patch withdrawn.
 
-- 
Br,

Andres
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit