Re: [Piglit] [PATCH 1/4] README.md: Note that python 3.3.x+ is supported
Quoting Rhys Kidd (2018-06-09 12:37:48) > On 8 June 2018 at 12:15, Dylan Baker wrote: > > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 30d7a2b5f..2d7d95674 100644 > --- a/README.md > +++ b/README.md > @@ -30,7 +30,7 @@ The original tests have been taken from > > First of all, you need to make sure that the following are installed: > > - - Python 2.7.x > + - Python 2.7.x or 3.3.x+ > > > Clearer to say?: > > - - Python 2.7.x > + - Python 2.7.x or >=3.4 > > As you know Python 3.3.x has reached end-of-life. > > Whilst piglit's code may still works with 3.3, there are a number of > dependencies which no longer do - as seen in piglit's continuous integration > testing. I'll separately send a patch for that. Yeah, it has. On the other hand python 2.7 is positively ancient, and I don't see us dropping support for it any time soon. I guess before we drop 3.3 support lets make sure there's no one relying on 3.3. Dylan > - Python Mako module > - numpy (http://www.numpy.org) > - six (https://pypi.python.org/pypi/six) > -- > 2.17.1 > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit > > signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/4] README.md: Remove PIGLIT_FORCE_GLSLPASER_DESKTOP env variable
Quoting Eric Anholt (2018-06-08 16:33:29) > Dylan Baker writes: > > > This is no longer honored, instead use the glslparser_arb_compat > > profile. > > I still see it in the tree here. It's used at compile time to generate the glslparser_arb_compat.xml.gz, but when you load the XML that variable is ignored. Maybe it would be better to rename the variable in tree to something like _PIGLIT_BUILD_TIME_ARB_COMPAT? Dylan signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3
On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote:
> On 11 June 2018 at 05:40, Eric Engestrom wrote:
>
> > On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> > > Python 3.3 reached end-of-life in September 2017 [0].
> > >
> > > Continuous integration testing has identified a number of dependencies
> > are
> > > now failing on python 3.3, such as:
> > >
> > > Collecting wheel
> > > wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but
> > the running Python is 3.3.6
> > > ...
> > > OSError: Command /home/travis/build/E...generator/bin/python -
> > setuptools pip wheel failed with error code 1
> > >
> > > [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
> > >
> > > Signed-off-by: Rhys Kidd
> >
> > I just set up the travis build for the github mirror of piglit [1] an
> > hour ago, and noticed this issue.
> >
> > Reviewed-by: Eric Engestrom
> >
> > Have you also noticed the other issues [2] (asserts firing up)?
> >
>
> Yes, have seen those. Those asserts() were the next thing I was going to
> dig into.
Brilliant, thanks :)
>
>
> >
> > Is there another canonical travis instance of piglit, and I should
> > remove the one I just set up?
> >
>
> That's as canonical as any other; I believe the Travis CI functionality
> was added originally for individual developers to have the option of testing
> their own patches. Having it run against the mesa3d GitHub read only
> mirror is good though.
>
> The question of porting this testing functionality over to GitLab's CI is a
> separate, but worthwhile, discussion to have.
Agreed, and until then I'll just leave the Travis instance of the Github
mirror running as is.
>
>
> >
> > [1] https://travis-ci.org/mesa3d/piglit
> > [2] https://travis-ci.org/mesa3d/piglit/builds/390672919
> >
> > > ---
> > > .travis.yml | 2 --
> > > tox.ini | 6 +++---
> > > 2 files changed, 3 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/.travis.yml b/.travis.yml
> > > index b4cbcca49..b6e8136e8 100644
> > > --- a/.travis.yml
> > > +++ b/.travis.yml
> > > @@ -15,8 +15,6 @@ matrix:
> > >include:
> > > - python: 2.7
> > >env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> > > -- python: 3.3
> > > - env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
> > > - python: 3.4
> > >env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
> > > - python: 3.5
> > > diff --git a/tox.ini b/tox.ini
> > > index 12e8abd9f..411972873 100644
> > > --- a/tox.ini
> > > +++ b/tox.ini
> > > @@ -1,5 +1,5 @@
> > > [tox]
> > > -envlist = py{27,33,34,35,36}-{generator,noaccel},
> > py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> > > +envlist = py{27,34,35,36}-{generator,noaccel},
> > py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
> > > skipsdist = True
> > >
> > > [pytest]
> > > @@ -16,7 +16,7 @@ deps =
> > > accel: simplejson
> > > generator: numpy==1.7.0
> > > mock==1.0.1
> > > -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> > > +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
> > > py27-accel-nix: backports.lzma
> > > py27-accel-nix: subprocess32
> > > py{35,36}: mako==1.0.2
> > > @@ -26,7 +26,7 @@ deps =
> > > pytest-raises
> > > pytest-warnings
> > > pytest-timeout
> > > -py{27,33,34}: mako==0.8.0
> > > +py{27,34}: mako==0.8.0
> > > six==1.5.2
> > > {accel,noaccel,streams}: jsonschema
> > > streams: jsonstreams>=0.4.1
> > > --
> > > 2.17.1
> > >
> > > ___
> > > Piglit mailing list
> > > Piglit@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/piglit
> >
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3
On 11 June 2018 at 05:40, Eric Engestrom wrote:
> On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> > Python 3.3 reached end-of-life in September 2017 [0].
> >
> > Continuous integration testing has identified a number of dependencies
> are
> > now failing on python 3.3, such as:
> >
> > Collecting wheel
> > wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but
> the running Python is 3.3.6
> > ...
> > OSError: Command /home/travis/build/E...generator/bin/python -
> setuptools pip wheel failed with error code 1
> >
> > [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
> >
> > Signed-off-by: Rhys Kidd
>
> I just set up the travis build for the github mirror of piglit [1] an
> hour ago, and noticed this issue.
>
> Reviewed-by: Eric Engestrom
>
> Have you also noticed the other issues [2] (asserts firing up)?
>
Yes, have seen those. Those asserts() were the next thing I was going to
dig into.
>
> Is there another canonical travis instance of piglit, and I should
> remove the one I just set up?
>
That's as canonical as any other; I believe the Travis CI functionality
was added originally for individual developers to have the option of testing
their own patches. Having it run against the mesa3d GitHub read only
mirror is good though.
The question of porting this testing functionality over to GitLab's CI is a
separate, but worthwhile, discussion to have.
>
> [1] https://travis-ci.org/mesa3d/piglit
> [2] https://travis-ci.org/mesa3d/piglit/builds/390672919
>
> > ---
> > .travis.yml | 2 --
> > tox.ini | 6 +++---
> > 2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index b4cbcca49..b6e8136e8 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,8 +15,6 @@ matrix:
> >include:
> > - python: 2.7
> >env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> > -- python: 3.3
> > - env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
> > - python: 3.4
> >env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
> > - python: 3.5
> > diff --git a/tox.ini b/tox.ini
> > index 12e8abd9f..411972873 100644
> > --- a/tox.ini
> > +++ b/tox.ini
> > @@ -1,5 +1,5 @@
> > [tox]
> > -envlist = py{27,33,34,35,36}-{generator,noaccel},
> py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> > +envlist = py{27,34,35,36}-{generator,noaccel},
> py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
> > skipsdist = True
> >
> > [pytest]
> > @@ -16,7 +16,7 @@ deps =
> > accel: simplejson
> > generator: numpy==1.7.0
> > mock==1.0.1
> > -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> > +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
> > py27-accel-nix: backports.lzma
> > py27-accel-nix: subprocess32
> > py{35,36}: mako==1.0.2
> > @@ -26,7 +26,7 @@ deps =
> > pytest-raises
> > pytest-warnings
> > pytest-timeout
> > -py{27,33,34}: mako==0.8.0
> > +py{27,34}: mako==0.8.0
> > six==1.5.2
> > {accel,noaccel,streams}: jsonschema
> > streams: jsonstreams>=0.4.1
> > --
> > 2.17.1
> >
> > ___
> > Piglit mailing list
> > Piglit@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/piglit
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3
On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> Python 3.3 reached end-of-life in September 2017 [0].
>
> Continuous integration testing has identified a number of dependencies are
> now failing on python 3.3, such as:
>
> Collecting wheel
> wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the
> running Python is 3.3.6
> ...
> OSError: Command /home/travis/build/E...generator/bin/python - setuptools
> pip wheel failed with error code 1
>
> [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
>
> Signed-off-by: Rhys Kidd
I just set up the travis build for the github mirror of piglit [1] an
hour ago, and noticed this issue.
Reviewed-by: Eric Engestrom
Have you also noticed the other issues [2] (asserts firing up)?
Is there another canonical travis instance of piglit, and I should
remove the one I just set up?
[1] https://travis-ci.org/mesa3d/piglit
[2] https://travis-ci.org/mesa3d/piglit/builds/390672919
> ---
> .travis.yml | 2 --
> tox.ini | 6 +++---
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index b4cbcca49..b6e8136e8 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,8 +15,6 @@ matrix:
>include:
> - python: 2.7
>env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> -- python: 3.3
> - env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
> - python: 3.4
>env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
> - python: 3.5
> diff --git a/tox.ini b/tox.ini
> index 12e8abd9f..411972873 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -1,5 +1,5 @@
> [tox]
> -envlist = py{27,33,34,35,36}-{generator,noaccel},
> py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> +envlist = py{27,34,35,36}-{generator,noaccel},
> py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
> skipsdist = True
>
> [pytest]
> @@ -16,7 +16,7 @@ deps =
> accel: simplejson
> generator: numpy==1.7.0
> mock==1.0.1
> -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
> py27-accel-nix: backports.lzma
> py27-accel-nix: subprocess32
> py{35,36}: mako==1.0.2
> @@ -26,7 +26,7 @@ deps =
> pytest-raises
> pytest-warnings
> pytest-timeout
> -py{27,33,34}: mako==0.8.0
> +py{27,34}: mako==0.8.0
> six==1.5.2
> {accel,noaccel,streams}: jsonschema
> streams: jsonstreams>=0.4.1
> --
> 2.17.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
