Re: [Piglit] [PATCH 2/3] tox: Add python 3.7 to build matrix
On 8 August 2018 at 17:18, Dylan Baker wrote:
> Quoting Emil Velikov (2018-08-08 05:33:44)
>> On 7 August 2018 at 02:53, Rhys Kidd wrote:
>> > Signed-off-by: Rhys Kidd
>> > ---
>> > .travis.yml | 3 +++
>> > tox.ini | 9 +
>> > 2 files changed, 8 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/.travis.yml b/.travis.yml
>> > index b6e8136e8..45b23f009 100644
>> > --- a/.travis.yml
>> > +++ b/.travis.yml
>> > @@ -21,6 +21,9 @@ matrix:
>> >env: TOX_ENV="py35-{generator,noaccel,accel-nix,streams}"
>> > - python: 3.6
>> >env: TOX_ENV="py36-{generator,noaccel,accel-nix,streams}"
>> > +- python: 3.7
>> > + env: TOX_ENV="py37-{generator,noaccel,accel-nix,streams}"
>> > + dist: xenial# required for Python 3.7 (travis-ci/travis-ci#9069)
>>
>> jfyi: Xenial support is unofficial and experimental. it seems to come
>> and go every so often.
>> Might want to mention a note, to clear some confusion if it starts failing
>> ;-\
>>
>> HTH
>> Emil
>
> Yeah, travis + Python 3.7 is a cluster right now. I wonder if we'd be better
> off
> building our own docker image.
I'd worry about that if/when things start failing ;-)
-Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/3] tox: Add python 3.7 to build matrix
Quoting Emil Velikov (2018-08-08 05:33:44)
> On 7 August 2018 at 02:53, Rhys Kidd wrote:
> > Signed-off-by: Rhys Kidd
> > ---
> > .travis.yml | 3 +++
> > tox.ini | 9 +
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index b6e8136e8..45b23f009 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -21,6 +21,9 @@ matrix:
> >env: TOX_ENV="py35-{generator,noaccel,accel-nix,streams}"
> > - python: 3.6
> >env: TOX_ENV="py36-{generator,noaccel,accel-nix,streams}"
> > +- python: 3.7
> > + env: TOX_ENV="py37-{generator,noaccel,accel-nix,streams}"
> > + dist: xenial# required for Python 3.7 (travis-ci/travis-ci#9069)
>
> jfyi: Xenial support is unofficial and experimental. it seems to come
> and go every so often.
> Might want to mention a note, to clear some confusion if it starts failing ;-\
>
> HTH
> Emil
Yeah, travis + Python 3.7 is a cluster right now. I wonder if we'd be better off
building our own docker image.
signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH piglit] dispatch: add missing break
On 8 August 2018 at 15:50, Eric Engestrom wrote: > Cc: Emil Velikov > Fixes: 7356bdd050b8475ed13c "dispatch: fallback to eglGetProcAddress for > core functions" > Signed-off-by: Eric Engestrom Feel free to push this ASAP. Reviewed-by: Emil Velikov -Emil ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH piglit] dispatch: add missing break
Cc: Emil Velikov
Fixes: 7356bdd050b8475ed13c "dispatch: fallback to eglGetProcAddress for
core functions"
Signed-off-by: Eric Engestrom
---
tests/util/piglit-dispatch-init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/util/piglit-dispatch-init.c
b/tests/util/piglit-dispatch-init.c
index fc6b561ca0362e5d8bd3..3d9772d9b8b50b738739 100644
--- a/tests/util/piglit-dispatch-init.c
+++ b/tests/util/piglit-dispatch-init.c
@@ -225,8 +225,10 @@ get_core_proc_address(const char *function_name, int
gl_10x_version)
switch (gl_10x_version) {
case 11:
p = do_dlsym(_handle, GLES1_LIB, function_name);
+ break;
case 20:
p = do_dlsym(_handle, GLES2_LIB, function_name);
+ break;
case 10:
default:
/* We query the address of core OpenGL functions as if they
--
Cheers,
Eric
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/3] tox: Add python 3.7 to build matrix
On 7 August 2018 at 02:53, Rhys Kidd wrote:
> Signed-off-by: Rhys Kidd
> ---
> .travis.yml | 3 +++
> tox.ini | 9 +
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index b6e8136e8..45b23f009 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -21,6 +21,9 @@ matrix:
>env: TOX_ENV="py35-{generator,noaccel,accel-nix,streams}"
> - python: 3.6
>env: TOX_ENV="py36-{generator,noaccel,accel-nix,streams}"
> +- python: 3.7
> + env: TOX_ENV="py37-{generator,noaccel,accel-nix,streams}"
> + dist: xenial# required for Python 3.7 (travis-ci/travis-ci#9069)
jfyi: Xenial support is unofficial and experimental. it seems to come
and go every so often.
Might want to mention a note, to clear some confusion if it starts failing ;-\
HTH
Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
