Re: [Piglit] [PATCH] ext_render_snorm-render: test for GL_EXT_render_snorm
On Thu, Aug 02, 2018 at 02:06:26PM +0300, Tapani Pälli wrote:
> Test includes:
>- texture uploads
>- mipmap generation
>- framebuffer creation
>- rendering to
>- reading from
>- interaction with GL_EXT_copy_image
I don't see any interaction with this extension..
>
> This test includes only GL_BYTE based formats. R16_SNORM, RG16_SNORM
> and RGBA16_SNORM are tested in GL_EXT_texture_norm16 tests.
>
> Signed-off-by: Tapani Pälli
> ---
> tests/opengl.py | 5 +
> tests/spec/CMakeLists.txt| 1 +
> tests/spec/ext_render_snorm/CMakeLists.gles2.txt | 7 +
> tests/spec/ext_render_snorm/CMakeLists.txt | 1 +
> tests/spec/ext_render_snorm/render.c | 335
> +++
> 5 files changed, 349 insertions(+)
> create mode 100644 tests/spec/ext_render_snorm/CMakeLists.gles2.txt
> create mode 100644 tests/spec/ext_render_snorm/CMakeLists.txt
> create mode 100644 tests/spec/ext_render_snorm/render.c
>
> diff --git a/tests/opengl.py b/tests/opengl.py
> index 397676e65..6a8c513b4 100644
> --- a/tests/opengl.py
> +++ b/tests/opengl.py
> @@ -3070,6 +3070,11 @@ with profile.test_list.group_manager(
> grouptools.join('spec', 'ext_texture_norm16')) as g:
> g(['ext_texture_norm16-render'], 'render')
>
> +with profile.test_list.group_manager(
> +PiglitGLTest,
> +grouptools.join('spec', 'ext_render_snorm')) as g:
> +g(['ext_render_snorm-render'], 'render')
> +
> with profile.test_list.group_manager(
> PiglitGLTest,
> grouptools.join('spec', 'ext_frag_depth')) as g:
> diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt
> index 6cf3f76ed..0a2d4bb25 100644
> --- a/tests/spec/CMakeLists.txt
> +++ b/tests/spec/CMakeLists.txt
> @@ -181,3 +181,4 @@ add_subdirectory (ext_occlusion_query_boolean)
> add_subdirectory (ext_disjoint_timer_query)
> add_subdirectory (intel_blackhole_render)
> add_subdirectory (ext_texture_norm16)
> +add_subdirectory (ext_render_snorm)
> diff --git a/tests/spec/ext_render_snorm/CMakeLists.gles2.txt
> b/tests/spec/ext_render_snorm/CMakeLists.gles2.txt
> new file mode 100644
> index 0..4b90257cc
> --- /dev/null
> +++ b/tests/spec/ext_render_snorm/CMakeLists.gles2.txt
> @@ -0,0 +1,7 @@
> +link_libraries (
> + piglitutil_${piglit_target_api}
> +)
> +
> +piglit_add_executable (ext_render_snorm-render render.c)
> +
> +# vim: ft=cmake:
> diff --git a/tests/spec/ext_render_snorm/CMakeLists.txt
> b/tests/spec/ext_render_snorm/CMakeLists.txt
> new file mode 100644
> index 0..144a306f4
> --- /dev/null
> +++ b/tests/spec/ext_render_snorm/CMakeLists.txt
> @@ -0,0 +1 @@
> +piglit_include_target_api()
> diff --git a/tests/spec/ext_render_snorm/render.c
> b/tests/spec/ext_render_snorm/render.c
> new file mode 100644
> index 0..241812e12
> --- /dev/null
> +++ b/tests/spec/ext_render_snorm/render.c
> @@ -0,0 +1,335 @@
> +/*
> + * Copyright © 2018 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/**
> + * @file
> + * Basic tests for formats added by GL_EXT_render_snorm extension
> + *
> + *
> https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_render_snorm.txt
> + *
> + * Test includes:
> + * - texture uploads
> + * - mipmap generation
> + * - framebuffer creation
> + * - rendering to
> + * - reading from
> + * - interaction with GL_EXT_copy_image
Same as above.
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> + config.supports_gl_es_version = 31;
> + config.window_visual = PIGLIT_GL_VISUAL_RGBA;
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +#define PIGLIT_RESULT(x) x ? PIGLIT_PASS : PIGLIT_FAIL
> +
> +static const char vs_source[] =
> + "#version 310 es\n"
> + "layout(location = 0) in highp vec4 vertex;\n"
> + "la
[Piglit] [PATCH] Cmake: Remove Python 3.3 from the list of versions to search for
Suggested-by: Rhys Kidd --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 433fa1aea..8f19457fc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS) ENDIF() set(Python_ADDITIONAL_VERSIONS -3.7 3.6 3.5 3.4 3.3 2.7) +3.7 3.6 3.5 3.4 2.7) find_package(PythonInterp REQUIRED) find_package(PythonSix 1.5.2 REQUIRED) find_package(PythonNumpy 1.7.0 REQUIRED) -- 2.18.0 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] CMake: Add Python 3.7 to list of supported python version
Quoting Rhys Kidd (2018-08-10 10:48:49) > On Fri, 10 Aug 2018 at 13:47, Dylan Baker wrote: > > --- > CMakeLists.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 413cd72e6..433fa1aea 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS) > ENDIF() > > set(Python_ADDITIONAL_VERSIONS > - 3.6 3.5 3.4 3.3 2.7) > + 3.7 3.6 3.5 3.4 3.3 2.7) > find_package(PythonInterp REQUIRED) > find_package(PythonSix 1.5.2 REQUIRED) > find_package(PythonNumpy 1.7.0 REQUIRED) > > > Perhaps also remove the 3.3? With or without, gets my: That should probably be it's own patch since it's a different change. I can send one for that too. > > Reviewed-by: Rhys Kidd Thanks! > > > -- > 2.18.0 > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit > signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] CMake: Add Python 3.7 to list of supported python version
On Fri, 10 Aug 2018 at 13:47, Dylan Baker wrote: > --- > CMakeLists.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 413cd72e6..433fa1aea 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS) > ENDIF() > > set(Python_ADDITIONAL_VERSIONS > -3.6 3.5 3.4 3.3 2.7) > +3.7 3.6 3.5 3.4 3.3 2.7) > find_package(PythonInterp REQUIRED) > find_package(PythonSix 1.5.2 REQUIRED) > find_package(PythonNumpy 1.7.0 REQUIRED) > Perhaps also remove the 3.3? With or without, gets my: Reviewed-by: Rhys Kidd > -- > 2.18.0 > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit > ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] CMake: Add Python 3.7 to list of supported python version
--- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 413cd72e6..433fa1aea 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS) ENDIF() set(Python_ADDITIONAL_VERSIONS -3.6 3.5 3.4 3.3 2.7) +3.7 3.6 3.5 3.4 3.3 2.7) find_package(PythonInterp REQUIRED) find_package(PythonSix 1.5.2 REQUIRED) find_package(PythonNumpy 1.7.0 REQUIRED) -- 2.18.0 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] shaders: add a glslparsertest for bug 98699
I thought we'd stopped adding tests with "bugX" in the name and tried to
give the test a descriptive name and we were trying not to add more
tests to tests/shaders, but put them in tests/spec/. So maybe rename
it to something like:
tests/spec/glsl-1.10/compiler/post-increment-in-array-size.shader_test
Or whatever you think is better (I'm just reading the bug and trying to come up
with something).
Otherwise this test looks good, so with the rename:
Reviewed-by: Dylan Baker
Quoting Tapani Pälli (2018-08-09 23:12:44)
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98699
> ---
> tests/shaders/glsl-compiler-bug98699.vert | 9 +
> 1 file changed, 9 insertions(+)
> create mode 100644 tests/shaders/glsl-compiler-bug98699.vert
>
> diff --git a/tests/shaders/glsl-compiler-bug98699.vert
> b/tests/shaders/glsl-compiler-bug98699.vert
> new file mode 100644
> index 0..9bd219cf0
> --- /dev/null
> +++ b/tests/shaders/glsl-compiler-bug98699.vert
> @@ -0,0 +1,9 @@
> +// [config]
> +// expect_result: fail
> +// glsl_version: 1.10
> +// [end config]
> +
> +void main()
> +{
> +float[a+++4 ? 1:1] f;
> +}
> --
> 2.14.4
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 00/10] Selection of EGLDevice tests
Hi Emil, Patch #1-7,9 are Reviewed-by: Mathias Fröhlich best Mathias On Friday, 3 August 2018 14:46:28 CEST Emil Velikov wrote: > Hi all, > > Here is a series to complement the Mesa patches sent earlier. > > In particular, it: > - addresses a few nitpicks in the existing tests: device_query, > device_enumeration, platform_surfaceless > - adds a couple extra tests to the above > - introduces tests for device_software, device_drm and platform_device > > Any review and input will be appreciated. > > Thanks > Emil > > > Emil Velikov (9): > egl_ext_device_query: check for eglQueryDeviceStringEXT > EGL_BAD_DEVICE_EXT > egl: Add basic EGL_MESA_device_software test > egl_ext_device_query: drop unused major/minor from eglInitialize > egl_ext_device_query: return PIGLIT_WARN when eglGetDisplay fails > egl_ext_device_query: plug memory leaks > egl: Add basic EGL_EXT_device_drm test > egl_mesa_platform_surfaceless: plug some memory leaks > egl Add new test of EGL_EXT_platform_device > egl_ext_device_enumeration: check the populate call to eglQueryDevices > > tests/egl/spec/CMakeLists.txt | 3 + > .../egl_ext_device_drm/CMakeLists.no_api.txt | 7 + > .../spec/egl_ext_device_drm/CMakeLists.txt| 1 + > .../egl_ext_device_drm/egl_ext_device_drm.c | 252 > .../egl_ext_device_enumeration.c | 5 + > .../egl_ext_device_query.c| 27 +- > .../CMakeLists.no_api.txt | 7 + > .../egl_ext_platform_device/CMakeLists.txt| 1 + > .../egl_ext_platform_device.c | 271 ++ > .../CMakeLists.no_api.txt | 7 + > .../egl_mesa_device_software/CMakeLists.txt | 1 + > .../egl_mesa_device_software.c| 130 + > .../egl_mesa_platform_surfaceless.c | 5 +- > tests/opengl.py | 18 ++ > 14 files changed, 728 insertions(+), 7 deletions(-) > create mode 100644 tests/egl/spec/egl_ext_device_drm/CMakeLists.no_api.txt > create mode 100644 tests/egl/spec/egl_ext_device_drm/CMakeLists.txt > create mode 100644 tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c > create mode 100644 > tests/egl/spec/egl_ext_platform_device/CMakeLists.no_api.txt > create mode 100644 tests/egl/spec/egl_ext_platform_device/CMakeLists.txt > create mode 100644 > tests/egl/spec/egl_ext_platform_device/egl_ext_platform_device.c > create mode 100644 > tests/egl/spec/egl_mesa_device_software/CMakeLists.no_api.txt > create mode 100644 tests/egl/spec/egl_mesa_device_software/CMakeLists.txt > create mode 100644 > tests/egl/spec/egl_mesa_device_software/egl_mesa_device_software.c > > ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 8/9] egl Add new test of EGL_EXT_platform_device
On Friday, 3 August 2018 14:46:36 CEST Emil Velikov wrote: > From: Emil Velikov > > Since the functionality is more or less identical to > EGL_MESA_platform_surfaceless, the test with a copy of it. > > Changes, as listed in the test itself, include: > - s/MESA_platform_surfaceless/EXT_platform_device/g > - eglQueryDevicesEXT and eglGetPlatformDisplayEXT entrypoing handling > - custom GetDisplay, based on eglQueryDevicesEXT > - couple of s/PIGLIT_SKIP/PIGLIT_FAIL/ > > Signed-off-by: Emil Velikov > --- > tests/egl/spec/CMakeLists.txt | 1 + > .../CMakeLists.no_api.txt | 7 + > .../egl_ext_platform_device/CMakeLists.txt| 1 + > .../egl_ext_platform_device.c | 271 ++ > tests/opengl.py | 6 + > 5 files changed, 286 insertions(+) > create mode 100644 > tests/egl/spec/egl_ext_platform_device/CMakeLists.no_api.txt > create mode 100644 tests/egl/spec/egl_ext_platform_device/CMakeLists.txt > create mode 100644 > tests/egl/spec/egl_ext_platform_device/egl_ext_platform_device.c > > diff --git a/tests/egl/spec/CMakeLists.txt b/tests/egl/spec/CMakeLists.txt > index 9324efcaf..f38a4f62b 100644 > --- a/tests/egl/spec/CMakeLists.txt > +++ b/tests/egl/spec/CMakeLists.txt > @@ -3,6 +3,7 @@ add_subdirectory (egl_ext_client_extensions) > add_subdirectory (egl_ext_device_query) > add_subdirectory (egl_ext_device_enumeration) > add_subdirectory (egl_ext_device_drm) > +add_subdirectory (egl_ext_platform_device) > add_subdirectory (egl_ext_image_dma_buf_import_modifiers) > add_subdirectory (egl_khr_create_context) > add_subdirectory (egl_khr_get_all_proc_addresses) > diff --git a/tests/egl/spec/egl_ext_platform_device/CMakeLists.no_api.txt > b/tests/egl/spec/egl_ext_platform_device/CMakeLists.no_api.txt > new file mode 100644 > index 0..6c1bbd2a1 > --- /dev/null > +++ b/tests/egl/spec/egl_ext_platform_device/CMakeLists.no_api.txt > @@ -0,0 +1,7 @@ > +link_libraries( > + piglitutil > +) > + > +piglit_add_executable(egl_ext_platform_device egl_ext_platform_device.c) > + > +# vim: ft=cmake: > diff --git a/tests/egl/spec/egl_ext_platform_device/CMakeLists.txt > b/tests/egl/spec/egl_ext_platform_device/CMakeLists.txt > new file mode 100644 > index 0..144a306f4 > --- /dev/null > +++ b/tests/egl/spec/egl_ext_platform_device/CMakeLists.txt > @@ -0,0 +1 @@ > +piglit_include_target_api() > diff --git a/tests/egl/spec/egl_ext_platform_device/egl_ext_platform_device.c > b/tests/egl/spec/egl_ext_platform_device/egl_ext_platform_device.c > new file mode 100644 > index 0..20d8312ec > --- /dev/null > +++ b/tests/egl/spec/egl_ext_platform_device/egl_ext_platform_device.c > @@ -0,0 +1,271 @@ > +/* > + * Copyright 2018 Collabora, Ltd. > + * > + * Based on ext_mesa_platform_surfaceless.c which has > + * Copyright 2016 Google > + * > + * Permission is hereby granted, free of charge, to any person obtaining a > + * copy of this software and associated documentation files (the "Software"), > + * to deal in the Software without restriction, including without limitation > + * the rights to use, copy, modify, merge, publish, distribute, sublicense, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the next > + * paragraph) shall be included in all copies or substantial portions of the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > DEALINGS > + * IN THE SOFTWARE. > + */ > + > + > +/* Note that this test is a mere copy with the following changes: > + * - s/MESA_platform_surfaceless/EXT_platform_device/g > + * - eglQueryDevicesEXT and eglGetPlatformDisplayEXT entrypoing handling > + * - custom GetDisplay, based on eglQueryDevicesEXT > + * - couple of s/PIGLIT_SKIP/PIGLIT_FAIL/ > + */ > + > +#include "piglit-util.h" > +#include "piglit-util-egl.h" > + > +/* Extension function pointers. > + * > + * Use prefix 'pegl' (piglit egl) instead of 'egl' to avoid collisions with > + * prototypes in eglext.h. */ > +EGLSurface (*peglCreatePlatformPixmapSurfaceEXT)(EGLDisplay display, > EGLConfig config, > + void *native_pixmap, const EGLint *attrib_list); > +EGLSurface (*peglCreatePlatformWindowSurfaceEXT)(EGLDisplay display, > EGLConfig config, > + void *native_window, const EGLint *attrib_list); > + > +EGLBoolean (*peglQueryDevicesEXT)(EGLint max_devices, EGLDeviceEXT *de
