Re: [Piglit] [PATCH] glsl-1.10: add tests for an array index on a swizzled vec lvalue

2018-10-07 Thread Timothy Arceri 

Reviewed-by: Timothy Arceri 

On 6/10/18 10:58 am, Ilia Mirkin wrote:

Current mesa fails both of these (in different ways!).

Inspired by WebGL conformance test
conformance2/glsl3/vector-dynamic-indexing-swizzled-lvalue.html

Signed-off-by: Ilia Mirkin 
---
  .../swizzled-writemask-indexing-nonconst.shader_test| 17 +
  .../execution/swizzled-writemask-indexing.shader_test   | 15 +++
  2 files changed, 32 insertions(+)
  create mode 100644 
tests/spec/glsl-1.10/execution/swizzled-writemask-indexing-nonconst.shader_test
  create mode 100644 
tests/spec/glsl-1.10/execution/swizzled-writemask-indexing.shader_test

diff --git 
a/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing-nonconst.shader_test
 
b/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing-nonconst.shader_test
new file mode 100644
index 0..fa1f7df58
--- /dev/null
+++ 
b/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing-nonconst.shader_test
@@ -0,0 +1,17 @@
+[require]
+GLSL >= 1.10
+
+[vertex shader passthrough]
+
+[fragment shader]
+uniform int zero;
+void main() {
+gl_FragColor = vec4(1, 0, 0, 1);
+gl_FragColor.wzyx[zero + 2] = 1.0;
+gl_FragColor.wzyx[zero + 3] = 0.0;
+}
+
+[test]
+uniform int zero 0
+draw rect -1 -1 2 2
+probe all rgba 0 1 0 1
diff --git 
a/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing.shader_test 
b/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing.shader_test
new file mode 100644
index 0..f61ebabb8
--- /dev/null
+++ b/tests/spec/glsl-1.10/execution/swizzled-writemask-indexing.shader_test
@@ -0,0 +1,15 @@
+[require]
+GLSL >= 1.10
+
+[vertex shader passthrough]
+
+[fragment shader]
+void main() {
+gl_FragColor = vec4(1, 0, 0, 1);
+gl_FragColor.wzyx[2] = 1.0;
+gl_FragColor.wzyx[3] = 0.0;
+}
+
+[test]
+draw rect -1 -1 2 2
+probe all rgba 0 1 0 1


___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH piglit] idTech: fix extensions string list

2018-10-07 Thread Timothy Arceri 

Reviewed-by: Timothy Arceri 

On 8/10/18 3:26 am, Eric Engestrom wrote:

From: Eric Engestrom 

CID: 1439995
Fixes: f787ad0b60869f969f02d "Add tests for GL_EXTENSION_STRING vs. old
   idTech2 / idTech3 games"
Cc: Ian Romanick 
Signed-off-by: Eric Engestrom 
---
  tests/general/idtech-extension-strings.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/general/idtech-extension-strings.c 
b/tests/general/idtech-extension-strings.c
index 83eaed8ce36a21ee5ecc..194ee5e144f1d105acef 100644
--- a/tests/general/idtech-extension-strings.c
+++ b/tests/general/idtech-extension-strings.c
@@ -79,7 +79,7 @@ const char *const q3demo_list[] = {
  const char *const star_trek_voyager_list[] = {
"GL_S3_s3tc",
"GL_EXT_texture_compression_s3tc",
-   "GL_EXT_texture_env_add"
+   "GL_EXT_texture_env_add",
"GL_EXT_texture_filter_anisotropic",
"GL_EXT_texture_edge_clamp",
"GL_ARB_multitexture",


___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH piglit] idTech: fix extensions string list

2018-10-07 Thread Eric Engestrom 
From: Eric Engestrom 

CID: 1439995
Fixes: f787ad0b60869f969f02d "Add tests for GL_EXTENSION_STRING vs. old
  idTech2 / idTech3 games"
Cc: Ian Romanick 
Signed-off-by: Eric Engestrom 
---
 tests/general/idtech-extension-strings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/general/idtech-extension-strings.c 
b/tests/general/idtech-extension-strings.c
index 83eaed8ce36a21ee5ecc..194ee5e144f1d105acef 100644
--- a/tests/general/idtech-extension-strings.c
+++ b/tests/general/idtech-extension-strings.c
@@ -79,7 +79,7 @@ const char *const q3demo_list[] = {
 const char *const star_trek_voyager_list[] = {
"GL_S3_s3tc",
"GL_EXT_texture_compression_s3tc",
-   "GL_EXT_texture_env_add"
+   "GL_EXT_texture_env_add",
"GL_EXT_texture_filter_anisotropic",
"GL_EXT_texture_edge_clamp",
"GL_ARB_multitexture",
-- 
Cheers,
  Eric

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit