Re: [Piglit] [PATCH] egl_ext_device_drm: Fix format warning.

[Eric Engestrom]

On Thursday, 2018-11-01 16:51:52 +, Vinson Lee wrote:
> egl_ext_device_drm.c: In function ‘main’:
> egl_ext_device_drm.c:165:52: warning: format ‘%s’ expects a matching ‘char *’ 
> argument [-Wformat=]
> printf("Make sure you have permissions to open %s\n");
>~^
> 
> Fixes: 039bbe4a61d1 ("egl_ext_device_drm: don't fail the test if 
> open("/dev/dri/cardX") errors")
> Signed-off-by: Vinson Lee 

Yeah saw that too, thanks for typing up the fix!
Reviewed-by: Eric Engestrom 

> ---
>  tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c 
> b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> index 954ac60c8161..9fced9b35805 100644
> --- a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> +++ b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> @@ -162,7 +162,8 @@ main(void)
>   if (fd < 0) {
>   printf("Failed to open drm device file %s: %s\n",
>   devstring, strerror(errno));
> - printf("Make sure you have permissions to open %s\n");
> + printf("Make sure you have permissions to open %s\n",
> + devstring);
>   result = PIGLIT_WARN;
>   eglTerminate(dpy1);
>   continue;
> -- 
> 2.17.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] egl_ext_device_drm: Fix format warning.

[Vinson Lee]

egl_ext_device_drm.c: In function ‘main’:
egl_ext_device_drm.c:165:52: warning: format ‘%s’ expects a matching ‘char *’ 
argument [-Wformat=]
printf("Make sure you have permissions to open %s\n");
   ~^

Fixes: 039bbe4a61d1 ("egl_ext_device_drm: don't fail the test if 
open("/dev/dri/cardX") errors")
Signed-off-by: Vinson Lee 
---
 tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c 
b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
index 954ac60c8161..9fced9b35805 100644
--- a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
+++ b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
@@ -162,7 +162,8 @@ main(void)
if (fd < 0) {
printf("Failed to open drm device file %s: %s\n",
devstring, strerror(errno));
-   printf("Make sure you have permissions to open %s\n");
+   printf("Make sure you have permissions to open %s\n",
+   devstring);
result = PIGLIT_WARN;
eglTerminate(dpy1);
continue;
-- 
2.17.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 0/5] port s3tc tests to gles2

[Erik Faye-Lund]

On Wed, 2018-10-24 at 18:29 +0200, Erik Faye-Lund wrote:
> The EXT_texture_compression_s3tc spec allows to be implemented on top
> of
> gles2 as well as gles 1.1 and up.
> 
> So let's port the tests to gles2, so we can test the implementations.
> 
> Erik Faye-Lund (5):
>   texturing: make sure s3tc tests require GL 1.1
>   texturing: use piglit_draw_rect_tex instead of glBegin/glEnd
>   s3tc-teximage: port to gles2
>   s3tc-texsubimage: port to gles2
>   s3tc-errors: port to gles2
> 
>  tests/texturing/CMakeLists.gles2.txt |  7 
>  tests/texturing/s3tc-errors.c| 59
> ++--
>  tests/texturing/s3tc-teximage.c  | 59 
> 
>  tests/texturing/s3tc-texsubimage.c   | 59 
> 
>  4 files changed, 165 insertions(+), 19 deletions(-)
>  create mode 100644 tests/texturing/CMakeLists.gles2.txt
> 

Ping? Anyone willing to review this? The feature landed in Mesa
already, it would be nice to land the tests also...

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit