Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add support for XYUV format
FYI I've pushed this test to master.
On 2/18/19 9:35 AM, Tapani Pälli wrote:
Reviewed-by: Tapani Pälli
On 2/16/19 3:43 AM, Vivek Kasireddy wrote:
This format is similar to AYUV except that the alpha channel
is ignored.
Cc: Tapani Palli
Cc: Lionel Landwerlin
Signed-off-by: Vivek Kasireddy
---
tests/opengl.py | 2 ++
tests/spec/ext_image_dma_buf_import/sample_yuv.c | 1 +
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 1 +
tests/util/piglit-framework-gl/piglit_drm_dma_buf.h | 4
4 files changed, 8 insertions(+)
diff --git a/tests/opengl.py b/tests/opengl.py
index 83f980177..e91056408 100644
--- a/tests/opengl.py
+++ b/tests/opengl.py
@@ -3035,6 +3035,8 @@ with profile.test_list.group_manager(
'ext_image_dma_buf_import-sample_yvu420', run_concurrent=False)
g(['ext_image_dma_buf_import-sample_yuv', '-fmt=AYUV'],
'ext_image_dma_buf_import-sample_ayuv', run_concurrent=False)
+ g(['ext_image_dma_buf_import-sample_yuv', '-fmt=XYUV'],
+ 'ext_image_dma_buf_import-sample_xyuv', run_concurrent=False)
g(['ext_image_dma_buf_import-sample_yuv', '-fmt=P010'],
'ext_image_dma_buf_import-sample_p010', run_concurrent=False)
g(['ext_image_dma_buf_import-sample_yuv', '-fmt=P012'],
diff --git a/tests/spec/ext_image_dma_buf_import/sample_yuv.c
b/tests/spec/ext_image_dma_buf_import/sample_yuv.c
index c7b4edfc0..faa4c300c 100644
--- a/tests/spec/ext_image_dma_buf_import/sample_yuv.c
+++ b/tests/spec/ext_image_dma_buf_import/sample_yuv.c
@@ -190,6 +190,7 @@ piglit_display(void)
t = yvu420;
break;
case DRM_FORMAT_AYUV:
+ case DRM_FORMAT_XYUV:
t = ayuv;
break;
default:
diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c
b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c
index 8beafad77..07e6cc219 100644
--- a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c
+++ b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c
@@ -155,6 +155,7 @@ piglit_intel_buf_create(unsigned w, unsigned h,
unsigned fourcc,
case DRM_FORMAT_RGBA:
case DRM_FORMAT_BGRA:
case DRM_FORMAT_AYUV:
+ case DRM_FORMAT_XYUV:
cpp = 4;
break;
case DRM_FORMAT_NV12:
diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.h
b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.h
index 9f59bf7da..86c45b368 100644
--- a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.h
+++ b/tests/util/piglit-framework-gl/piglit_drm_dma_buf.h
@@ -52,6 +52,10 @@
#define DRM_FORMAT_P016 fourcc_code('P', '0', '1', '6') /* 2x2
subsampled Cb:Cr plane 16 bits per channel */
#endif
+#ifndef DRM_FORMAT_XYUV
+#define DRM_FORMAT_XYUV fourcc_code('X', 'Y', 'U', 'V') /* 8 bits
per channel and no subsampling */
+#endif
+
/* added in libdrm 2.4.95 */
#ifndef DRM_FORMAT_INVALID
#define DRM_FORMAT_INVALID 0
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/1] viewport-scissors-clamp: to test the 2d scissors rect clamping
On Wed, Feb 20, 2019 at 10:22:18PM +0200, Eleni Maria Stea wrote:
> A test to check the 2D scissors rect clamping and to reproduce the
> following bug on i965:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108999
> ---
> tests/general/CMakeLists.gl.txt | 1 +
> tests/general/viewport-scissors-clamp.c | 143
This name of this test is misleading as it doesn't call glScissor().
> tests/opengl.py | 1 +
> 3 files changed, 145 insertions(+)
> create mode 100644 tests/general/viewport-scissors-clamp.c
>
> diff --git a/tests/general/CMakeLists.gl.txt b/tests/general/CMakeLists.gl.txt
> index 83189fc42..e60e47cbe 100644
> --- a/tests/general/CMakeLists.gl.txt
> +++ b/tests/general/CMakeLists.gl.txt
> @@ -132,5 +132,6 @@ piglit_add_executable (clear-accum clear-accum.c)
> piglit_add_executable (vs-point_size-zero vs-point_size-zero.c)
> piglit_add_executable (triangle-guardband-viewport
> triangle-guardband-viewport.c)
> piglit_add_executable (teximage-scale-bias teximage-scale-bias.c)
> +piglit_add_executable (viewport-scissors-clamp viewport-scissors-clamp.c)
>
> # vim: ft=cmake:
> diff --git a/tests/general/viewport-scissors-clamp.c
> b/tests/general/viewport-scissors-clamp.c
> new file mode 100644
> index 0..590e294a3
> --- /dev/null
> +++ b/tests/general/viewport-scissors-clamp.c
> @@ -0,0 +1,143 @@
> +/*
> + * Copyright © 2019 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Author:
> + *Eleni Maria Stea
> + */
> +
> +/* The purpose of this test is to validate the 2d scissors bbox clamping
This is more validating viewport clamping isn't it?
> + * when the Y is flipped (0 on top). It can be used to reproduce this bug:
> + * https://bugs.freedesktop.org/show_bug.cgi?id=108999
> + * and test the fix: https://patchwork.freedesktop.org/series/53830/
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +int win_width = 800;
> +int win_height = 600;
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +config.supports_gl_compat_version = 20;
> +config.window_width = win_width;
> +config.window_height = win_height;
Have you considered hardcoding these values?
> +config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
> +config.khr_no_error_support = PIGLIT_NO_ERRORS;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +static int piglit_error;
> +static unsigned int vao, vbo;
> +static unsigned int sdrprog;
> +static const float varr[] = { -1, -1, 1, -1, 1, 1, -1, -1, 1, 1, -1, 1 };
> +
> +static const char *vsdr_src =
> + "attribute vec4 vertex;\n"
> + "void main()\n" "{\n" "gl_Position = vertex;\n" "}\n";
> +
> +static const char *fsdr_src =
> + "void main()\n"
> + "{\n" "gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);\n" "}\n";
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> + unsigned int vsdr, fsdr;
> + int status;
> +
> + glGenBuffers(1, );
> + glBindBuffer(GL_ARRAY_BUFFER, vbo);
> + glBufferData(GL_ARRAY_BUFFER, sizeof varr, varr, GL_STATIC_DRAW);
> +
> + glGenVertexArrays(1, );
> + glBindVertexArray(vao);
> + glEnableVertexAttribArray(0);
> + glVertexAttribPointer(0, 2, GL_FLOAT, GL_FALSE, 0, 0);
> + glBindBuffer(GL_ARRAY_BUFFER, 0);
> + glBindVertexArray(0);
> +
> + /* create shaders */
> +
> + vsdr = glCreateShader(GL_VERTEX_SHADER);
> + glShaderSource(vsdr, 1, _src, 0);
> + glCompileShader(vsdr);
> + glGetShaderiv(vsdr, GL_COMPILE_STATUS, );
> + if (!status) {
> + fprintf(stderr, "failed to compile vertex shader\n");
> + piglit_error = 1;
> + return;
> + }
> + fsdr = glCreateShader(GL_FRAGMENT_SHADER);
> + glShaderSource(fsdr, 1, _src, 0);
> + glCompileShader(fsdr);
> + glGetShaderiv(fsdr, GL_COMPILE_STATUS, );
> + if (!status) {
> +
Re: [Piglit] [PATCH 0/3] arb_enhanced_layouts: minor clean-up and one bugfix
series: Reviewed-by: Timothy Arceri Thanks! On 21/2/19 3:06 am, Alejandro Piñeiro wrote: We found this issues while working with ARB_gl_spirv, but all those are independent of it, so we are sending independently. Alejandro Piñeiro (2): arb_enhanced_layouts: don't call glLinkProgram twice arb_enhanced_layouts: use consistent test names Antia Puentes (1): arb_enhanced_layouts: Fix error in subtest result reporting tests/opengl.py| 2 +- .../transform-feedback-layout-qualifiers.c | 3 ++- .../arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 109702] New: Bug tests
https://bugs.freedesktop.org/show_bug.cgi?id=109702 Bug ID: 109702 Summary: Bug tests Product: piglit Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Crucible Assignee: piglit@lists.freedesktop.org Reporter: jawanjal.kalyan...@gmail.com QA Contact: piglit@lists.freedesktop.org CC: ja...@jlekstrand.net -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 109700] New: Infrastructure issues
https://bugs.freedesktop.org/show_bug.cgi?id=109700 Bug ID: 109700 Summary: Infrastructure issues Product: piglit Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: infrastructure Assignee: baker.dyla...@gmail.com Reporter: jawanjal.kalyan...@gmail.com QA Contact: piglit@lists.freedesktop.org -- You are receiving this mail because: You are the QA Contact for the bug.___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 109699] New: Unexpected
https://bugs.freedesktop.org/show_bug.cgi?id=109699 Bug ID: 109699 Summary: Unexpected Product: piglit Version: unspecified Hardware: Other OS: All Status: NEW Severity: blocker Priority: medium Component: tests Assignee: piglit@lists.freedesktop.org Reporter: viraj.deshmukh...@gmail.com QA Contact: piglit@lists.freedesktop.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/3] arb_enhanced_layouts: don't call glLinkProgram twice
On 20/02/2019 16:06, Alejandro Piñeiro wrote: GLSL codepath uses piglit_build_simple_program_multiple_shaders, that already calls glLinkProgram. Minor thing, but makes debug the test more easy. Reviewed-by: Lionel Landwerlin --- .../transform-feedback-layout-qualifiers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c index 709df75f8..f2a558e34 100644 --- a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c +++ b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c @@ -131,6 +131,8 @@ compile_spirv_program(GLenum shader_type, glAttachShader(prog, shader); glDeleteShader(shader); + glLinkProgram(prog); + return prog; } @@ -187,7 +189,6 @@ build_and_use_program(const struct test_config *config) free(gs_text); } - glLinkProgram(prog); if (!piglit_link_check_status(prog)) piglit_report_result(PIGLIT_FAIL); if (!piglit_check_gl_error(GL_NO_ERROR)) ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 1/1] viewport-scissors-clamp: to test the 2d scissors rect clamping
A test to check the 2D scissors rect clamping and to reproduce the
following bug on i965:
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108999
---
tests/general/CMakeLists.gl.txt | 1 +
tests/general/viewport-scissors-clamp.c | 143
tests/opengl.py | 1 +
3 files changed, 145 insertions(+)
create mode 100644 tests/general/viewport-scissors-clamp.c
diff --git a/tests/general/CMakeLists.gl.txt b/tests/general/CMakeLists.gl.txt
index 83189fc42..e60e47cbe 100644
--- a/tests/general/CMakeLists.gl.txt
+++ b/tests/general/CMakeLists.gl.txt
@@ -132,5 +132,6 @@ piglit_add_executable (clear-accum clear-accum.c)
piglit_add_executable (vs-point_size-zero vs-point_size-zero.c)
piglit_add_executable (triangle-guardband-viewport
triangle-guardband-viewport.c)
piglit_add_executable (teximage-scale-bias teximage-scale-bias.c)
+piglit_add_executable (viewport-scissors-clamp viewport-scissors-clamp.c)
# vim: ft=cmake:
diff --git a/tests/general/viewport-scissors-clamp.c
b/tests/general/viewport-scissors-clamp.c
new file mode 100644
index 0..590e294a3
--- /dev/null
+++ b/tests/general/viewport-scissors-clamp.c
@@ -0,0 +1,143 @@
+/*
+ * Copyright © 2019 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ * Author:
+ *Eleni Maria Stea
+ */
+
+/* The purpose of this test is to validate the 2d scissors bbox clamping
+ * when the Y is flipped (0 on top). It can be used to reproduce this bug:
+ * https://bugs.freedesktop.org/show_bug.cgi?id=108999
+ * and test the fix: https://patchwork.freedesktop.org/series/53830/
+ */
+
+#include "piglit-util-gl.h"
+
+int win_width = 800;
+int win_height = 600;
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+config.supports_gl_compat_version = 20;
+config.window_width = win_width;
+config.window_height = win_height;
+config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
+config.khr_no_error_support = PIGLIT_NO_ERRORS;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+static int piglit_error;
+static unsigned int vao, vbo;
+static unsigned int sdrprog;
+static const float varr[] = { -1, -1, 1, -1, 1, 1, -1, -1, 1, 1, -1, 1 };
+
+static const char *vsdr_src =
+ "attribute vec4 vertex;\n"
+ "void main()\n" "{\n" "gl_Position = vertex;\n" "}\n";
+
+static const char *fsdr_src =
+ "void main()\n"
+ "{\n" "gl_FragColor = vec4(0.0, 1.0, 0.0, 1.0);\n" "}\n";
+
+void
+piglit_init(int argc, char **argv)
+{
+ unsigned int vsdr, fsdr;
+ int status;
+
+ glGenBuffers(1, );
+ glBindBuffer(GL_ARRAY_BUFFER, vbo);
+ glBufferData(GL_ARRAY_BUFFER, sizeof varr, varr, GL_STATIC_DRAW);
+
+ glGenVertexArrays(1, );
+ glBindVertexArray(vao);
+ glEnableVertexAttribArray(0);
+ glVertexAttribPointer(0, 2, GL_FLOAT, GL_FALSE, 0, 0);
+ glBindBuffer(GL_ARRAY_BUFFER, 0);
+ glBindVertexArray(0);
+
+ /* create shaders */
+
+ vsdr = glCreateShader(GL_VERTEX_SHADER);
+ glShaderSource(vsdr, 1, _src, 0);
+ glCompileShader(vsdr);
+ glGetShaderiv(vsdr, GL_COMPILE_STATUS, );
+ if (!status) {
+ fprintf(stderr, "failed to compile vertex shader\n");
+ piglit_error = 1;
+ return;
+ }
+ fsdr = glCreateShader(GL_FRAGMENT_SHADER);
+ glShaderSource(fsdr, 1, _src, 0);
+ glCompileShader(fsdr);
+ glGetShaderiv(fsdr, GL_COMPILE_STATUS, );
+ if (!status) {
+ fprintf(stderr, "failed to compile pixel shader\n");
+ piglit_error = 1;
+ return;
+ }
+
+ sdrprog = glCreateProgram();
+ glAttachShader(sdrprog, vsdr);
+ glAttachShader(sdrprog, fsdr);
+
+ glBindAttribLocation(sdrprog, 0, "vertex");
+ glLinkProgram(sdrprog);
+
+ glGetProgramiv(sdrprog, GL_LINK_STATUS, );
+ if (!status) {
+
Re: [Piglit] [PATCH] tests/shaders/bug-109601: drop ARB_shader_storage_buffer_object requirement
Quoting Lionel Landwerlin (2019-02-15 10:08:07)
> We're failing this test on Sandybridge because we're requiring an
> extension that isn't necessary. This is a leftover from a previous
> iteration of the test.
>
> Signed-off-by: Lionel Landwerlin
> Reported-by: Mark Janes
> Fixes: ffb5627758eb77 ("shaders: Reproduce a bug in the i965/anv backend
> compiler")
> ---
> tests/shaders/glsl-bug-109601.shader_test | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/shaders/glsl-bug-109601.shader_test
> b/tests/shaders/glsl-bug-109601.shader_test
> index c060233e9..0e39e03d2 100644
> --- a/tests/shaders/glsl-bug-109601.shader_test
> +++ b/tests/shaders/glsl-bug-109601.shader_test
> @@ -6,7 +6,6 @@ GLSL >= 3.30
>
> [fragment shader]
> #version 330
> -#extension GL_ARB_shader_storage_buffer_object: require
>
> uniform int v1;
> uniform float v2;
> --
> 2.20.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Dylan Baker
signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 0/3] arb_enhanced_layouts: minor clean-up and one bugfix
Quoting Alejandro Piñeiro (2019-02-20 08:06:11) > We found this issues while working with ARB_gl_spirv, but all those > are independent of it, so we are sending independently. > > Alejandro Piñeiro (2): > arb_enhanced_layouts: don't call glLinkProgram twice > arb_enhanced_layouts: use consistent test names > > Antia Puentes (1): > arb_enhanced_layouts: Fix error in subtest result reporting > > tests/opengl.py| 2 +- > .../transform-feedback-layout-qualifiers.c | 3 ++- > .../arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) > > -- > 2.19.1 > I don't feel qualified to review patch 1, but for 2 & 3: Reviewed-by: Dylan Baker signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 2/3] arb_enhanced_layouts: Fix error in subtest result reporting
From: Antia Puentes
---
.../arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
index 44d1aef9a..05175b588 100644
--- a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
+++ b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
@@ -139,7 +139,7 @@ piglit_init(int argc, char **argv)
max_active = false;
}
- piglit_report_subtest_result(active_res ? PIGLIT_PASS : PIGLIT_FAIL,
+ piglit_report_subtest_result(max_active ? PIGLIT_PASS : PIGLIT_FAIL,
"Query MAX_NUM_ACTIVE_VARIABLES");
GLenum props[] = {GL_BUFFER_BINDING, GL_NUM_ACTIVE_VARIABLES,
--
2.19.1
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 1/3] arb_enhanced_layouts: don't call glLinkProgram twice
GLSL codepath uses piglit_build_simple_program_multiple_shaders, that already calls glLinkProgram. Minor thing, but makes debug the test more easy. --- .../transform-feedback-layout-qualifiers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c index 709df75f8..f2a558e34 100644 --- a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c +++ b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-qualifiers.c @@ -131,6 +131,8 @@ compile_spirv_program(GLenum shader_type, glAttachShader(prog, shader); glDeleteShader(shader); + glLinkProgram(prog); + return prog; } @@ -187,7 +189,6 @@ build_and_use_program(const struct test_config *config) free(gs_text); } - glLinkProgram(prog); if (!piglit_link_check_status(prog)) piglit_report_result(PIGLIT_FAIL); if (!piglit_check_gl_error(GL_NO_ERROR)) -- 2.19.1 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 3/3] arb_enhanced_layouts: use consistent test names
Before this commit a piglit run like this: ./piglit run tests/all.py -t arb_enhanced_layouts-transform-feedback ../piglit_results/foo Would include the layout-qualifiers tests, but not the layout-query one. --- tests/opengl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/opengl.py b/tests/opengl.py index 8e84e2cfc..35a49b443 100644 --- a/tests/opengl.py +++ b/tests/opengl.py @@ -2335,7 +2335,7 @@ with profile.test_list.group_manager( 'arb_enhanced_layouts-transform-feedback-layout-qualifiers_gs_max', run_concurrent=False) g(['arb_enhanced_layouts-transform-feedback-layout-query-api'], - 'transform-feedback-layout-query-api') + 'arb_enhanced_layouts-transform-feedback-layout-query-api') # Group ARB_explicit_attrib_location with profile.test_list.group_manager( -- 2.19.1 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 0/3] arb_enhanced_layouts: minor clean-up and one bugfix
We found this issues while working with ARB_gl_spirv, but all those are independent of it, so we are sending independently. Alejandro Piñeiro (2): arb_enhanced_layouts: don't call glLinkProgram twice arb_enhanced_layouts: use consistent test names Antia Puentes (1): arb_enhanced_layouts: Fix error in subtest result reporting tests/opengl.py| 2 +- .../transform-feedback-layout-qualifiers.c | 3 ++- .../arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) -- 2.19.1 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [Mesa-dev] GitLab migration of Piglit
Given the discussion below, I think we'll make piglit a sub-project of mesa. Those who need commit access to piglit but not mesa can be added directly to the piglit project. Hi list. Since piglit was also moved to the gitlab, same with mesa, our team is interested in process workflow for contributing to it. Before (again, same with mesa) we created mailing threads and after reviewing test was pushed to master by somebody with access. Now mesa got a new possibility for reviewing - merge requests, which doesn't exist in piglit. Also, according to Jason's conclusion, anybody can request commit access to piglit. But in this case how the review process will be done? Thank you in advance. On 6/7/18 10:18 AM, Daniel Stone wrote: Hi Emil, On 5 June 2018 at 18:21, Emil Velikov wrote: On 5 June 2018 at 18:02, Daniel Stone wrote: drm-gralloc.git Empty - please nuke, alongside bugzilla & other infra. Done. drm.git Out of curiosity - this and others (say igt) projects are accessible as mesa/$foo and drm/$foo. I'd image the same approach will be adopted in gitlab? Unfortunately not, it provides a single canonical URL rather than aliasing. But both old anongit URLs will continue to work. llvm.git Empty - nuke? Done. mesa-test.git Plain copy/paste just like xserver-test. There were no extra branches/patches wrt the usual repos. Nuke? Done. libwsbm.git linux-agp-compat.git vmwgfx.git Might want to check with the VMware people about these. I'm suspecting that the developers are not keeping a close eye on mesa-dev@ I'm going to follow up with them separately about vmwgfx.git. Cheers, Daniel ___ mesa-dev mailing list mesa-...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
