Re: [Piglit] [PATCH 1/3] cmake: use proper WAYLAND_INCLUDE_DIRS variable
Ping. Also CCing a few people who have touched this file in the past
and might be happy reviewing cmake code!
Ross
On Fri, 30 Nov 2018 at 10:45, Ross Burton wrote:
>
> From: Pascal Bach
>
> WAYLAND_wayland-client_INCLUDEDIR is an internal variable and is not correctly
> set when cross compiling. WAYLAND_INCLUDE_DIRS includes the correct path even
> when cross compiling.
>
> Signed-off-by: Pascal Bach
> ---
> tests/util/CMakeLists.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt
> index a5f080156..a303a9f58 100644
> --- a/tests/util/CMakeLists.txt
> +++ b/tests/util/CMakeLists.txt
> @@ -97,7 +97,7 @@ if(PIGLIT_USE_WAFFLE)
> piglit-framework-gl/piglit_wl_framework.c
> )
> list(APPEND UTIL_GL_INCLUDES
> - ${WAYLAND_wayland-client_INCLUDEDIR}
> + ${WAYLAND_INCLUDE_DIRS}
> )
> endif()
> if(PIGLIT_HAS_X11)
> --
> 2.11.0
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] tests: only run rounding tests if FE_UPWARD is present
On Fri, 30 Nov 2018 at 17:44, Eric Engestrom wrote: > On Friday, 2018-11-30 16:33:23 +, Ross Burton wrote: > > On ARM, musl does not define FE_* when the architecture does not have VFP > > (which > > is the right interpretation). > > > > As these tests depend on calling fesetround(), skip the test if FE_UPWARD > > isn't > > available. > > > > Signed-off-by: Ross Burton > > Maybe add to the commit message when pushing: > > From the fesetround(3) man page: > > Each of the macros FE_TONEAREST, FE_UPWARD, FE_DOWNWARD, and > > FE_TOWARDZERO is defined when the implementation supports getting > > and setting the corresponding rounding direction. > > Reviewed-by: Eric Engestrom I can revise the message and re-submit, but I can't push to piglit. Ross ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h
Okay, revised patch submitted, which hopefully does the right thing this time.
Ross
On Fri, 30 Nov 2018 at 15:54, Burton, Ross wrote:
>
> Erm, yeah, sorry about that. Grabbing a patch that we've been
> shipping without actually looking at it.
>
> Ross
> On Fri, 30 Nov 2018 at 12:37, Eric Engestrom wrote:
> >
> > On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote:
> > > From: Khem Raj
> > >
> > > On ARM, musl does not define FE_* when arch does not have
> > > VFP, (which is right interpretation), therefore check if
> > > it is defined before using it.
> > >
> > > Fixes errors like:
> > >
> > > tests/general/roundmode-pixelstore.c:82:19: error: 'FE_UPWARD' undeclared
> > > (first use in this function)
> > > ret = fesetround(FE_UPWARD);
> > >^
> > >
> > > Signed-off-by: Khem Raj
> > > ---
> > > tests/general/roundmode-getintegerv.c | 2 ++
> > > tests/general/roundmode-pixelstore.c | 2 ++
> > > 2 files changed, 4 insertions(+)
> > >
> > > diff --git a/tests/general/roundmode-getintegerv.c
> > > b/tests/general/roundmode-getintegerv.c
> > > index 28ecfaf55..5c275797b 100644
> > > --- a/tests/general/roundmode-getintegerv.c
> > > +++ b/tests/general/roundmode-getintegerv.c
> > > @@ -81,7 +81,9 @@ piglit_init(int argc, char **argv)
> > > {
> > > int ret;
> > > bool pass = true;
> > > +#ifdef FE_UPWARD
> > > ret = fesetround(FE_UPWARD);
> > > +#endif
> > > if (ret != 0) {
> >
> > You'll need a #else that sets ret, otherwise you're pretty obviously
> > going to jump based on an uninitialised variable here :/
> >
> > > printf("Couldn't set rounding mode\n");
> > > piglit_report_result(PIGLIT_SKIP);
> > > diff --git a/tests/general/roundmode-pixelstore.c
> > > b/tests/general/roundmode-pixelstore.c
> > > index 8a029b257..51951a0d9 100644
> > > --- a/tests/general/roundmode-pixelstore.c
> > > +++ b/tests/general/roundmode-pixelstore.c
> > > @@ -81,7 +81,9 @@ piglit_init(int argc, char **argv)
> > > {
> > > int ret;
> > > bool pass = true;
> > > +#ifdef FE_UPWARD
> > > ret = fesetround(FE_UPWARD);
> > > +#endif
> > > if (ret != 0) {
> > > printf("Couldn't set rounding mode\n");
> > > piglit_report_result(PIGLIT_SKIP);
> > > --
> > > 2.11.0
> > >
> > > ___
> > > Piglit mailing list
> > > Piglit@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h
Erm, yeah, sorry about that. Grabbing a patch that we've been
shipping without actually looking at it.
Ross
On Fri, 30 Nov 2018 at 12:37, Eric Engestrom wrote:
>
> On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote:
> > From: Khem Raj
> >
> > On ARM, musl does not define FE_* when arch does not have
> > VFP, (which is right interpretation), therefore check if
> > it is defined before using it.
> >
> > Fixes errors like:
> >
> > tests/general/roundmode-pixelstore.c:82:19: error: 'FE_UPWARD' undeclared
> > (first use in this function)
> > ret = fesetround(FE_UPWARD);
> >^
> >
> > Signed-off-by: Khem Raj
> > ---
> > tests/general/roundmode-getintegerv.c | 2 ++
> > tests/general/roundmode-pixelstore.c | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/tests/general/roundmode-getintegerv.c
> > b/tests/general/roundmode-getintegerv.c
> > index 28ecfaf55..5c275797b 100644
> > --- a/tests/general/roundmode-getintegerv.c
> > +++ b/tests/general/roundmode-getintegerv.c
> > @@ -81,7 +81,9 @@ piglit_init(int argc, char **argv)
> > {
> > int ret;
> > bool pass = true;
> > +#ifdef FE_UPWARD
> > ret = fesetround(FE_UPWARD);
> > +#endif
> > if (ret != 0) {
>
> You'll need a #else that sets ret, otherwise you're pretty obviously
> going to jump based on an uninitialised variable here :/
>
> > printf("Couldn't set rounding mode\n");
> > piglit_report_result(PIGLIT_SKIP);
> > diff --git a/tests/general/roundmode-pixelstore.c
> > b/tests/general/roundmode-pixelstore.c
> > index 8a029b257..51951a0d9 100644
> > --- a/tests/general/roundmode-pixelstore.c
> > +++ b/tests/general/roundmode-pixelstore.c
> > @@ -81,7 +81,9 @@ piglit_init(int argc, char **argv)
> > {
> > int ret;
> > bool pass = true;
> > +#ifdef FE_UPWARD
> > ret = fesetround(FE_UPWARD);
> > +#endif
> > if (ret != 0) {
> > printf("Couldn't set rounding mode\n");
> > piglit_report_result(PIGLIT_SKIP);
> > --
> > 2.11.0
> >
> > ___
> > Piglit mailing list
> > Piglit@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] arb_texture_view: fix security format warnings
On Fri, 30 Nov 2018 at 12:45, Eric Engestrom wrote: > On Friday, 2018-11-30 10:45:06 +, Ross Burton wrote: > I'm not sure this macro has any reason to exist though, it's only used once, > doesn't do any macro magic, uses each of its params exactly once... > I would really recommend dropping it. Yes, that's a good point: V2 sent. Ross ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
