Re: [Piglit] [PATCH] arb_copy_image-targets: Add comments to silence Coverity defects.

2015-01-20 Thread Jason Ekstrand 
Fine with me

Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com

On Mon, Jan 19, 2015 at 1:48 PM, Vinson Lee v...@freedesktop.org wrote:

 Silence Coverity missing break in switch defects.

 Signed-off-by: Vinson Lee v...@freedesktop.org
 ---
  tests/spec/arb_copy_image/targets.c | 2 ++
  1 file changed, 2 insertions(+)

 diff --git a/tests/spec/arb_copy_image/targets.c
 b/tests/spec/arb_copy_image/targets.c
 index 86edeca..333631c 100644
 --- a/tests/spec/arb_copy_image/targets.c
 +++ b/tests/spec/arb_copy_image/targets.c
 @@ -65,12 +65,14 @@ image_init(struct image *image, GLenum target, int
 width, int height, int depth)
 switch (target) {
 case GL_TEXTURE_CUBE_MAP:
 assert(depth == 6);
 +   /* Fall through. */
 case GL_TEXTURE_CUBE_MAP_ARRAY_ARB:
 assert(width == height);
 assert(depth % 6 == 0);
 break;
 case GL_TEXTURE_1D:
 assert(height == 1);
 +   /* Fall through. */
 case GL_TEXTURE_2D:
 case GL_TEXTURE_RECTANGLE:
 assert(depth == 1);
 --
 2.2.1

 ___
 Piglit mailing list
 Piglit@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/piglit

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_copy_image-targets: Add comments to silence Coverity defects.

2015-01-19 Thread Vinson Lee 
Silence Coverity missing break in switch defects.

Signed-off-by: Vinson Lee v...@freedesktop.org
---
 tests/spec/arb_copy_image/targets.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/spec/arb_copy_image/targets.c 
b/tests/spec/arb_copy_image/targets.c
index 86edeca..333631c 100644
--- a/tests/spec/arb_copy_image/targets.c
+++ b/tests/spec/arb_copy_image/targets.c
@@ -65,12 +65,14 @@ image_init(struct image *image, GLenum target, int width, 
int height, int depth)
switch (target) {
case GL_TEXTURE_CUBE_MAP:
assert(depth == 6);
+   /* Fall through. */
case GL_TEXTURE_CUBE_MAP_ARRAY_ARB:
assert(width == height);
assert(depth % 6 == 0);
break;
case GL_TEXTURE_1D:
assert(height == 1);
+   /* Fall through. */
case GL_TEXTURE_2D:
case GL_TEXTURE_RECTANGLE:
assert(depth == 1);
-- 
2.2.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_copy_image-targets: Add comments to silence Coverity defects.

2014-12-15 Thread Vinson Lee 
Silence Coverity missing break in switch defects.

Signed-off-by: Vinson Lee v...@freedesktop.org
---
 tests/spec/arb_copy_image/targets.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/spec/arb_copy_image/targets.c 
b/tests/spec/arb_copy_image/targets.c
index 86edeca..333631c 100644
--- a/tests/spec/arb_copy_image/targets.c
+++ b/tests/spec/arb_copy_image/targets.c
@@ -65,12 +65,14 @@ image_init(struct image *image, GLenum target, int width, 
int height, int depth)
switch (target) {
case GL_TEXTURE_CUBE_MAP:
assert(depth == 6);
+   /* Fall through. */
case GL_TEXTURE_CUBE_MAP_ARRAY_ARB:
assert(width == height);
assert(depth % 6 == 0);
break;
case GL_TEXTURE_1D:
assert(height == 1);
+   /* Fall through. */
case GL_TEXTURE_2D:
case GL_TEXTURE_RECTANGLE:
assert(depth == 1);
-- 
1.9.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit