Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support
On Tue, 2016-11-08 at 12:59 -0500, Ilia Mirkin wrote: > Could you update the change description to say precisely what each of > these things do? It's hard to review otherwise since I have to go out > and look up the things I don't know or have since forgotten. Done and sent again for review. I hope the changelog is explanatory enough ☺ > > -ilia > > On Sat, Oct 22, 2016 at 5:19 PM, Andres Gomez wrote: > > Provides support for highlighting incorrect indentation. > > > > v2: python-mode inherits from prog-mode > > v3: Removed too long lines trail highlighting, as suggested by Ilia > > Mirkin. > > > > Signed-off-by: Andres Gomez > > --- > > .dir-locals.el | 17 + > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/.dir-locals.el b/.dir-locals.el > > index 3bdca17..2a37aaf 100644 > > --- a/.dir-locals.el > > +++ b/.dir-locals.el > > @@ -1,11 +1,20 @@ > > ((nil . ((indent-tabs-mode . t) > > (tab-width . 8) > > -(show-trailing-whitespace . t))) > > +(show-trailing-whitespace . t) > > +(whitespace-style face indentation) > > +(whitespace-line-column . 79))) > > (prog-mode . > > - ((c-file-style . "linux"))) > > + ((c-file-style . "linux") > > +(eval ignore-errors > > + (require 'whitespace) > > + (whitespace-mode 1 > > (cmake-mode . > > -((cmake-tab-width . 8))) > > +((cmake-tab-width . 8) > > + (eval ignore-errors > > + (require 'whitespace) > > + (whitespace-mode 1 > > (python-mode . > > ((indent-tabs-mode . nil) > > - (tab-width . 4))) > > + (tab-width . 4) > > + (whitespace-line-column . 80))) > > ) > > -- > > 2.9.3 > > > > > -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support
Could you update the change description to say precisely what each of these things do? It's hard to review otherwise since I have to go out and look up the things I don't know or have since forgotten. -ilia On Sat, Oct 22, 2016 at 5:19 PM, Andres Gomez wrote: > Provides support for highlighting incorrect indentation. > > v2: python-mode inherits from prog-mode > v3: Removed too long lines trail highlighting, as suggested by Ilia > Mirkin. > > Signed-off-by: Andres Gomez > --- > .dir-locals.el | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index 3bdca17..2a37aaf 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -1,11 +1,20 @@ > ((nil . ((indent-tabs-mode . t) > (tab-width . 8) > -(show-trailing-whitespace . t))) > +(show-trailing-whitespace . t) > +(whitespace-style face indentation) > +(whitespace-line-column . 79))) > (prog-mode . > - ((c-file-style . "linux"))) > + ((c-file-style . "linux") > +(eval ignore-errors > + (require 'whitespace) > + (whitespace-mode 1 > (cmake-mode . > -((cmake-tab-width . 8))) > +((cmake-tab-width . 8) > + (eval ignore-errors > + (require 'whitespace) > + (whitespace-mode 1 > (python-mode . > ((indent-tabs-mode . nil) > - (tab-width . 4))) > + (tab-width . 4) > + (whitespace-line-column . 80))) > ) > -- > 2.9.3 > ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support
If nobody says otherwise, I will land this by the beginning of next week. On Sun, 2016-10-23 at 00:19 +0300, Andres Gomez wrote: > Provides support for highlighting incorrect indentation. > > v2: python-mode inherits from prog-mode > v3: Removed too long lines trail highlighting, as suggested by Ilia > Mirkin. > > Signed-off-by: Andres Gomez > --- > .dir-locals.el | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index 3bdca17..2a37aaf 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -1,11 +1,20 @@ > ((nil . ((indent-tabs-mode . t) >(tab-width . 8) > - (show-trailing-whitespace . t))) > + (show-trailing-whitespace . t) > + (whitespace-style face indentation) > + (whitespace-line-column . 79))) > (prog-mode . > - ((c-file-style . "linux"))) > + ((c-file-style . "linux") > + (eval ignore-errors > +(require 'whitespace) > +(whitespace-mode 1 > (cmake-mode . > - ((cmake-tab-width . 8))) > + ((cmake-tab-width . 8) > + (eval ignore-errors > + (require 'whitespace) > + (whitespace-mode 1 > (python-mode . > ((indent-tabs-mode . nil) > -(tab-width . 4))) > +(tab-width . 4) > +(whitespace-line-column . 80))) > ) > -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] dir-locals.el: Adds whitespace support
Provides support for highlighting incorrect indentation. v2: python-mode inherits from prog-mode v3: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez --- .dir-locals.el | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 3bdca17..2a37aaf 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -1,11 +1,20 @@ ((nil . ((indent-tabs-mode . t) (tab-width . 8) -(show-trailing-whitespace . t))) +(show-trailing-whitespace . t) +(whitespace-style face indentation) +(whitespace-line-column . 79))) (prog-mode . - ((c-file-style . "linux"))) + ((c-file-style . "linux") +(eval ignore-errors + (require 'whitespace) + (whitespace-mode 1 (cmake-mode . -((cmake-tab-width . 8))) +((cmake-tab-width . 8) + (eval ignore-errors + (require 'whitespace) + (whitespace-mode 1 (python-mode . ((indent-tabs-mode . nil) - (tab-width . 4))) + (tab-width . 4) + (whitespace-line-column . 80))) ) -- 2.9.3 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
