Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-27 Thread Timothy Arceri 

On 27/06/17 17:58, Samuel Pitoiset wrote:




On 06/27/2017 02:19 AM, Timothy Arceri wrote:

On 26/06/17 19:04, Samuel Pitoiset wrote:


Looks like you forgot to update fbo-storage-formats.c.


It's updated. Did you mean something else?


I meant, there is a GL_INVALID_ENUM which is not handled correctly, no?

Ok, I see it this time. Thanks.







With that fixed, patch is:

Reviewed-by: Samuel Pitoiset 

Thanks!

On 06/26/2017 08:00 AM, Timothy Arceri wrote:

---
  tests/fbo/fbo-1d.c |  1 +
  tests/fbo/fbo-3d.c |  1 +
  tests/fbo/fbo-alpha.c  |  1 +
  tests/fbo/fbo-alphatest-formats.c  |  1 +
  tests/fbo/fbo-alphatest-nocolor-ff.c   |  1 +
  tests/fbo/fbo-alphatest-nocolor.c  |  1 +
  tests/fbo/fbo-array.c  |  1 +
  tests/fbo/fbo-bind-renderbuffer.c  |  9 --
  tests/fbo/fbo-blending-formats.c   |  1 +
  tests/fbo/fbo-blit-d24s8.c |  1 +
  tests/fbo/fbo-blit-stretch.cpp |  1 +
  tests/fbo/fbo-blit.c   |  1 +
  tests/fbo/fbo-clear-formats.c  |  1 +
  tests/fbo/fbo-clearmipmap.c|  1 +
  tests/fbo/fbo-colormask-formats.c  |  1 +
  tests/fbo/fbo-copypix.c|  1 +
  tests/fbo/fbo-copyteximage-simple.c|  1 +
  tests/fbo/fbo-copyteximage.c   |  1 +
  tests/fbo/fbo-cubemap.c|  1 +
  tests/fbo/fbo-depth-array.c|  1 +
  tests/fbo/fbo-depth-tex1d.c|  1 +
  tests/fbo/fbo-depth.c  |  1 +
  tests/fbo/fbo-depthtex.c   |  1 +
  tests/fbo/fbo-deriv.c  |  1 +
  tests/fbo/fbo-draw-buffers-blend.c |  1 +
  tests/fbo/fbo-drawbuffers-arbfp.c  |  1 +
  tests/fbo/fbo-drawbuffers-blend-add.c  |  1 +
  tests/fbo/fbo-drawbuffers-fragcolor.c  |  1 +
  tests/fbo/fbo-drawbuffers-maxtargets.c |  1 +
  tests/fbo/fbo-drawbuffers.c|  1 +
  tests/fbo/fbo-drawbuffers2-blend.c |  1 +
  tests/fbo/fbo-drawbuffers2-colormask.c |  1 +
  tests/fbo/fbo-finish-deleted.c |  1 +
  tests/fbo/fbo-flushing-2.c |  1 +
  tests/fbo/fbo-flushing.c   |  1 +
  tests/fbo/fbo-fragcoord.c  |  1 +
  tests/fbo/fbo-fragcoord2.c |  1 +
  tests/fbo/fbo-generatemipmap-filtering.c   |  1 +
  tests/fbo/fbo-generatemipmap-formats.c |  1 +
  tests/fbo/fbo-generatemipmap-noimage.c |  1 +
  tests/fbo/fbo-generatemipmap-nonsquare.c   |  1 +
  tests/fbo/fbo-generatemipmap-npot.c|  1 +
  tests/fbo/fbo-generatemipmap-scissor.c |  1 +
  tests/fbo/fbo-generatemipmap-swizzle.c |  1 +
  tests/fbo/fbo-generatemipmap-viewport.c|  1 +
  tests/fbo/fbo-generatemipmap.c |  1 +
  .../fbo/fbo-getframebufferattachmentparameter-01.c | 36 
+-

  tests/fbo/fbo-gl_pointcoord.c  |  1 +
  tests/fbo/fbo-incomplete-invalid-texture.c |  1 +
  tests/fbo/fbo-incomplete-texture-01.c  |  1 +
  tests/fbo/fbo-incomplete-texture-02.c  |  1 +
  tests/fbo/fbo-incomplete-texture-03.c  |  1 +
  tests/fbo/fbo-incomplete-texture-04.c  |  1 +
  tests/fbo/fbo-incomplete.cpp   |  1 +
  tests/fbo/fbo-integer.c|  1 +
  tests/fbo/fbo-luminance-alpha.c|  1 +
  tests/fbo/fbo-maxsize.c|  1 +
  tests/fbo/fbo-mipmap-copypix.c |  1 +
  tests/fbo/fbo-mrt-alphatest.c  |  1 +
  tests/fbo/fbo-mrt-new-bind.c   |  1 +
  tests/fbo/fbo-nodepth-test.c   |  1 +
  tests/fbo/fbo-nostencil-test.c |  1 +
  tests/fbo/fbo-pbo-readpixels-small.c   |  1 +
  tests/fbo/fbo-readdrawpix.c|  1 +
  tests/fbo/fbo-readpixels-depth-formats.c   |  1 +
  tests/fbo/fbo-readpixels.c |  1 +
  tests/fbo/fbo-rg.c |  1 +
  tests/fbo/fbo-scissor-bitmap.c |  1 +
  tests/fbo/fbo-scissor-blit.c   |  1 +
  tests/fbo/fbo-srgb.c   |  1 +
  tests/fbo/fbo-stencil.c|  1 +
  tests/fbo/fbo-storage-completeness.c   |  5 +--
  tests/fbo/fbo-storage-formats.c|  5 +--
  tests/fbo/fbo-sys-blit.c   |  1 +
  tests/fbo/fbo-sys-sub-blit.c   |

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-27 Thread Samuel Pitoiset 



On 06/27/2017 02:19 AM, Timothy Arceri wrote:

On 26/06/17 19:04, Samuel Pitoiset wrote:


Looks like you forgot to update fbo-storage-formats.c.


It's updated. Did you mean something else?


I meant, there is a GL_INVALID_ENUM which is not handled correctly, no?





With that fixed, patch is:

Reviewed-by: Samuel Pitoiset 

Thanks!

On 06/26/2017 08:00 AM, Timothy Arceri wrote:

---
  tests/fbo/fbo-1d.c |  1 +
  tests/fbo/fbo-3d.c |  1 +
  tests/fbo/fbo-alpha.c  |  1 +
  tests/fbo/fbo-alphatest-formats.c  |  1 +
  tests/fbo/fbo-alphatest-nocolor-ff.c   |  1 +
  tests/fbo/fbo-alphatest-nocolor.c  |  1 +
  tests/fbo/fbo-array.c  |  1 +
  tests/fbo/fbo-bind-renderbuffer.c  |  9 --
  tests/fbo/fbo-blending-formats.c   |  1 +
  tests/fbo/fbo-blit-d24s8.c |  1 +
  tests/fbo/fbo-blit-stretch.cpp |  1 +
  tests/fbo/fbo-blit.c   |  1 +
  tests/fbo/fbo-clear-formats.c  |  1 +
  tests/fbo/fbo-clearmipmap.c|  1 +
  tests/fbo/fbo-colormask-formats.c  |  1 +
  tests/fbo/fbo-copypix.c|  1 +
  tests/fbo/fbo-copyteximage-simple.c|  1 +
  tests/fbo/fbo-copyteximage.c   |  1 +
  tests/fbo/fbo-cubemap.c|  1 +
  tests/fbo/fbo-depth-array.c|  1 +
  tests/fbo/fbo-depth-tex1d.c|  1 +
  tests/fbo/fbo-depth.c  |  1 +
  tests/fbo/fbo-depthtex.c   |  1 +
  tests/fbo/fbo-deriv.c  |  1 +
  tests/fbo/fbo-draw-buffers-blend.c |  1 +
  tests/fbo/fbo-drawbuffers-arbfp.c  |  1 +
  tests/fbo/fbo-drawbuffers-blend-add.c  |  1 +
  tests/fbo/fbo-drawbuffers-fragcolor.c  |  1 +
  tests/fbo/fbo-drawbuffers-maxtargets.c |  1 +
  tests/fbo/fbo-drawbuffers.c|  1 +
  tests/fbo/fbo-drawbuffers2-blend.c |  1 +
  tests/fbo/fbo-drawbuffers2-colormask.c |  1 +
  tests/fbo/fbo-finish-deleted.c |  1 +
  tests/fbo/fbo-flushing-2.c |  1 +
  tests/fbo/fbo-flushing.c   |  1 +
  tests/fbo/fbo-fragcoord.c  |  1 +
  tests/fbo/fbo-fragcoord2.c |  1 +
  tests/fbo/fbo-generatemipmap-filtering.c   |  1 +
  tests/fbo/fbo-generatemipmap-formats.c |  1 +
  tests/fbo/fbo-generatemipmap-noimage.c |  1 +
  tests/fbo/fbo-generatemipmap-nonsquare.c   |  1 +
  tests/fbo/fbo-generatemipmap-npot.c|  1 +
  tests/fbo/fbo-generatemipmap-scissor.c |  1 +
  tests/fbo/fbo-generatemipmap-swizzle.c |  1 +
  tests/fbo/fbo-generatemipmap-viewport.c|  1 +
  tests/fbo/fbo-generatemipmap.c |  1 +
  .../fbo/fbo-getframebufferattachmentparameter-01.c | 36 
+-

  tests/fbo/fbo-gl_pointcoord.c  |  1 +
  tests/fbo/fbo-incomplete-invalid-texture.c |  1 +
  tests/fbo/fbo-incomplete-texture-01.c  |  1 +
  tests/fbo/fbo-incomplete-texture-02.c  |  1 +
  tests/fbo/fbo-incomplete-texture-03.c  |  1 +
  tests/fbo/fbo-incomplete-texture-04.c  |  1 +
  tests/fbo/fbo-incomplete.cpp   |  1 +
  tests/fbo/fbo-integer.c|  1 +
  tests/fbo/fbo-luminance-alpha.c|  1 +
  tests/fbo/fbo-maxsize.c|  1 +
  tests/fbo/fbo-mipmap-copypix.c |  1 +
  tests/fbo/fbo-mrt-alphatest.c  |  1 +
  tests/fbo/fbo-mrt-new-bind.c   |  1 +
  tests/fbo/fbo-nodepth-test.c   |  1 +
  tests/fbo/fbo-nostencil-test.c |  1 +
  tests/fbo/fbo-pbo-readpixels-small.c   |  1 +
  tests/fbo/fbo-readdrawpix.c|  1 +
  tests/fbo/fbo-readpixels-depth-formats.c   |  1 +
  tests/fbo/fbo-readpixels.c |  1 +
  tests/fbo/fbo-rg.c |  1 +
  tests/fbo/fbo-scissor-bitmap.c |  1 +
  tests/fbo/fbo-scissor-blit.c   |  1 +
  tests/fbo/fbo-srgb.c   |  1 +
  tests/fbo/fbo-stencil.c|  1 +
  tests/fbo/fbo-storage-completeness.c   |  5 +--
  tests/fbo/fbo-storage-formats.c|  5 +--
  tests/fbo/fbo-sys-blit.c   |  1 +
  tests/fbo/fbo-sys-sub-blit.c   |  1 +
  tests/fbo/fbo-viewport.c   |  1 +
  76 files chan

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri 

On 26/06/17 19:04, Samuel Pitoiset wrote:


Looks like you forgot to update fbo-storage-formats.c.


It's updated. Did you mean something else?



With that fixed, patch is:

Reviewed-by: Samuel Pitoiset 

Thanks!

On 06/26/2017 08:00 AM, Timothy Arceri wrote:

---
  tests/fbo/fbo-1d.c |  1 +
  tests/fbo/fbo-3d.c |  1 +
  tests/fbo/fbo-alpha.c  |  1 +
  tests/fbo/fbo-alphatest-formats.c  |  1 +
  tests/fbo/fbo-alphatest-nocolor-ff.c   |  1 +
  tests/fbo/fbo-alphatest-nocolor.c  |  1 +
  tests/fbo/fbo-array.c  |  1 +
  tests/fbo/fbo-bind-renderbuffer.c  |  9 --
  tests/fbo/fbo-blending-formats.c   |  1 +
  tests/fbo/fbo-blit-d24s8.c |  1 +
  tests/fbo/fbo-blit-stretch.cpp |  1 +
  tests/fbo/fbo-blit.c   |  1 +
  tests/fbo/fbo-clear-formats.c  |  1 +
  tests/fbo/fbo-clearmipmap.c|  1 +
  tests/fbo/fbo-colormask-formats.c  |  1 +
  tests/fbo/fbo-copypix.c|  1 +
  tests/fbo/fbo-copyteximage-simple.c|  1 +
  tests/fbo/fbo-copyteximage.c   |  1 +
  tests/fbo/fbo-cubemap.c|  1 +
  tests/fbo/fbo-depth-array.c|  1 +
  tests/fbo/fbo-depth-tex1d.c|  1 +
  tests/fbo/fbo-depth.c  |  1 +
  tests/fbo/fbo-depthtex.c   |  1 +
  tests/fbo/fbo-deriv.c  |  1 +
  tests/fbo/fbo-draw-buffers-blend.c |  1 +
  tests/fbo/fbo-drawbuffers-arbfp.c  |  1 +
  tests/fbo/fbo-drawbuffers-blend-add.c  |  1 +
  tests/fbo/fbo-drawbuffers-fragcolor.c  |  1 +
  tests/fbo/fbo-drawbuffers-maxtargets.c |  1 +
  tests/fbo/fbo-drawbuffers.c|  1 +
  tests/fbo/fbo-drawbuffers2-blend.c |  1 +
  tests/fbo/fbo-drawbuffers2-colormask.c |  1 +
  tests/fbo/fbo-finish-deleted.c |  1 +
  tests/fbo/fbo-flushing-2.c |  1 +
  tests/fbo/fbo-flushing.c   |  1 +
  tests/fbo/fbo-fragcoord.c  |  1 +
  tests/fbo/fbo-fragcoord2.c |  1 +
  tests/fbo/fbo-generatemipmap-filtering.c   |  1 +
  tests/fbo/fbo-generatemipmap-formats.c |  1 +
  tests/fbo/fbo-generatemipmap-noimage.c |  1 +
  tests/fbo/fbo-generatemipmap-nonsquare.c   |  1 +
  tests/fbo/fbo-generatemipmap-npot.c|  1 +
  tests/fbo/fbo-generatemipmap-scissor.c |  1 +
  tests/fbo/fbo-generatemipmap-swizzle.c |  1 +
  tests/fbo/fbo-generatemipmap-viewport.c|  1 +
  tests/fbo/fbo-generatemipmap.c |  1 +
  .../fbo/fbo-getframebufferattachmentparameter-01.c | 36 
+-

  tests/fbo/fbo-gl_pointcoord.c  |  1 +
  tests/fbo/fbo-incomplete-invalid-texture.c |  1 +
  tests/fbo/fbo-incomplete-texture-01.c  |  1 +
  tests/fbo/fbo-incomplete-texture-02.c  |  1 +
  tests/fbo/fbo-incomplete-texture-03.c  |  1 +
  tests/fbo/fbo-incomplete-texture-04.c  |  1 +
  tests/fbo/fbo-incomplete.cpp   |  1 +
  tests/fbo/fbo-integer.c|  1 +
  tests/fbo/fbo-luminance-alpha.c|  1 +
  tests/fbo/fbo-maxsize.c|  1 +
  tests/fbo/fbo-mipmap-copypix.c |  1 +
  tests/fbo/fbo-mrt-alphatest.c  |  1 +
  tests/fbo/fbo-mrt-new-bind.c   |  1 +
  tests/fbo/fbo-nodepth-test.c   |  1 +
  tests/fbo/fbo-nostencil-test.c |  1 +
  tests/fbo/fbo-pbo-readpixels-small.c   |  1 +
  tests/fbo/fbo-readdrawpix.c|  1 +
  tests/fbo/fbo-readpixels-depth-formats.c   |  1 +
  tests/fbo/fbo-readpixels.c |  1 +
  tests/fbo/fbo-rg.c |  1 +
  tests/fbo/fbo-scissor-bitmap.c |  1 +
  tests/fbo/fbo-scissor-blit.c   |  1 +
  tests/fbo/fbo-srgb.c   |  1 +
  tests/fbo/fbo-stencil.c|  1 +
  tests/fbo/fbo-storage-completeness.c   |  5 +--
  tests/fbo/fbo-storage-formats.c|  5 +--
  tests/fbo/fbo-sys-blit.c   |  1 +
  tests/fbo/fbo-sys-sub-blit.c   |  1 +
  tests/fbo/fbo-viewport.c   |  1 +
  76 files changed, 105 insertions(+), 22 deletions(-)

diff --git a/tests/fbo/fbo-1d.c b/tests/fbo/fbo-1d.c
index 63f36be..dfb9567 100644
-

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Samuel Pitoiset 

Looks like you forgot to update fbo-storage-formats.c.

With that fixed, patch is:

Reviewed-by: Samuel Pitoiset 

Thanks!

On 06/26/2017 08:00 AM, Timothy Arceri wrote:

---
  tests/fbo/fbo-1d.c |  1 +
  tests/fbo/fbo-3d.c |  1 +
  tests/fbo/fbo-alpha.c  |  1 +
  tests/fbo/fbo-alphatest-formats.c  |  1 +
  tests/fbo/fbo-alphatest-nocolor-ff.c   |  1 +
  tests/fbo/fbo-alphatest-nocolor.c  |  1 +
  tests/fbo/fbo-array.c  |  1 +
  tests/fbo/fbo-bind-renderbuffer.c  |  9 --
  tests/fbo/fbo-blending-formats.c   |  1 +
  tests/fbo/fbo-blit-d24s8.c |  1 +
  tests/fbo/fbo-blit-stretch.cpp |  1 +
  tests/fbo/fbo-blit.c   |  1 +
  tests/fbo/fbo-clear-formats.c  |  1 +
  tests/fbo/fbo-clearmipmap.c|  1 +
  tests/fbo/fbo-colormask-formats.c  |  1 +
  tests/fbo/fbo-copypix.c|  1 +
  tests/fbo/fbo-copyteximage-simple.c|  1 +
  tests/fbo/fbo-copyteximage.c   |  1 +
  tests/fbo/fbo-cubemap.c|  1 +
  tests/fbo/fbo-depth-array.c|  1 +
  tests/fbo/fbo-depth-tex1d.c|  1 +
  tests/fbo/fbo-depth.c  |  1 +
  tests/fbo/fbo-depthtex.c   |  1 +
  tests/fbo/fbo-deriv.c  |  1 +
  tests/fbo/fbo-draw-buffers-blend.c |  1 +
  tests/fbo/fbo-drawbuffers-arbfp.c  |  1 +
  tests/fbo/fbo-drawbuffers-blend-add.c  |  1 +
  tests/fbo/fbo-drawbuffers-fragcolor.c  |  1 +
  tests/fbo/fbo-drawbuffers-maxtargets.c |  1 +
  tests/fbo/fbo-drawbuffers.c|  1 +
  tests/fbo/fbo-drawbuffers2-blend.c |  1 +
  tests/fbo/fbo-drawbuffers2-colormask.c |  1 +
  tests/fbo/fbo-finish-deleted.c |  1 +
  tests/fbo/fbo-flushing-2.c |  1 +
  tests/fbo/fbo-flushing.c   |  1 +
  tests/fbo/fbo-fragcoord.c  |  1 +
  tests/fbo/fbo-fragcoord2.c |  1 +
  tests/fbo/fbo-generatemipmap-filtering.c   |  1 +
  tests/fbo/fbo-generatemipmap-formats.c |  1 +
  tests/fbo/fbo-generatemipmap-noimage.c |  1 +
  tests/fbo/fbo-generatemipmap-nonsquare.c   |  1 +
  tests/fbo/fbo-generatemipmap-npot.c|  1 +
  tests/fbo/fbo-generatemipmap-scissor.c |  1 +
  tests/fbo/fbo-generatemipmap-swizzle.c |  1 +
  tests/fbo/fbo-generatemipmap-viewport.c|  1 +
  tests/fbo/fbo-generatemipmap.c |  1 +
  .../fbo/fbo-getframebufferattachmentparameter-01.c | 36 +-
  tests/fbo/fbo-gl_pointcoord.c  |  1 +
  tests/fbo/fbo-incomplete-invalid-texture.c |  1 +
  tests/fbo/fbo-incomplete-texture-01.c  |  1 +
  tests/fbo/fbo-incomplete-texture-02.c  |  1 +
  tests/fbo/fbo-incomplete-texture-03.c  |  1 +
  tests/fbo/fbo-incomplete-texture-04.c  |  1 +
  tests/fbo/fbo-incomplete.cpp   |  1 +
  tests/fbo/fbo-integer.c|  1 +
  tests/fbo/fbo-luminance-alpha.c|  1 +
  tests/fbo/fbo-maxsize.c|  1 +
  tests/fbo/fbo-mipmap-copypix.c |  1 +
  tests/fbo/fbo-mrt-alphatest.c  |  1 +
  tests/fbo/fbo-mrt-new-bind.c   |  1 +
  tests/fbo/fbo-nodepth-test.c   |  1 +
  tests/fbo/fbo-nostencil-test.c |  1 +
  tests/fbo/fbo-pbo-readpixels-small.c   |  1 +
  tests/fbo/fbo-readdrawpix.c|  1 +
  tests/fbo/fbo-readpixels-depth-formats.c   |  1 +
  tests/fbo/fbo-readpixels.c |  1 +
  tests/fbo/fbo-rg.c |  1 +
  tests/fbo/fbo-scissor-bitmap.c |  1 +
  tests/fbo/fbo-scissor-blit.c   |  1 +
  tests/fbo/fbo-srgb.c   |  1 +
  tests/fbo/fbo-stencil.c|  1 +
  tests/fbo/fbo-storage-completeness.c   |  5 +--
  tests/fbo/fbo-storage-formats.c|  5 +--
  tests/fbo/fbo-sys-blit.c   |  1 +
  tests/fbo/fbo-sys-sub-blit.c   |  1 +
  tests/fbo/fbo-viewport.c   |  1 +
  76 files changed, 105 insertions(+), 22 deletions(-)

diff --git a/tests/fbo/fbo-1d.c b/tests/fbo/fbo-1d.c
index 63f36be..dfb9567 100644
--- a/tests/fbo/fbo-1d.c
+++ b/tests/fbo/fbo-1d.c
@@ -40,6 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGI

[Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-25 Thread Timothy Arceri 
---
 tests/fbo/fbo-1d.c |  1 +
 tests/fbo/fbo-3d.c |  1 +
 tests/fbo/fbo-alpha.c  |  1 +
 tests/fbo/fbo-alphatest-formats.c  |  1 +
 tests/fbo/fbo-alphatest-nocolor-ff.c   |  1 +
 tests/fbo/fbo-alphatest-nocolor.c  |  1 +
 tests/fbo/fbo-array.c  |  1 +
 tests/fbo/fbo-bind-renderbuffer.c  |  9 --
 tests/fbo/fbo-blending-formats.c   |  1 +
 tests/fbo/fbo-blit-d24s8.c |  1 +
 tests/fbo/fbo-blit-stretch.cpp |  1 +
 tests/fbo/fbo-blit.c   |  1 +
 tests/fbo/fbo-clear-formats.c  |  1 +
 tests/fbo/fbo-clearmipmap.c|  1 +
 tests/fbo/fbo-colormask-formats.c  |  1 +
 tests/fbo/fbo-copypix.c|  1 +
 tests/fbo/fbo-copyteximage-simple.c|  1 +
 tests/fbo/fbo-copyteximage.c   |  1 +
 tests/fbo/fbo-cubemap.c|  1 +
 tests/fbo/fbo-depth-array.c|  1 +
 tests/fbo/fbo-depth-tex1d.c|  1 +
 tests/fbo/fbo-depth.c  |  1 +
 tests/fbo/fbo-depthtex.c   |  1 +
 tests/fbo/fbo-deriv.c  |  1 +
 tests/fbo/fbo-draw-buffers-blend.c |  1 +
 tests/fbo/fbo-drawbuffers-arbfp.c  |  1 +
 tests/fbo/fbo-drawbuffers-blend-add.c  |  1 +
 tests/fbo/fbo-drawbuffers-fragcolor.c  |  1 +
 tests/fbo/fbo-drawbuffers-maxtargets.c |  1 +
 tests/fbo/fbo-drawbuffers.c|  1 +
 tests/fbo/fbo-drawbuffers2-blend.c |  1 +
 tests/fbo/fbo-drawbuffers2-colormask.c |  1 +
 tests/fbo/fbo-finish-deleted.c |  1 +
 tests/fbo/fbo-flushing-2.c |  1 +
 tests/fbo/fbo-flushing.c   |  1 +
 tests/fbo/fbo-fragcoord.c  |  1 +
 tests/fbo/fbo-fragcoord2.c |  1 +
 tests/fbo/fbo-generatemipmap-filtering.c   |  1 +
 tests/fbo/fbo-generatemipmap-formats.c |  1 +
 tests/fbo/fbo-generatemipmap-noimage.c |  1 +
 tests/fbo/fbo-generatemipmap-nonsquare.c   |  1 +
 tests/fbo/fbo-generatemipmap-npot.c|  1 +
 tests/fbo/fbo-generatemipmap-scissor.c |  1 +
 tests/fbo/fbo-generatemipmap-swizzle.c |  1 +
 tests/fbo/fbo-generatemipmap-viewport.c|  1 +
 tests/fbo/fbo-generatemipmap.c |  1 +
 .../fbo/fbo-getframebufferattachmentparameter-01.c | 36 +-
 tests/fbo/fbo-gl_pointcoord.c  |  1 +
 tests/fbo/fbo-incomplete-invalid-texture.c |  1 +
 tests/fbo/fbo-incomplete-texture-01.c  |  1 +
 tests/fbo/fbo-incomplete-texture-02.c  |  1 +
 tests/fbo/fbo-incomplete-texture-03.c  |  1 +
 tests/fbo/fbo-incomplete-texture-04.c  |  1 +
 tests/fbo/fbo-incomplete.cpp   |  1 +
 tests/fbo/fbo-integer.c|  1 +
 tests/fbo/fbo-luminance-alpha.c|  1 +
 tests/fbo/fbo-maxsize.c|  1 +
 tests/fbo/fbo-mipmap-copypix.c |  1 +
 tests/fbo/fbo-mrt-alphatest.c  |  1 +
 tests/fbo/fbo-mrt-new-bind.c   |  1 +
 tests/fbo/fbo-nodepth-test.c   |  1 +
 tests/fbo/fbo-nostencil-test.c |  1 +
 tests/fbo/fbo-pbo-readpixels-small.c   |  1 +
 tests/fbo/fbo-readdrawpix.c|  1 +
 tests/fbo/fbo-readpixels-depth-formats.c   |  1 +
 tests/fbo/fbo-readpixels.c |  1 +
 tests/fbo/fbo-rg.c |  1 +
 tests/fbo/fbo-scissor-bitmap.c |  1 +
 tests/fbo/fbo-scissor-blit.c   |  1 +
 tests/fbo/fbo-srgb.c   |  1 +
 tests/fbo/fbo-stencil.c|  1 +
 tests/fbo/fbo-storage-completeness.c   |  5 +--
 tests/fbo/fbo-storage-formats.c|  5 +--
 tests/fbo/fbo-sys-blit.c   |  1 +
 tests/fbo/fbo-sys-sub-blit.c   |  1 +
 tests/fbo/fbo-viewport.c   |  1 +
 76 files changed, 105 insertions(+), 22 deletions(-)

diff --git a/tests/fbo/fbo-1d.c b/tests/fbo/fbo-1d.c
index 63f36be..dfb9567 100644
--- a/tests/fbo/fbo-1d.c
+++ b/tests/fbo/fbo-1d.c
@@ -40,6 +40,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
config.supports_gl_compat_version = 10;
 
config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_DEPTH;
+   config.khr_no_error_support = PIGLIT_NO_ERRORS;
 
 PIGLIT_GL_TEST_CONFIG_END
 
diff --git a/tests/fbo/fbo-3d