Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
I've pushed this to master. Thanks! On Wed, May 20, 2015 at 02:17:04PM -0700, Mike Mason wrote: This patch adds an option to not retry incomplete tests when resuming a test run. This is especially useful when a failing test causes a crash or reboot. Currently, that same test runs again when attempting to resume the test run, resulting in the same crash or reboot. Signed-off-by: Mike Mason michael.w.ma...@intel.com --- framework/programs/run.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 6053074..c6d7afe 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -313,6 +313,10 @@ def resume(input_): type=argparse.FileType(r), help=Optionally specify a piglit config file to use. Default is piglit.conf) +parser.add_argument(-n, --no-retry, +dest=no_retry, +action=store_true, +help=Do not retry incomplete tests) args = parser.parse_args(input_) _disable_windows_exception_messages() @@ -342,7 +346,7 @@ def resume(input_): # Don't re-run tests that have already completed, incomplete status tests # have obviously not completed. for name, result in results.tests.iteritems(): -if result['result'] != 'incomplete': +if args.no_retry or result['result'] != 'incomplete': opts.exclude_tests.add(name) profile = framework.profile.merge_test_profiles(results.options['profile']) -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit signature.asc Description: Digital signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
This patch adds an option to not retry incomplete tests when resuming a test run. This is especially useful when a failing test causes a crash or reboot. Currently, that same test runs again when attempting to resume the test run, resulting in the same crash or reboot. Signed-off-by: Mike Mason michael.w.ma...@intel.com --- framework/programs/run.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 6053074..c6d7afe 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -313,6 +313,10 @@ def resume(input_): type=argparse.FileType(r), help=Optionally specify a piglit config file to use. Default is piglit.conf) +parser.add_argument(-n, --no-retry, +dest=no_retry, +action=store_true, +help=Do not retry incomplete tests) args = parser.parse_args(input_) _disable_windows_exception_messages() @@ -342,7 +346,7 @@ def resume(input_): # Don't re-run tests that have already completed, incomplete status tests # have obviously not completed. for name, result in results.tests.iteritems(): -if result['result'] != 'incomplete': +if args.no_retry or result['result'] != 'incomplete': opts.exclude_tests.add(name) profile = framework.profile.merge_test_profiles(results.options['profile']) -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
-Original Message- From: Dylan Baker [mailto:baker.dyla...@gmail.com] Sent: Wednesday, May 20, 2015 5:27 PM To: Mason, Michael W Cc: piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume Looks good to me. Reviewed-by: Dylan Baker baker.dyla...@gmail.com btw, do you have push access? I don't think so. I've never tried. On Wed, May 20, 2015 at 02:17:04PM -0700, Mike Mason wrote: This patch adds an option to not retry incomplete tests when resuming a test run. This is especially useful when a failing test causes a crash or reboot. Currently, that same test runs again when attempting to resume the test run, resulting in the same crash or reboot. Signed-off-by: Mike Mason michael.w.ma...@intel.com --- framework/programs/run.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 6053074..c6d7afe 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -313,6 +313,10 @@ def resume(input_): type=argparse.FileType(r), help=Optionally specify a piglit config file to use. Default is piglit.conf) +parser.add_argument(-n, --no-retry, +dest=no_retry, +action=store_true, +help=Do not retry incomplete tests) args = parser.parse_args(input_) _disable_windows_exception_messages() @@ -342,7 +346,7 @@ def resume(input_): # Don't re-run tests that have already completed, incomplete status tests # have obviously not completed. for name, result in results.tests.iteritems(): -if result['result'] != 'incomplete': +if args.no_retry or result['result'] != 'incomplete': opts.exclude_tests.add(name) profile = framework.profile.merge_test_profiles(results.options['profile']) -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
Looks good to me. Reviewed-by: Dylan Baker baker.dyla...@gmail.com btw, do you have push access? On Wed, May 20, 2015 at 02:17:04PM -0700, Mike Mason wrote: This patch adds an option to not retry incomplete tests when resuming a test run. This is especially useful when a failing test causes a crash or reboot. Currently, that same test runs again when attempting to resume the test run, resulting in the same crash or reboot. Signed-off-by: Mike Mason michael.w.ma...@intel.com --- framework/programs/run.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 6053074..c6d7afe 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -313,6 +313,10 @@ def resume(input_): type=argparse.FileType(r), help=Optionally specify a piglit config file to use. Default is piglit.conf) +parser.add_argument(-n, --no-retry, +dest=no_retry, +action=store_true, +help=Do not retry incomplete tests) args = parser.parse_args(input_) _disable_windows_exception_messages() @@ -342,7 +346,7 @@ def resume(input_): # Don't re-run tests that have already completed, incomplete status tests # have obviously not completed. for name, result in results.tests.iteritems(): -if result['result'] != 'incomplete': +if args.no_retry or result['result'] != 'incomplete': opts.exclude_tests.add(name) profile = framework.profile.merge_test_profiles(results.options['profile']) -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit signature.asc Description: Digital signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume
On Thu, May 21, 2015 at 12:31:40AM +, Mason, Michael W wrote: -Original Message- From: Dylan Baker [mailto:baker.dyla...@gmail.com] Sent: Wednesday, May 20, 2015 5:27 PM To: Mason, Michael W Cc: piglit@lists.freedesktop.org Subject: Re: [Piglit] [PATCH] framework/run.py: add option to not retry incomplete tests on resume Looks good to me. Reviewed-by: Dylan Baker baker.dyla...@gmail.com btw, do you have push access? I don't think so. I've never tried. If you don't know the answer is probably no. I'll push this tomorrow unless there are objections. Dylan signature.asc Description: Digital signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
