Re: [Piglit] [PATCH] shader_runner: some extra skip reasong logging

2019-06-24 Thread Dylan Baker
Reviewed-by: Dylan Baker 

Quoting Alejandro Piñeiro (2019-06-12 03:42:35)
> ---
>  tests/shaders/shader_runner.c | 13 ++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 44aa5da37..a2a1d43fb 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -1143,13 +1143,17 @@ process_requirement(const char *line)
>  
> if (parse_str(line, "GL_", NULL) &&
> parse_word_copy(line, buffer, sizeof(buffer), &line)) {
> -   if (!piglit_is_extension_supported(buffer))
> +   if (!piglit_is_extension_supported(buffer)) {
> +   printf("Test requires unsupported extension %s\n", 
> buffer);
> return PIGLIT_SKIP;
> +   }
> } else if (parse_str(line, "!", &line) &&
>parse_str(line, "GL_", NULL) &&
>parse_word_copy(line, buffer, sizeof(buffer), &line)) {
> -   if (piglit_is_extension_supported(buffer))
> +   if (piglit_is_extension_supported(buffer)) {
> +   printf("Test requires unsupported extension %s\n", 
> buffer);
> return PIGLIT_SKIP;
> +   }
> } else if (parse_str(line, "GLSL", &line)) {
> enum comparison cmp;
>  
> @@ -4727,8 +4731,11 @@ piglit_init(int argc, char **argv)
>  #endif
>  
> if (use_get_program_binary) {
> -   if (gl_num_program_binary_formats == 0)
> +   if (gl_num_program_binary_formats == 0) {
> +   printf("Trying to use get_program_binary, but "
> +  "GL_NUM_PROGRAM_BINARY == 0\n");
> piglit_report_result(PIGLIT_SKIP);
> +   }
> }
>  
> /* Automatic mode can run multiple tests per session. */
> -- 
> 2.19.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] shader_runner: some extra skip reasong logging

2019-06-12 Thread Alejandro Piñeiro
---
 tests/shaders/shader_runner.c | 13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 44aa5da37..a2a1d43fb 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@ -1143,13 +1143,17 @@ process_requirement(const char *line)
 
if (parse_str(line, "GL_", NULL) &&
parse_word_copy(line, buffer, sizeof(buffer), &line)) {
-   if (!piglit_is_extension_supported(buffer))
+   if (!piglit_is_extension_supported(buffer)) {
+   printf("Test requires unsupported extension %s\n", 
buffer);
return PIGLIT_SKIP;
+   }
} else if (parse_str(line, "!", &line) &&
   parse_str(line, "GL_", NULL) &&
   parse_word_copy(line, buffer, sizeof(buffer), &line)) {
-   if (piglit_is_extension_supported(buffer))
+   if (piglit_is_extension_supported(buffer)) {
+   printf("Test requires unsupported extension %s\n", 
buffer);
return PIGLIT_SKIP;
+   }
} else if (parse_str(line, "GLSL", &line)) {
enum comparison cmp;
 
@@ -4727,8 +4731,11 @@ piglit_init(int argc, char **argv)
 #endif
 
if (use_get_program_binary) {
-   if (gl_num_program_binary_formats == 0)
+   if (gl_num_program_binary_formats == 0) {
+   printf("Trying to use get_program_binary, but "
+  "GL_NUM_PROGRAM_BINARY == 0\n");
piglit_report_result(PIGLIT_SKIP);
+   }
}
 
/* Automatic mode can run multiple tests per session. */
-- 
2.19.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit