Re: [Piglit] [PATCH] tests/all.py: use list for asmparsertest command line arguments

2014-12-17 Thread Dylan Baker
LGTM,
Reviewed-by: Dylan Baker 

On Wednesday, December 17, 2014 10:24:38 AM Brian Paul wrote:
> Instead of passing a string like "asmparsertest ARBfp1.0 path/to/mad.txt",
> now pass a list like ["asmparsertest", "ARBfp1.0", path/to/mad.txt].
> 
> This fixes the asmparsertest tests on Cygwin.  Before, all the tests
> were failing because the backslash characters in the path were getting
> removed.
> ---
>  tests/all.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/all.py b/tests/all.py
> index fe623b8..e518222 100644
> --- a/tests/all.py
> +++ b/tests/all.py
> @@ -3738,8 +3738,8 @@ add_plain_test(fast_color_clear, 
> 'fcc-read-to-pbo-after-clear')
>  asmparsertest = {}
>  def add_asmparsertest(group, shader):
>  asmparsertest[group + '/' + shader] = PiglitGLTest(
> -'asmparsertest ' + group + ' ' +
> -os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader),
> +['asmparsertest', group,
> + os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader)],
>  run_concurrent=True)
>  
>  add_asmparsertest('ARBfp1.0', 'abs-01.txt')
> -- 
> 1.9.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
> 


signature.asc
Description: This is a digitally signed message part.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit


[Piglit] [PATCH] tests/all.py: use list for asmparsertest command line arguments

2014-12-17 Thread Brian Paul
Instead of passing a string like "asmparsertest ARBfp1.0 path/to/mad.txt",
now pass a list like ["asmparsertest", "ARBfp1.0", path/to/mad.txt].

This fixes the asmparsertest tests on Cygwin.  Before, all the tests
were failing because the backslash characters in the path were getting
removed.
---
 tests/all.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/all.py b/tests/all.py
index fe623b8..e518222 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -3738,8 +3738,8 @@ add_plain_test(fast_color_clear, 
'fcc-read-to-pbo-after-clear')
 asmparsertest = {}
 def add_asmparsertest(group, shader):
 asmparsertest[group + '/' + shader] = PiglitGLTest(
-'asmparsertest ' + group + ' ' +
-os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader),
+['asmparsertest', group,
+ os.path.join(testsDir, 'asmparsertest', 'shaders', group, shader)],
 run_concurrent=True)
 
 add_asmparsertest('ARBfp1.0', 'abs-01.txt')
-- 
1.9.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit