Re: [Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests
On Mon, 2016-10-24 at 11:58 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > ARB_shading_language_420pack > > > You may be interested in finishing off this patch: > > https://patchwork.freedesktop.org/patch/71093/ > > I never got around to implementing Francisco's comments that last time > I was working on this stuff. I'll give it a look. Thanks for noticing! ☺ -- Br, Andres ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests
On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > ARB_shading_language_420pack You may be interested in finishing off this patch: https://patchwork.freedesktop.org/patch/71093/ I never got around to implementing Francisco's comments that last time I was working on this stuff. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests
On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > This series complements the work done for mesa at: > https://lists.freedesktop.org/archives/mesa-dev/2016-October/132990.h > tml > > Briefing, this is a new set of tests that check the ability to > support > multiple layout-qualifers in a single declaration and that only the > right-most appearance of the same layout-qualifier-name, in a single > layout-qualifier or across multiple layout-qualifiers in a single > declaration is taken into account. > > The ARB_shading_language_420pack spec adds the support for multiple > layout-qualifiers in the same declaration. > > The ARB_enhanced_layouts spec adds the support to repeat the same > layout-qualifier-name inside a single layout-qualifier. > > In addition, I believe the ARB_enhanced_layouts spec also adds the > support for multiple layout-qualifiers in the same declaration. This > is not 100% clear to me since the addition in ARB_enhanced_layouts is > for a duplicated layout-qualifier-name in a single layout-qualifier > but it seems to make sense since the change builds up on the > precondition that multiple layout-qualifiers are already allowed in a > single declaration. This is because the spec is written against the GLSL 4.30 Specification. I don't believe this spec should add multiple layout- qualifiers in the same declaration. Its just that the spec text that is updated already contains the text. > > In any case, the specific tests which check this support are the ones > in patches 5/7 and 7/7 so they can be dropped straight away if I > didn't make a proper interpretation. > > Andres Gomez (7): > glsl-1.50: Add GS output layout qualifier redeclaration test > arb_tessellation_shader: Add tests for TCS output size > redeclaration > arb_enhanced_layouts: Add more xfb_stride redeclaration tests > arb_shading_language_420pack: More multiple layout qualifiers in a > single declaration tests > arb_enhanced_layouts: Multiple layout qualifiers in a single > declaration tests > arb_enhanced_layouts: More duplicated layout-qualifier-names tests > arb_enhanced_layouts: More multiple layout qualifiers in a single > declaration tests > > ...identifiers-in-single-declaration-mismatch.geom | 38 > +++ > ...vocation-identifiers-in-single-declaration.geom | 38 > +++ > ...tion-identifiers-in-single-layout-mismatch.geom | 38 > +++ > ...le-invocation-identifiers-in-single-layout.geom | 38 > +++ > ...identifiers-in-single-declaration-mismatch.comp | 38 > +++ > ...cal_size-identifiers-in-single-declaration.comp | 38 > +++ > ...size-identifiers-in-single-layout-mismatch.comp | 38 > +++ > ...le-local_size-identifiers-in-single-layout.comp | 38 > +++ > ...-in-single-declaration-no-enhanced-layouts.vert | 22 +++ > ...location-identifiers-in-single-declaration.vert | 23 +++ > ...identifiers-in-single-declaration-mismatch.geom | 40 > > ...vertices-identifiers-in-single-declaration.geom | 40 > > ...ices-identifiers-in-single-layout-mismatch.geom | 40 > > ...-max_vertices-identifiers-in-single-layout.geom | 40 > > ...gle-declaration-global-no-enhanced-layouts.geom | 27 > + > ...ifiers-in-single-declaration-layout-global.geom | 28 > ++ > ...-in-single-declaration-no-enhanced-layouts.geom | 25 > ...e-stream-identifiers-in-single-declaration.geom | 26 > + > ...identifiers-in-single-declaration-mismatch.tesc | 39 > +++ > ...vertices-identifiers-in-single-declaration.tesc | 39 > +++ > ...ices-identifiers-in-single-layout-mismatch.tesc | 39 > +++ > ...iple-vertices-identifiers-in-single-layout.tesc | 39 > +++ > ...identifiers-in-single-declaration-mismatch.vert | 41 > > ...k-global-identifiers-in-single-declaration.vert | 41 > > ...obal-identifiers-in-single-layout-mismatch.vert | 41 > > ...-block-global-identifiers-in-single-layout.vert | 41 > > ...identifiers-in-single-declaration-mismatch.vert | 44 > ++ > ...de-block-identifiers-in-single-declaration.vert | 44 > ++ > ...lock-identifiers-in-single-layout-mismatch.vert | 44 > ++ > ..._stride-block-identifiers-in-single-layout.vert | 44 > ++ > ...identifiers-in-single-declaration-mismatch.vert | 37 > ++ > ...e-global-identifiers-in-single-declaration.vert | 37 > ++ > ...obal-identifiers-in-single-layout-mismatch.vert | 37 > ++ > ...stride-global-identifiers-in-single-layout.vert | 37 > ++ > ...identifiers-in-single-declaration-mismatch.vert | 41 >
[Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests
This series complements the work done for mesa at: https://lists.freedesktop.org/archives/mesa-dev/2016-October/132990.html Briefing, this is a new set of tests that check the ability to support multiple layout-qualifers in a single declaration and that only the right-most appearance of the same layout-qualifier-name, in a single layout-qualifier or across multiple layout-qualifiers in a single declaration is taken into account. The ARB_shading_language_420pack spec adds the support for multiple layout-qualifiers in the same declaration. The ARB_enhanced_layouts spec adds the support to repeat the same layout-qualifier-name inside a single layout-qualifier. In addition, I believe the ARB_enhanced_layouts spec also adds the support for multiple layout-qualifiers in the same declaration. This is not 100% clear to me since the addition in ARB_enhanced_layouts is for a duplicated layout-qualifier-name in a single layout-qualifier but it seems to make sense since the change builds up on the precondition that multiple layout-qualifiers are already allowed in a single declaration. In any case, the specific tests which check this support are the ones in patches 5/7 and 7/7 so they can be dropped straight away if I didn't make a proper interpretation. Andres Gomez (7): glsl-1.50: Add GS output layout qualifier redeclaration test arb_tessellation_shader: Add tests for TCS output size redeclaration arb_enhanced_layouts: Add more xfb_stride redeclaration tests arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests arb_enhanced_layouts: Multiple layout qualifiers in a single declaration tests arb_enhanced_layouts: More duplicated layout-qualifier-names tests arb_enhanced_layouts: More multiple layout qualifiers in a single declaration tests ...identifiers-in-single-declaration-mismatch.geom | 38 +++ ...vocation-identifiers-in-single-declaration.geom | 38 +++ ...tion-identifiers-in-single-layout-mismatch.geom | 38 +++ ...le-invocation-identifiers-in-single-layout.geom | 38 +++ ...identifiers-in-single-declaration-mismatch.comp | 38 +++ ...cal_size-identifiers-in-single-declaration.comp | 38 +++ ...size-identifiers-in-single-layout-mismatch.comp | 38 +++ ...le-local_size-identifiers-in-single-layout.comp | 38 +++ ...-in-single-declaration-no-enhanced-layouts.vert | 22 +++ ...location-identifiers-in-single-declaration.vert | 23 +++ ...identifiers-in-single-declaration-mismatch.geom | 40 ...vertices-identifiers-in-single-declaration.geom | 40 ...ices-identifiers-in-single-layout-mismatch.geom | 40 ...-max_vertices-identifiers-in-single-layout.geom | 40 ...gle-declaration-global-no-enhanced-layouts.geom | 27 + ...ifiers-in-single-declaration-layout-global.geom | 28 ++ ...-in-single-declaration-no-enhanced-layouts.geom | 25 ...e-stream-identifiers-in-single-declaration.geom | 26 + ...identifiers-in-single-declaration-mismatch.tesc | 39 +++ ...vertices-identifiers-in-single-declaration.tesc | 39 +++ ...ices-identifiers-in-single-layout-mismatch.tesc | 39 +++ ...iple-vertices-identifiers-in-single-layout.tesc | 39 +++ ...identifiers-in-single-declaration-mismatch.vert | 41 ...k-global-identifiers-in-single-declaration.vert | 41 ...obal-identifiers-in-single-layout-mismatch.vert | 41 ...-block-global-identifiers-in-single-layout.vert | 41 ...identifiers-in-single-declaration-mismatch.vert | 44 ++ ...de-block-identifiers-in-single-declaration.vert | 44 ++ ...lock-identifiers-in-single-layout-mismatch.vert | 44 ++ ..._stride-block-identifiers-in-single-layout.vert | 44 ++ ...identifiers-in-single-declaration-mismatch.vert | 37 ++ ...e-global-identifiers-in-single-declaration.vert | 37 ++ ...obal-identifiers-in-single-layout-mismatch.vert | 37 ++ ...stride-global-identifiers-in-single-layout.vert | 37 ++ ...identifiers-in-single-declaration-mismatch.vert | 41 ...k-global-identifiers-in-single-declaration.vert | 41 ...obal-identifiers-in-single-layout-mismatch.vert | 41 ...dblock-global-identifiers-in-single-layout.vert | 41 ...identifiers-in-single-declaration-mismatch.vert | 44 ++ ...medblock-identifiers-in-single-declaration.vert | 44 ++ ...lock-identifiers-in-single-layout-mismatch.vert | 44 ++
