[Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
This patchset adds piglit tests for arb_shader_storage_buffer_object extension. They are also available on this repository: $ git clone -b arb_shader_storage_buffer_object-v1 \ https://github.com/Igalia/piglit.git Thanks, Sam Samuel Iglesias Gonsalvez (13): arb_shader_storage_buffer_object: Add preprocessor tests arb_shader_storage_buffer_object: add compiler tests arb_shader_storage_buffer_object: Add linker tests arb_shader_storage_buffer: Add rendering test arb_shader_storage_buffer_object: add test for GL_MAX_SHADER_STORAGE_BUFFER_SIZE arb_shader_storage_buffer_object: add test to check glGetIntegeri_v() queries arb_shader_storage_buffer_object: Add new test for glDeleteBuffers() behavior arb_shader_storage_buffer_object: Add test to check maximum number of allowed SSBOs arb_shader_storage_buffer_object: New test for setting/getting block bindings. arb_shader_storage_buffer_object: Add test for setting binding point to an array of SSBOs arb_shader_storage_buffer_object: add test to check SSBO writes with layout(std430) arb_shader_storage_buffer_object: add test to check SSBO writes with layout(std140) arb_shader_storage_buffer_object: Add test for buffer variable queries tests/all.py | 21 ++ .../CMakeLists.gl.txt | 10 + .../array-ssbo-binding.c | 149 + .../extension-disabled-shader-storage-block.frag | 15 + .../compiler/extension-disabled-std430.frag| 13 + .../compiler/layout-std430-non-shader-storage.frag | 24 ++ .../compiler/layout-std430-within-block.frag | 22 ++ .../compiler/shader-storage-block-initializer.frag | 21 ++ .../compiler/shader-storage-block-sampler.frag | 23 ++ .../compiler/shader-storage-outside-block.frag | 20 ++ .../compiler/unsized-array-argument-function.frag | 29 ++ .../unsized-array-not-in-last-position.frag| 24 ++ .../deletebuffers.c| 105 ++ .../getintegeri_v.c| 120 +++ .../layout-std140-write-shader.c | 161 + .../layout-std430-write-shader.c | 185 +++ ...hader-storage-block-different-def-2.shader_test | 40 +++ ...hader-storage-block-different-def-3.shader_test | 40 +++ .../shader-storage-block-different-def.shader_test | 38 +++ ...shader-storage-block-different-size.shader_test | 41 +++ .../arb_shader_storage_buffer_object/maxblocks.c | 358 + .../maxshaderstorageblocksize.c| 240 ++ .../preprocessor/define.frag | 19 ++ .../preprocessor/define.vert | 19 ++ .../program-interface-query.c | 166 ++ .../arb_shader_storage_buffer_object/rendering.c | 232 + .../shaderstorageblockbinding.c| 125 +++ 27 files changed, 2260 insertions(+) create mode 100644 tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-shader-storage-block.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-std430.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-non-shader-storage.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-within-block.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-initializer.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-sampler.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-outside-block.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-argument-function.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-not-in-last-position.frag create mode 100644 tests/spec/arb_shader_storage_buffer_object/deletebuffers.c create mode 100644 tests/spec/arb_shader_storage_buffer_object/getintegeri_v.c create mode 100644 tests/spec/arb_shader_storage_buffer_object/layout-std140-write-shader.c create mode 100644 tests/spec/arb_shader_storage_buffer_object/layout-std430-write-shader.c create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-2.shader_test create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-3.shader_test create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def.shader_test create mode 100644 tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-size.shader_test create mode 100644 tests/spec/arb_shader_storage_buffer
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
On 2015-05-13 23:17:12, Samuel Iglesias Gonsalvez wrote: > This patchset adds piglit tests for arb_shader_storage_buffer_object > extension. > > They are also available on this repository: > > $ git clone -b arb_shader_storage_buffer_object-v1 \ > https://github.com/Igalia/piglit.git > > Thanks, > > Sam > > Samuel Iglesias Gonsalvez (13): > arb_shader_storage_buffer_object: Add preprocessor tests > arb_shader_storage_buffer_object: add compiler tests > arb_shader_storage_buffer_object: Add linker tests > arb_shader_storage_buffer: Add rendering test > arb_shader_storage_buffer_object: add test for > GL_MAX_SHADER_STORAGE_BUFFER_SIZE > arb_shader_storage_buffer_object: add test to check glGetIntegeri_v() > queries > arb_shader_storage_buffer_object: Add new test for glDeleteBuffers() > behavior > arb_shader_storage_buffer_object: Add test to check maximum number of > allowed SSBOs > arb_shader_storage_buffer_object: New test for setting/getting block > bindings. > arb_shader_storage_buffer_object: Add test for setting binding point > to an array of SSBOs > arb_shader_storage_buffer_object: add test to check SSBO writes with > layout(std430) > arb_shader_storage_buffer_object: add test to check SSBO writes with > layout(std140) > arb_shader_storage_buffer_object: Add test for buffer variable queries > > tests/all.py | 21 ++ > .../CMakeLists.gl.txt | 10 + > .../array-ssbo-binding.c | 149 + > .../extension-disabled-shader-storage-block.frag | 15 + > .../compiler/extension-disabled-std430.frag| 13 + > .../compiler/layout-std430-non-shader-storage.frag | 24 ++ > .../compiler/layout-std430-within-block.frag | 22 ++ > .../compiler/shader-storage-block-initializer.frag | 21 ++ > .../compiler/shader-storage-block-sampler.frag | 23 ++ > .../compiler/shader-storage-outside-block.frag | 20 ++ > .../compiler/unsized-array-argument-function.frag | 29 ++ > .../unsized-array-not-in-last-position.frag| 24 ++ > .../deletebuffers.c| 105 ++ > .../getintegeri_v.c| 120 +++ > .../layout-std140-write-shader.c | 161 + > .../layout-std430-write-shader.c | 185 +++ > ...hader-storage-block-different-def-2.shader_test | 40 +++ > ...hader-storage-block-different-def-3.shader_test | 40 +++ > .../shader-storage-block-different-def.shader_test | 38 +++ > ...shader-storage-block-different-size.shader_test | 41 +++ > .../arb_shader_storage_buffer_object/maxblocks.c | 358 > + > .../maxshaderstorageblocksize.c| 240 ++ > .../preprocessor/define.frag | 19 ++ > .../preprocessor/define.vert | 19 ++ > .../program-interface-query.c | 166 ++ > .../arb_shader_storage_buffer_object/rendering.c | 232 + > .../shaderstorageblockbinding.c| 125 +++ > 27 files changed, 2260 insertions(+) > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-shader-storage-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-std430.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-non-shader-storage.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-within-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-initializer.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-sampler.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-outside-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-argument-function.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-not-in-last-position.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/deletebuffers.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/getintegeri_v.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/layout-std140-write-shader.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/layout-std430-write-shader.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-2.shader_test > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-3.shader_test > create mode 100644 > tests/spec/arb_sha
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
On 05/06/15 09:50, Jordan Justen wrote: > On 2015-05-13 23:17:12, Samuel Iglesias Gonsalvez wrote: >> This patchset adds piglit tests for arb_shader_storage_buffer_object >> extension. >> >> They are also available on this repository: >> >> $ git clone -b arb_shader_storage_buffer_object-v1 \ >> https://github.com/Igalia/piglit.git >> >> Thanks, >> >> Sam >> >> Samuel Iglesias Gonsalvez (13): >> arb_shader_storage_buffer_object: Add preprocessor tests >> arb_shader_storage_buffer_object: add compiler tests >> arb_shader_storage_buffer_object: Add linker tests >> arb_shader_storage_buffer: Add rendering test >> arb_shader_storage_buffer_object: add test for >> GL_MAX_SHADER_STORAGE_BUFFER_SIZE >> arb_shader_storage_buffer_object: add test to check glGetIntegeri_v() >> queries >> arb_shader_storage_buffer_object: Add new test for glDeleteBuffers() >> behavior >> arb_shader_storage_buffer_object: Add test to check maximum number of >> allowed SSBOs >> arb_shader_storage_buffer_object: New test for setting/getting block >> bindings. >> arb_shader_storage_buffer_object: Add test for setting binding point >> to an array of SSBOs >> arb_shader_storage_buffer_object: add test to check SSBO writes with >> layout(std430) >> arb_shader_storage_buffer_object: add test to check SSBO writes with >> layout(std140) >> arb_shader_storage_buffer_object: Add test for buffer variable queries >> >> tests/all.py | 21 ++ >> .../CMakeLists.gl.txt | 10 + >> .../array-ssbo-binding.c | 149 + >> .../extension-disabled-shader-storage-block.frag | 15 + >> .../compiler/extension-disabled-std430.frag| 13 + >> .../compiler/layout-std430-non-shader-storage.frag | 24 ++ >> .../compiler/layout-std430-within-block.frag | 22 ++ >> .../compiler/shader-storage-block-initializer.frag | 21 ++ >> .../compiler/shader-storage-block-sampler.frag | 23 ++ >> .../compiler/shader-storage-outside-block.frag | 20 ++ >> .../compiler/unsized-array-argument-function.frag | 29 ++ >> .../unsized-array-not-in-last-position.frag| 24 ++ >> .../deletebuffers.c| 105 ++ >> .../getintegeri_v.c| 120 +++ >> .../layout-std140-write-shader.c | 161 + >> .../layout-std430-write-shader.c | 185 +++ >> ...hader-storage-block-different-def-2.shader_test | 40 +++ >> ...hader-storage-block-different-def-3.shader_test | 40 +++ >> .../shader-storage-block-different-def.shader_test | 38 +++ >> ...shader-storage-block-different-size.shader_test | 41 +++ >> .../arb_shader_storage_buffer_object/maxblocks.c | 358 >> + >> .../maxshaderstorageblocksize.c| 240 ++ >> .../preprocessor/define.frag | 19 ++ >> .../preprocessor/define.vert | 19 ++ >> .../program-interface-query.c | 166 ++ >> .../arb_shader_storage_buffer_object/rendering.c | 232 + >> .../shaderstorageblockbinding.c| 125 +++ >> 27 files changed, 2260 insertions(+) >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-shader-storage-block.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-std430.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-non-shader-storage.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-within-block.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-initializer.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-sampler.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-outside-block.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-argument-function.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-not-in-last-position.frag >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/deletebuffers.c >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/getintegeri_v.c >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/layout-std140-write-shader.c >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/layout-std430-write-shader.c >> create mode 100644 >> tests/spec/arb_shader_storage_buffer_object/linker/shader-storage-block-different-def-2.shader_test >> create mode 100644 >> tests/spe
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
With the push of SSBO support in mesa, one of these tests continues to fail, but only on broadwell: piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding Standard Output /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding -auto -fbo piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching 3.3 context Wrong 0 value in buffer[1]: 0.00 Did you expect this test to pass on broadwell? -Mark Samuel Iglesias Gonsalvez writes: > This patchset adds piglit tests for arb_shader_storage_buffer_object > extension. > > They are also available on this repository: > > $ git clone -b arb_shader_storage_buffer_object-v1 \ > https://github.com/Igalia/piglit.git > > Thanks, > > Sam > > Samuel Iglesias Gonsalvez (13): > arb_shader_storage_buffer_object: Add preprocessor tests > arb_shader_storage_buffer_object: add compiler tests > arb_shader_storage_buffer_object: Add linker tests > arb_shader_storage_buffer: Add rendering test > arb_shader_storage_buffer_object: add test for > GL_MAX_SHADER_STORAGE_BUFFER_SIZE > arb_shader_storage_buffer_object: add test to check glGetIntegeri_v() > queries > arb_shader_storage_buffer_object: Add new test for glDeleteBuffers() > behavior > arb_shader_storage_buffer_object: Add test to check maximum number of > allowed SSBOs > arb_shader_storage_buffer_object: New test for setting/getting block > bindings. > arb_shader_storage_buffer_object: Add test for setting binding point > to an array of SSBOs > arb_shader_storage_buffer_object: add test to check SSBO writes with > layout(std430) > arb_shader_storage_buffer_object: add test to check SSBO writes with > layout(std140) > arb_shader_storage_buffer_object: Add test for buffer variable queries > > tests/all.py | 21 ++ > .../CMakeLists.gl.txt | 10 + > .../array-ssbo-binding.c | 149 + > .../extension-disabled-shader-storage-block.frag | 15 + > .../compiler/extension-disabled-std430.frag| 13 + > .../compiler/layout-std430-non-shader-storage.frag | 24 ++ > .../compiler/layout-std430-within-block.frag | 22 ++ > .../compiler/shader-storage-block-initializer.frag | 21 ++ > .../compiler/shader-storage-block-sampler.frag | 23 ++ > .../compiler/shader-storage-outside-block.frag | 20 ++ > .../compiler/unsized-array-argument-function.frag | 29 ++ > .../unsized-array-not-in-last-position.frag| 24 ++ > .../deletebuffers.c| 105 ++ > .../getintegeri_v.c| 120 +++ > .../layout-std140-write-shader.c | 161 + > .../layout-std430-write-shader.c | 185 +++ > ...hader-storage-block-different-def-2.shader_test | 40 +++ > ...hader-storage-block-different-def-3.shader_test | 40 +++ > .../shader-storage-block-different-def.shader_test | 38 +++ > ...shader-storage-block-different-size.shader_test | 41 +++ > .../arb_shader_storage_buffer_object/maxblocks.c | 358 > + > .../maxshaderstorageblocksize.c| 240 ++ > .../preprocessor/define.frag | 19 ++ > .../preprocessor/define.vert | 19 ++ > .../program-interface-query.c | 166 ++ > .../arb_shader_storage_buffer_object/rendering.c | 232 + > .../shaderstorageblockbinding.c| 125 +++ > 27 files changed, 2260 insertions(+) > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/array-ssbo-binding.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-shader-storage-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/extension-disabled-std430.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-non-shader-storage.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/layout-std430-within-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-initializer.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-block-sampler.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/shader-storage-outside-block.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-argument-function.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/compiler/unsized-array-not-in-last-position.frag > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/deletebuffers.c > create mode 100644 > tests/spec/arb_shader_storage_buffer_object/getintegeri_v.c > create mode 100644 > tests/spec/a
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
On 25 September 2015 at 16:40, Mark Janes wrote:
> With the push of SSBO support in mesa, one of these tests continues to
> fail, but only on broadwell:
>
> piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
>
> Standard Output
>
>
> /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding
> -auto -fbo
> piglit: debug: Requested an OpenGL 3.2 Core Context, and received a
> matching 3.3 context
>
> Wrong 0 value in buffer[1]: 0.00
>
The test seems to be comparing a float with an integer there. Perhaps
one should use {+,-}0.0f or lambda ?
float *map;
...
if (map[i] != 0) {
printf("Wrong %d value in buffer[0]: %.2f\n",
i, map[i]);
-Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
Emil Velikov writes:
> On 25 September 2015 at 16:40, Mark Janes wrote:
>> With the push of SSBO support in mesa, one of these tests continues to
>> fail, but only on broadwell:
>>
>> piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
A subsequent run on the CI shows this test to fail intermittently on
broadwell. I'm supposed to be taking the day off today, but I'll look
at this more thoroughly on Monday.
>>
>> Standard Output
>>
>>
>> /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding
>> -auto -fbo
>> piglit: debug: Requested an OpenGL 3.2 Core Context, and received a
>> matching 3.3 context
>>
>> Wrong 0 value in buffer[1]: 0.00
>>
> The test seems to be comparing a float with an integer there. Perhaps
> one should use {+,-}0.0f or lambda ?
>
> float *map;
> ...
> if (map[i] != 0) {
>printf("Wrong %d value in buffer[0]: %.2f\n",
> i, map[i]);
>
> -Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
On 25/09/15 22:56, Mark Janes wrote:
> Emil Velikov writes:
>
>> On 25 September 2015 at 16:40, Mark Janes wrote:
>>> With the push of SSBO support in mesa, one of these tests continues to
>>> fail, but only on broadwell:
>>>
>>> piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
>
> A subsequent run on the CI shows this test to fail intermittently on
> broadwell. I'm supposed to be taking the day off today, but I'll look
> at this more thoroughly on Monday.
We don't have any Broadwell machine. However we can help you with the
debugging, don't hesitate to contact Iago or me.
Thanks,
Sam
>
>>>
>>> Standard Output
>>>
>>>
>>> /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding
>>> -auto -fbo
>>> piglit: debug: Requested an OpenGL 3.2 Core Context, and received a
>>> matching 3.3 context
>>>
>>> Wrong 0 value in buffer[1]: 0.00
>>>
>> The test seems to be comparing a float with an integer there. Perhaps
>> one should use {+,-}0.0f or lambda ?
>>
>> float *map;
>> ...
>> if (map[i] != 0) {
>>printf("Wrong %d value in buffer[0]: %.2f\n",
>> i, map[i]);
>>
>> -Emil
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
On 28/09/15 10:17, Samuel Iglesias Gonsálvez wrote:
>
>
> On 25/09/15 22:56, Mark Janes wrote:
>> Emil Velikov writes:
>>
>>> On 25 September 2015 at 16:40, Mark Janes wrote:
With the push of SSBO support in mesa, one of these tests continues to
fail, but only on broadwell:
piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
>>
>> A subsequent run on the CI shows this test to fail intermittently on
>> broadwell. I'm supposed to be taking the day off today, but I'll look
>> at this more thoroughly on Monday.
>
> We don't have any Broadwell machine. However we can help you with the
> debugging, don't hesitate to contact Iago or me.
>
Is there any news?
Sam
> Thanks,
>
> Sam
>
>>
Standard Output
/tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding
-auto -fbo
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a
matching 3.3 context
Wrong 0 value in buffer[1]: 0.00
>>> The test seems to be comparing a float with an integer there. Perhaps
>>> one should use {+,-}0.0f or lambda ?
>>>
>>> float *map;
>>> ...
>>> if (map[i] != 0) {
>>>printf("Wrong %d value in buffer[0]: %.2f\n",
>>> i, map[i]);
>>>
>>> -Emil
>>
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 00/13] Add more arb_shader_storage_buffer_object tests
Emil Velikov writes:
> On 25 September 2015 at 16:40, Mark Janes wrote:
>> With the push of SSBO support in mesa, one of these tests continues to
>> fail, but only on broadwell:
>>
>> piglit.spec.arb_shader_storage_buffer_object.array-ssbo-binding
>>
>> Standard Output
>>
>>
>> /tmp/build_root/m64/lib/piglit/bin/arb_shader_storage_buffer_object-array-ssbo-binding
>> -auto -fbo
>> piglit: debug: Requested an OpenGL 3.2 Core Context, and received a
>> matching 3.3 context
>>
>> Wrong 0 value in buffer[1]: 0.00
>>
> The test seems to be comparing a float with an integer there. Perhaps
> one should use {+,-}0.0f or lambda ?
>
> float *map;
> ...
> if (map[i] != 0) {
>printf("Wrong %d value in buffer[0]: %.2f\n",
> i, map[i]);
The output of the test is confusing: a value of 0 or >10 is a failure.
The float comparison is not the issue.
>
> -Emil
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
