Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-07-30 Thread Andres Gomez
On Sun, 2018-07-29 at 13:10 +0100, Daniel Stone wrote:
> Hi,
> 
> On Mon, 23 Jul 2018 at 18:20, Eric Engestrom  wrote:
> > On Friday, 2018-07-20 09:41:12 +0300, Andres Gomez wrote:
> > > On Mon, 2018-06-11 at 12:15 +0100, Eric Engestrom wrote:
> > > > On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote:
> > > > > On 11 June 2018 at 05:40, Eric Engestrom  
> > > > > wrote:
> > > > > > Is there another canonical travis instance of piglit, and I should
> > > > > > remove the one I just set up?
> > > > > 
> > > > > That's as canonical as any other; I believe the Travis CI 
> > > > > functionality
> > > > > was added originally for individual developers to have the option of 
> > > > > testing
> > > > > their own patches. Having it run against the mesa3d GitHub read only
> > > > > mirror is good though.
> > > 
> > > That's right. In Igalia we also have our own GitHub forks and Travis CI
> > > testing [0][1].
> > > 
> > > I was just wondering if it would be worth that Juan and I join the
> > > mesa3d organization in GitHub ... maybe we can make use of the Travis
> > > CI there too but suppose we will still be using our own setting,
> > > mostly.
> > 
> > You'll have to ask DanielS for that :)
> 
> I'm more than happy to grant access if you give me your GitHub usernames.

Great!

Me: tanty
Juan: jasuarez

Thanks!

-- 
Br,

Andres
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-07-23 Thread Eric Engestrom
On Friday, 2018-07-20 09:41:12 +0300, Andres Gomez wrote:
> On Mon, 2018-06-11 at 12:15 +0100, Eric Engestrom wrote:
> > On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote:
> > > On 11 June 2018 at 05:40, Eric Engestrom  wrote:
> > > 
> > > > On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> > > > > 
> 
> ...
> 
> > > > 
> > > > Is there another canonical travis instance of piglit, and I should
> > > > remove the one I just set up?
> > > > 
> > > 
> > > That's as canonical as any other; I believe the Travis CI functionality
> > > was added originally for individual developers to have the option of 
> > > testing
> > > their own patches. Having it run against the mesa3d GitHub read only
> > > mirror is good though.
> 
> That's right. In Igalia we also have our own GitHub forks and Travis CI
> testing [0][1].
> 
> I was just wondering if it would be worth that Juan and I join the
> mesa3d organization in GitHub ... maybe we can make use of the Travis
> CI there too but suppose we will still be using our own setting,
> mostly.

You'll have to ask DanielS for that :)

> 
> > > The question of porting this testing functionality over to GitLab's CI is 
> > > a
> > > separate, but worthwhile, discussion to have.
> > 
> > Agreed, and until then I'll just leave the Travis instance of the Github
> > mirror running as is.
> 
> Juan has been already working on that for a while ... let's hope we'll
> start sending patches soon.
> 
> In any case, this is:
> 
> Reviewed-by: Andres Gomez 
> 
> [0] https://github.com/Igalia/piglit
> [1] https://travis-ci.org/Igalia/piglit
> -- 
> Br,
> 
> Andres
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-06-11 Thread Eric Engestrom
On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote:
> On 11 June 2018 at 05:40, Eric Engestrom  wrote:
> 
> > On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> > > Python 3.3 reached end-of-life in September 2017 [0].
> > >
> > > Continuous integration testing has identified a number of dependencies
> > are
> > > now failing on python 3.3, such as:
> > >
> > >   Collecting wheel
> > >   wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but
> > the running Python is 3.3.6
> > >   ...
> > >   OSError: Command /home/travis/build/E...generator/bin/python -
> > setuptools pip wheel failed with error code 1
> > >
> > > [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
> > >
> > > Signed-off-by: Rhys Kidd 
> >
> > I just set up the travis build for the github mirror of piglit [1] an
> > hour ago, and noticed this issue.
> >
> > Reviewed-by: Eric Engestrom 
> >
> > Have you also noticed the other issues [2] (asserts firing up)?
> >
> 
> Yes, have seen those. Those asserts() were the next thing I was going to
> dig into.

Brilliant, thanks :)

> 
> 
> >
> > Is there another canonical travis instance of piglit, and I should
> > remove the one I just set up?
> >
> 
> That's as canonical as any other; I believe the Travis CI functionality
> was added originally for individual developers to have the option of testing
> their own patches. Having it run against the mesa3d GitHub read only
> mirror is good though.
> 
> The question of porting this testing functionality over to GitLab's CI is a
> separate, but worthwhile, discussion to have.

Agreed, and until then I'll just leave the Travis instance of the Github
mirror running as is.

> 
> 
> >
> > [1] https://travis-ci.org/mesa3d/piglit
> > [2] https://travis-ci.org/mesa3d/piglit/builds/390672919
> >
> > > ---
> > >  .travis.yml | 2 --
> > >  tox.ini | 6 +++---
> > >  2 files changed, 3 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/.travis.yml b/.travis.yml
> > > index b4cbcca49..b6e8136e8 100644
> > > --- a/.travis.yml
> > > +++ b/.travis.yml
> > > @@ -15,8 +15,6 @@ matrix:
> > >include:
> > >  - python: 2.7
> > >env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> > > -- python: 3.3
> > > -  env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
> > >  - python: 3.4
> > >env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
> > >  - python: 3.5
> > > diff --git a/tox.ini b/tox.ini
> > > index 12e8abd9f..411972873 100644
> > > --- a/tox.ini
> > > +++ b/tox.ini
> > > @@ -1,5 +1,5 @@
> > >  [tox]
> > > -envlist = py{27,33,34,35,36}-{generator,noaccel},
> > py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> > > +envlist = py{27,34,35,36}-{generator,noaccel},
> > py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
> > >  skipsdist = True
> > >
> > >  [pytest]
> > > @@ -16,7 +16,7 @@ deps =
> > >  accel: simplejson
> > >  generator: numpy==1.7.0
> > >  mock==1.0.1
> > > -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> > > +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
> > >  py27-accel-nix: backports.lzma
> > >  py27-accel-nix: subprocess32
> > >  py{35,36}: mako==1.0.2
> > > @@ -26,7 +26,7 @@ deps =
> > >  pytest-raises
> > >  pytest-warnings
> > >  pytest-timeout
> > > -py{27,33,34}: mako==0.8.0
> > > +py{27,34}: mako==0.8.0
> > >  six==1.5.2
> > >  {accel,noaccel,streams}: jsonschema
> > >  streams: jsonstreams>=0.4.1
> > > --
> > > 2.17.1
> > >
> > > ___
> > > Piglit mailing list
> > > Piglit@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/piglit
> >
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-06-11 Thread Rhys Kidd
On 11 June 2018 at 05:40, Eric Engestrom  wrote:

> On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> > Python 3.3 reached end-of-life in September 2017 [0].
> >
> > Continuous integration testing has identified a number of dependencies
> are
> > now failing on python 3.3, such as:
> >
> >   Collecting wheel
> >   wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but
> the running Python is 3.3.6
> >   ...
> >   OSError: Command /home/travis/build/E...generator/bin/python -
> setuptools pip wheel failed with error code 1
> >
> > [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
> >
> > Signed-off-by: Rhys Kidd 
>
> I just set up the travis build for the github mirror of piglit [1] an
> hour ago, and noticed this issue.
>
> Reviewed-by: Eric Engestrom 
>
> Have you also noticed the other issues [2] (asserts firing up)?
>

Yes, have seen those. Those asserts() were the next thing I was going to
dig into.


>
> Is there another canonical travis instance of piglit, and I should
> remove the one I just set up?
>

That's as canonical as any other; I believe the Travis CI functionality
was added originally for individual developers to have the option of testing
their own patches. Having it run against the mesa3d GitHub read only
mirror is good though.

The question of porting this testing functionality over to GitLab's CI is a
separate, but worthwhile, discussion to have.


>
> [1] https://travis-ci.org/mesa3d/piglit
> [2] https://travis-ci.org/mesa3d/piglit/builds/390672919
>
> > ---
> >  .travis.yml | 2 --
> >  tox.ini | 6 +++---
> >  2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index b4cbcca49..b6e8136e8 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,8 +15,6 @@ matrix:
> >include:
> >  - python: 2.7
> >env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> > -- python: 3.3
> > -  env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
> >  - python: 3.4
> >env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
> >  - python: 3.5
> > diff --git a/tox.ini b/tox.ini
> > index 12e8abd9f..411972873 100644
> > --- a/tox.ini
> > +++ b/tox.ini
> > @@ -1,5 +1,5 @@
> >  [tox]
> > -envlist = py{27,33,34,35,36}-{generator,noaccel},
> py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> > +envlist = py{27,34,35,36}-{generator,noaccel},
> py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
> >  skipsdist = True
> >
> >  [pytest]
> > @@ -16,7 +16,7 @@ deps =
> >  accel: simplejson
> >  generator: numpy==1.7.0
> >  mock==1.0.1
> > -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> > +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
> >  py27-accel-nix: backports.lzma
> >  py27-accel-nix: subprocess32
> >  py{35,36}: mako==1.0.2
> > @@ -26,7 +26,7 @@ deps =
> >  pytest-raises
> >  pytest-warnings
> >  pytest-timeout
> > -py{27,33,34}: mako==0.8.0
> > +py{27,34}: mako==0.8.0
> >  six==1.5.2
> >  {accel,noaccel,streams}: jsonschema
> >  streams: jsonstreams>=0.4.1
> > --
> > 2.17.1
> >
> > ___
> > Piglit mailing list
> > Piglit@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/piglit
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-06-11 Thread Eric Engestrom
On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote:
> Python 3.3 reached end-of-life in September 2017 [0].
> 
> Continuous integration testing has identified a number of dependencies are
> now failing on python 3.3, such as:
> 
>   Collecting wheel
>   wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the 
> running Python is 3.3.6
>   ...
>   OSError: Command /home/travis/build/E...generator/bin/python - setuptools 
> pip wheel failed with error code 1
> 
> [0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life
> 
> Signed-off-by: Rhys Kidd 

I just set up the travis build for the github mirror of piglit [1] an
hour ago, and noticed this issue.

Reviewed-by: Eric Engestrom 

Have you also noticed the other issues [2] (asserts firing up)?

Is there another canonical travis instance of piglit, and I should
remove the one I just set up?

[1] https://travis-ci.org/mesa3d/piglit
[2] https://travis-ci.org/mesa3d/piglit/builds/390672919

> ---
>  .travis.yml | 2 --
>  tox.ini | 6 +++---
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index b4cbcca49..b6e8136e8 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,8 +15,6 @@ matrix:
>include:
>  - python: 2.7
>env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
> -- python: 3.3
> -  env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
>  - python: 3.4
>env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
>  - python: 3.5
> diff --git a/tox.ini b/tox.ini
> index 12e8abd9f..411972873 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -1,5 +1,5 @@
>  [tox]
> -envlist = py{27,33,34,35,36}-{generator,noaccel}, 
> py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
> +envlist = py{27,34,35,36}-{generator,noaccel}, 
> py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
>  skipsdist = True
>  
>  [pytest]
> @@ -16,7 +16,7 @@ deps =
>  accel: simplejson
>  generator: numpy==1.7.0
>  mock==1.0.1
> -py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
> +py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
>  py27-accel-nix: backports.lzma
>  py27-accel-nix: subprocess32
>  py{35,36}: mako==1.0.2
> @@ -26,7 +26,7 @@ deps =
>  pytest-raises
>  pytest-warnings
>  pytest-timeout
> -py{27,33,34}: mako==0.8.0
> +py{27,34}: mako==0.8.0
>  six==1.5.2
>  {accel,noaccel,streams}: jsonschema
>  streams: jsonstreams>=0.4.1
> -- 
> 2.17.1
> 
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit


[Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

2018-06-09 Thread Rhys Kidd
Python 3.3 reached end-of-life in September 2017 [0].

Continuous integration testing has identified a number of dependencies are
now failing on python 3.3, such as:

  Collecting wheel
  wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the 
running Python is 3.3.6
  ...
  OSError: Command /home/travis/build/E...generator/bin/python - setuptools pip 
wheel failed with error code 1

[0] https://www.python.org/dev/peps/pep-0398/#x-end-of-life

Signed-off-by: Rhys Kidd 
---
 .travis.yml | 2 --
 tox.ini | 6 +++---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index b4cbcca49..b6e8136e8 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,8 +15,6 @@ matrix:
   include:
 - python: 2.7
   env: TOX_ENV="py27-{generator,noaccel,accel-nix,streams}"
-- python: 3.3
-  env: TOX_ENV="py33-{generator,noaccel,accel-nix,streams}"
 - python: 3.4
   env: TOX_ENV="py34-{generator,noaccel,accel-nix,streams}"
 - python: 3.5
diff --git a/tox.ini b/tox.ini
index 12e8abd9f..411972873 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-envlist = py{27,33,34,35,36}-{generator,noaccel}, 
py{27,33,34,35,36}-accel-{win,nix}, py{27,33,34,35,36}-streams
+envlist = py{27,34,35,36}-{generator,noaccel}, 
py{27,34,35,36}-accel-{win,nix}, py{27,34,35,36}-streams
 skipsdist = True
 
 [pytest]
@@ -16,7 +16,7 @@ deps =
 accel: simplejson
 generator: numpy==1.7.0
 mock==1.0.1
-py27-accel-nix,py{33,34,35,36}-{accel,noaccel}: psutil
+py27-accel-nix,py{34,35,36}-{accel,noaccel}: psutil
 py27-accel-nix: backports.lzma
 py27-accel-nix: subprocess32
 py{35,36}: mako==1.0.2
@@ -26,7 +26,7 @@ deps =
 pytest-raises
 pytest-warnings
 pytest-timeout
-py{27,33,34}: mako==0.8.0
+py{27,34}: mako==0.8.0
 six==1.5.2
 {accel,noaccel,streams}: jsonschema
 streams: jsonstreams>=0.4.1
-- 
2.17.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit