Re: [Piglit] [PATCH 1/2] tox: use six >= 1.10.0

2017-12-18 Thread Juan A. Suarez Romero 
On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote:

I've been talking with Andres about this series.

The thing is that in tox.ini we ask for pytest>=3.0.3. And the latest
version, 3.3.1, comes with a couple of drawbacks:

- It doesn't work with python 3.3.
- It doesn't work with PythonSix 1.5.2 (it requires 1.10.0 or greater).


The patches in the series just remove support for python 3.3 and bump
up PythonSix version to 1.10.0


But actually, we want to keep the current PythonSix version, and also
be able to test with python3.3, as piglit can be used with python3.3.

Hence, we agreed it is better to test using pyttest<3.3.1, and forget
about this series.

I'll send a new version to fix this issue.


> ---
>  tox.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tox.ini b/tox.ini
> index c1b7a0104..2bd99f544 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -27,7 +27,7 @@ deps =
>  pytest-warnings
>  pytest-timeout
>  py{27,33,34}: mako==0.8.0
> -six==1.5.2
> +six>=1.10.0
>  {accel,noaccel,streams}: jsonschema
>  streams: jsonstreams>=0.4.1
>  commands = 
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] tox: use six >= 1.10.0

2017-12-18 Thread Andres Gomez 
On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote:
> ---
>  tox.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tox.ini b/tox.ini
> index c1b7a0104..2bd99f544 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -27,7 +27,7 @@ deps =
>  pytest-warnings
>  pytest-timeout
>  py{27,33,34}: mako==0.8.0
> -six==1.5.2
> +six>=1.10.0

It feels safer to me just to remove the explicit version dependency.
pytest is already demanding a specific minimum version so, if it is
available, it should be already installed in the first place, isn't it?

-- 
Br,

Andres
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] tox: use six >= 1.10.0

2017-12-15 Thread Brian Paul 

On 12/15/2017 03:57 AM, Juan A. Suarez Romero wrote:

---
  tox.ini | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index c1b7a0104..2bd99f544 100644
--- a/tox.ini
+++ b/tox.ini
@@ -27,7 +27,7 @@ deps =
  pytest-warnings
  pytest-timeout
  py{27,33,34}: mako==0.8.0
-six==1.5.2
+six>=1.10.0
  {accel,noaccel,streams}: jsonschema
  streams: jsonstreams>=0.4.1
  commands =



The change looks fine, but the commit message should say why the change 
is being made.


-Brian

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] tox: use six >= 1.10.0

2017-12-15 Thread Juan A. Suarez Romero 
---
 tox.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index c1b7a0104..2bd99f544 100644
--- a/tox.ini
+++ b/tox.ini
@@ -27,7 +27,7 @@ deps =
 pytest-warnings
 pytest-timeout
 py{27,33,34}: mako==0.8.0
-six==1.5.2
+six>=1.10.0
 {accel,noaccel,streams}: jsonschema
 streams: jsonstreams>=0.4.1
 commands = 
-- 
2.15.1

___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit