Re: [Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
On Friday, November 21, 2014 09:11:32 PM Jose Fonseca wrote: > On 21/11/14 20:27, Dylan Baker wrote: > > On Friday, November 21, 2014 07:37:20 PM Jose Fonseca wrote: > >> Dylan, > >> > >> I'm not sure you guys are still using the junit backend regularly or > >> not. Would be the change below OK? > >> > >> BTW, I finished transition all my jenkins' piglit jobs to the junit > >> backend. > >> > >> Feel free to remove the summary-junit code, or let me know if you rather > >> I do it. > > > > Would you do it please? > > Will do. > > > > >> > >> Jose > > > > We are still using it regularly, Mark is our guy that runs the Jenkins > > stuff, I've CC'd him to see what he thinks. > > > >> > >> On 20/11/14 12:06, jfons...@vmware.com wrote: > >>> From: José Fonseca > >>> > >>> Showing the command line of the test is quite useful, specially when > >>> diagnosing failures. > >>> > >>> Unfortunately JUnit format allows no better place to have it other than > >>> stdout/stderr. > >>> --- > >>>framework/backends/junit.py | 3 +++ > >>>1 file changed, 3 insertions(+) > >>> > >>> diff --git a/framework/backends/junit.py b/framework/backends/junit.py > >>> index 1c27e98..59d06c6 100644 > >>> --- a/framework/backends/junit.py > >>> +++ b/framework/backends/junit.py > >>> @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend): > >>>out = etree.SubElement(element, 'system-out') > >>>out.text = data['out'] > >>> > >>> +# Prepend command line to stdout > >>> +out.text = data['command'] + '\n' + out.text > >>> + > > > > If Marks okay with it. > > > > Otherwise I sent out a series a couple months ago titled > > 'Junit backend: add more data to the junit output', the last patch of > > that series puts the command in the failure message attribute, of > > course, that means only failures will have the command attached. > > I missed that. I'll take a look. > > I don't feel strongly either way -- command line just on failures or all > the time. > > Jose Doesn't matter to me either. Whatever is more useful is fine. > > > > >>># Add stderr > >>>err = etree.SubElement(element, 'system-err') > >>>err.text = data['err'] > >>> > >> > >> ___ > >> Piglit mailing list > >> Piglit@lists.freedesktop.org > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_piglit&d=AAIFAw&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=kR9Scj4Mn-JTqAxpmjdw7SYS-lti9vjSS3Rw7yIUKXY&s=2DpWFsEjjBxILEoiJCDSj3CJ2u8tglXcS4Oh-1FhZqY&e= > >> > signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
On 21/11/14 20:27, Dylan Baker wrote: On Friday, November 21, 2014 07:37:20 PM Jose Fonseca wrote: Dylan, I'm not sure you guys are still using the junit backend regularly or not. Would be the change below OK? BTW, I finished transition all my jenkins' piglit jobs to the junit backend. Feel free to remove the summary-junit code, or let me know if you rather I do it. Would you do it please? Will do. Jose We are still using it regularly, Mark is our guy that runs the Jenkins stuff, I've CC'd him to see what he thinks. On 20/11/14 12:06, jfons...@vmware.com wrote: From: José Fonseca Showing the command line of the test is quite useful, specially when diagnosing failures. Unfortunately JUnit format allows no better place to have it other than stdout/stderr. --- framework/backends/junit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 1c27e98..59d06c6 100644 --- a/framework/backends/junit.py +++ b/framework/backends/junit.py @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend): out = etree.SubElement(element, 'system-out') out.text = data['out'] +# Prepend command line to stdout +out.text = data['command'] + '\n' + out.text + If Marks okay with it. Otherwise I sent out a series a couple months ago titled 'Junit backend: add more data to the junit output', the last patch of that series puts the command in the failure message attribute, of course, that means only failures will have the command attached. I missed that. I'll take a look. I don't feel strongly either way -- command line just on failures or all the time. Jose # Add stderr err = etree.SubElement(element, 'system-err') err.text = data['err'] ___ Piglit mailing list Piglit@lists.freedesktop.org https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_piglit&d=AAIFAw&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=kR9Scj4Mn-JTqAxpmjdw7SYS-lti9vjSS3Rw7yIUKXY&s=2DpWFsEjjBxILEoiJCDSj3CJ2u8tglXcS4Oh-1FhZqY&e= ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
Dylan Baker writes: > On Friday, November 21, 2014 07:37:20 PM Jose Fonseca wrote: >> On 20/11/14 12:06, jfons...@vmware.com wrote: >> > From: José Fonseca >> > >> > Showing the command line of the test is quite useful, specially when >> > diagnosing failures. > > If Marks okay with it. I like this change. I regularly find myself running the other backend manually to get the command. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
On Friday, November 21, 2014 07:37:20 PM Jose Fonseca wrote: > Dylan, > > I'm not sure you guys are still using the junit backend regularly or > not. Would be the change below OK? > > BTW, I finished transition all my jenkins' piglit jobs to the junit backend. > > Feel free to remove the summary-junit code, or let me know if you rather > I do it. Would you do it please? > > Jose We are still using it regularly, Mark is our guy that runs the Jenkins stuff, I've CC'd him to see what he thinks. > > On 20/11/14 12:06, jfons...@vmware.com wrote: > > From: José Fonseca > > > > Showing the command line of the test is quite useful, specially when > > diagnosing failures. > > > > Unfortunately JUnit format allows no better place to have it other than > > stdout/stderr. > > --- > > framework/backends/junit.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/framework/backends/junit.py b/framework/backends/junit.py > > index 1c27e98..59d06c6 100644 > > --- a/framework/backends/junit.py > > +++ b/framework/backends/junit.py > > @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend): > > out = etree.SubElement(element, 'system-out') > > out.text = data['out'] > > > > +# Prepend command line to stdout > > +out.text = data['command'] + '\n' + out.text > > + If Marks okay with it. Otherwise I sent out a series a couple months ago titled 'Junit backend: add more data to the junit output', the last patch of that series puts the command in the failure message attribute, of course, that means only failures will have the command attached. > > # Add stderr > > err = etree.SubElement(element, 'system-err') > > err.text = data['err'] > > > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit > signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
Dylan, I'm not sure you guys are still using the junit backend regularly or not. Would be the change below OK? BTW, I finished transition all my jenkins' piglit jobs to the junit backend. Feel free to remove the summary-junit code, or let me know if you rather I do it. Jose On 20/11/14 12:06, jfons...@vmware.com wrote: From: José Fonseca Showing the command line of the test is quite useful, specially when diagnosing failures. Unfortunately JUnit format allows no better place to have it other than stdout/stderr. --- framework/backends/junit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 1c27e98..59d06c6 100644 --- a/framework/backends/junit.py +++ b/framework/backends/junit.py @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend): out = etree.SubElement(element, 'system-out') out.text = data['out'] +# Prepend command line to stdout +out.text = data['command'] + '\n' + out.text + # Add stderr err = etree.SubElement(element, 'system-err') err.text = data['err'] ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH 2/2] framework/backends/junit: Prepend command line to stdout.
From: José Fonseca Showing the command line of the test is quite useful, specially when diagnosing failures. Unfortunately JUnit format allows no better place to have it other than stdout/stderr. --- framework/backends/junit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 1c27e98..59d06c6 100644 --- a/framework/backends/junit.py +++ b/framework/backends/junit.py @@ -144,6 +144,9 @@ class JUnitBackend(FileBackend): out = etree.SubElement(element, 'system-out') out.text = data['out'] +# Prepend command line to stdout +out.text = data['command'] + '\n' + out.text + # Add stderr err = etree.SubElement(element, 'system-err') err.text = data['err'] -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
