Re: [Piglit] [PATCH v2] Ignore piglit warning status in JUnit
I don't have the full sources here, but assuming that warm will become pass, you can add my reviewed-by On Jun 26, 2015 3:35 PM, "Ilia Mirkin" wrote: > Reviewed-by: Ilia Mirkin > > On Fri, Jun 26, 2015 at 6:35 PM, Mark Janes > wrote: > > JUnit has no concept of "warning". It supports the following > > statuses: > > > > - skip > > - success > > - fail > > - error > > > > A test which emits a warning is more accurately represented as > > "success" in JUnit. > > > > v2: Continue to report failure for "dmesg-warn", which is more serious > > than "warn". (from Ilia Mirkin) > > --- > > framework/backends/junit.py | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/framework/backends/junit.py b/framework/backends/junit.py > > index 632e516..8c8639e 100644 > > --- a/framework/backends/junit.py > > +++ b/framework/backends/junit.py > > @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend): > > if data['result'] == 'skip': > > res = etree.SubElement(element, 'skipped') > > > > -elif data['result'] in ['warn', 'fail', 'dmesg-warn', > > -'dmesg-fail']: > > +elif data['result'] in ['fail', 'dmesg-warn', 'dmesg-fail']: > > if expected_result == "failure": > > err.text += "\n\nWARN: passing test as an expected > failure" > > res = etree.SubElement(element, 'skipped', > > -- > > 2.1.4 > > > ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH v2] Ignore piglit warning status in JUnit
JUnit has no concept of "warning". It supports the following statuses: - skip - success - fail - error A test which emits a warning is more accurately represented as "success" in JUnit. v2: Continue to report failure for "dmesg-warn", which is more serious than "warn". (from Ilia Mirkin) --- framework/backends/junit.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 632e516..8c8639e 100644 --- a/framework/backends/junit.py +++ b/framework/backends/junit.py @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend): if data['result'] == 'skip': res = etree.SubElement(element, 'skipped') -elif data['result'] in ['warn', 'fail', 'dmesg-warn', -'dmesg-fail']: +elif data['result'] in ['fail', 'dmesg-warn', 'dmesg-fail']: if expected_result == "failure": err.text += "\n\nWARN: passing test as an expected failure" res = etree.SubElement(element, 'skipped', -- 2.1.4 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH v2] Ignore piglit warning status in JUnit
Reviewed-by: Ilia Mirkin On Fri, Jun 26, 2015 at 6:35 PM, Mark Janes wrote: > JUnit has no concept of "warning". It supports the following > statuses: > > - skip > - success > - fail > - error > > A test which emits a warning is more accurately represented as > "success" in JUnit. > > v2: Continue to report failure for "dmesg-warn", which is more serious > than "warn". (from Ilia Mirkin) > --- > framework/backends/junit.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/framework/backends/junit.py b/framework/backends/junit.py > index 632e516..8c8639e 100644 > --- a/framework/backends/junit.py > +++ b/framework/backends/junit.py > @@ -142,8 +142,7 @@ class JUnitBackend(FileBackend): > if data['result'] == 'skip': > res = etree.SubElement(element, 'skipped') > > -elif data['result'] in ['warn', 'fail', 'dmesg-warn', > -'dmesg-fail']: > +elif data['result'] in ['fail', 'dmesg-warn', 'dmesg-fail']: > if expected_result == "failure": > err.text += "\n\nWARN: passing test as an expected > failure" > res = etree.SubElement(element, 'skipped', > -- > 2.1.4 > ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
